Upgrading to Angular 20:

Replaced checked in package-lock.json by regenerated one. Ran ng update @angular/core@20 @angular/cli@20 Ran npm install @angular-builders/jest@^20.0.0 @fortawesome/angular-fontawesome@^3.0.0 @swimlane/ngx-graph@^11 Ran npm install ngx-mat-select-search@^8.0.2. Ran ng update @angular/material@20. Updated all eslint and typescript to the latest versions. Removed @angular-devkit/schematics. Updated fontawesome. Updated rxjs and tslib. Moved required node version from 16 to 20. Updated jest-preset-angular. Set preserveWhitespaces to false. Corrected two type declarations in two typescript files to make ng serve run without errors. Removed unused angular-devkit/schematics from view-user.component.ts . Updated list of supported browsers. Upgraded prettier. Ran prettier . --write the first time. Ran prettier . --write the second time. Ran ng generate @angular/core:inject with defaults, excepted a handful of files. Fixed remaining eslint problems. Added dist directory to ignores in eslint.config.js. Let prettier fix formatting, almost everything is just line breaks. Made htmlhint ignore @if and @for Angular constructs. Updated node version in Github workflow to 22.12.0 (build.yml). Updated .env.ts. Updated Angular datetime format strings from YYYY-MM-DD to yyyy-MM-dd. Merged changes from dev into angular20 branch.
2025-12-08 11:01:01 +01:00
parent f1b4ec2cf2
commit 7fd1486c08
1516 changed files with 39367 additions and 36037 deletions
@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Injectable } from '@angular/core';
+import { Injectable, inject } from '@angular/core';

 /** rxjs Imports */
 import { Observable } from 'rxjs';
@@ -12,10 +12,7 @@ import { AccountingService } from '../../accounting.service';
 */
@Injectable()
 export class ChartOfAccountsTemplateResolver {
-  /**
-   * @param {AccountingService} accountingService Accounting service.
-   */
-  constructor(private accountingService: AccountingService) {}
+  private accountingService = inject(AccountingService);

  /**
   * Returns the chart of accounts template data.
@@ -6,65 +6,69 @@
          <mat-form-field class="flex-48">
            <mat-label>{{ 'labels.inputs.Account Type' | translate }}</mat-label>
            <mat-select required formControlName="type">
-              <mat-option *ngFor="let accountType of accountTypeData" [value]="accountType.id">
-                {{ 'labels.inputs.accounting.' + accountType.value | translate }}
-              </mat-option>
+              @for (accountType of accountTypeData; track accountType) {
+                <mat-option [value]="accountType.id">
+                  {{ 'labels.inputs.accounting.' + accountType.value | translate }}
+                </mat-option>
+              }
            </mat-select>
-            <mat-error
-              *ngIf="
-                glAccountForm.controls.type.hasError('required') &&
-                (glAccountForm.controls.type.touched || glAccountForm.controls.type.dirty)
-              "
-            >
-              {{ 'labels.inputs.Account Type' | translate }} {{ 'labels.commons.is' | translate }}
-              <strong>{{ 'labels.commons.required' | translate }}</strong>
-            </mat-error>
+            @if (
+              glAccountForm.controls.type.hasError('required') &&
+              (glAccountForm.controls.type.touched || glAccountForm.controls.type.dirty)
+            ) {
+              <mat-error>
+                {{ 'labels.inputs.Account Type' | translate }} {{ 'labels.commons.is' | translate }}
+                <strong>{{ 'labels.commons.required' | translate }}</strong>
+              </mat-error>
+            }
          </mat-form-field>

          <mat-form-field class="flex-48">
            <mat-label>{{ 'labels.inputs.Account Name' | translate }}</mat-label>
            <input matInput required formControlName="name" />
-            <mat-error
-              *ngIf="
-                glAccountForm.controls.name.hasError('required') &&
-                (glAccountForm.controls.name.touched || glAccountForm.controls.name.dirty)
-              "
-            >
-              {{ 'labels.inputs.Account Name' | translate }} {{ 'labels.commons.is' | translate }}
-              <strong>{{ 'labels.commons.required' | translate }}</strong>
-            </mat-error>
+            @if (
+              glAccountForm.controls.name.hasError('required') &&
+              (glAccountForm.controls.name.touched || glAccountForm.controls.name.dirty)
+            ) {
+              <mat-error>
+                {{ 'labels.inputs.Account Name' | translate }} {{ 'labels.commons.is' | translate }}
+                <strong>{{ 'labels.commons.required' | translate }}</strong>
+              </mat-error>
+            }
          </mat-form-field>

          <mat-form-field class="flex-48">
            <mat-label>{{ 'labels.inputs.Account Usage' | translate }}</mat-label>
            <mat-select required formControlName="usage">
-              <mat-option *ngFor="let accountUsage of accountUsageData" [value]="accountUsage.id">
-                {{ accountUsage.value }}
-              </mat-option>
+              @for (accountUsage of accountUsageData; track accountUsage) {
+                <mat-option [value]="accountUsage.id">
+                  {{ accountUsage.value }}
+                </mat-option>
+              }
            </mat-select>
-            <mat-error
-              *ngIf="
-                glAccountForm.controls.usage.hasError('required') &&
-                (glAccountForm.controls.usage.touched || glAccountForm.controls.usage.dirty)
-              "
-            >
-              {{ 'labels.inputs.Account Usage' | translate }} {{ 'labels.commons.is' | translate }}
-              <strong>{{ 'labels.commons.required' | translate }}</strong>
-            </mat-error>
+            @if (
+              glAccountForm.controls.usage.hasError('required') &&
+              (glAccountForm.controls.usage.touched || glAccountForm.controls.usage.dirty)
+            ) {
+              <mat-error>
+                {{ 'labels.inputs.Account Usage' | translate }} {{ 'labels.commons.is' | translate }}
+                <strong>{{ 'labels.commons.required' | translate }}</strong>
+              </mat-error>
+            }
          </mat-form-field>

          <mat-form-field class="flex-48">
            <mat-label>{{ 'labels.inputs.GL Code' | translate }}</mat-label>
            <input matInput required formControlName="glCode" />
-            <mat-error
-              *ngIf="
-                glAccountForm.controls.glCode.hasError('required') &&
-                (glAccountForm.controls.glCode.touched || glAccountForm.controls.glCode.dirty)
-              "
-            >
-              {{ 'labels.inputs.GL Code' | translate }} {{ 'labels.commons.is' | translate }}
-              <strong>{{ 'labels.commons.required' | translate }}</strong>
-            </mat-error>
+            @if (
+              glAccountForm.controls.glCode.hasError('required') &&
+              (glAccountForm.controls.glCode.touched || glAccountForm.controls.glCode.dirty)
+            ) {
+              <mat-error>
+                {{ 'labels.inputs.GL Code' | translate }} {{ 'labels.commons.is' | translate }}
+                <strong>{{ 'labels.commons.required' | translate }}</strong>
+              </mat-error>
+            }
          </mat-form-field>

          <mifosx-gl-account-selector
@@ -79,9 +83,11 @@
          <mat-form-field class="flex-28">
            <mat-label>{{ 'labels.inputs.Tag' | translate }}</mat-label>
            <mat-select formControlName="tagId">
-              <mat-option *ngFor="let tag of tagData" [value]="tag.id">
-                {{ tag.name }}
-              </mat-option>
+              @for (tag of tagData; track tag) {
+                <mat-option [value]="tag.id">
+                  {{ tag.name }}
+                </mat-option>
+              }
            </mat-select>
          </mat-form-field>

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, TemplateRef, ElementRef, ViewChild, AfterViewInit } from '@angular/core';
+import { Component, OnInit, TemplateRef, ElementRef, ViewChild, AfterViewInit, inject } from '@angular/core';
 import { UntypedFormGroup, UntypedFormBuilder, Validators, ReactiveFormsModule } from '@angular/forms';
 import { Router, ActivatedRoute, RouterLink } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
@@ -32,6 +32,14 @@ import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
  ]
 })
 export class CreateGlAccountComponent implements OnInit, AfterViewInit {
+  private formBuilder = inject(UntypedFormBuilder);
+  private accountingService = inject(AccountingService);
+  private route = inject(ActivatedRoute);
+  private router = inject(Router);
+  private configurationWizardService = inject(ConfigurationWizardService);
+  private popoverService = inject(PopoverService);
+  dialog = inject(MatDialog);
+
  /** GL account form. */
  glAccountForm: UntypedFormGroup;
  /** Chart of accounts data. */
@@ -66,15 +74,7 @@ export class CreateGlAccountComponent implements OnInit, AfterViewInit {
   * @param {PopoverService} popoverService PopoverService.
   * @param {Matdialog} dialog Matdialog.
   */
-  constructor(
-    private formBuilder: UntypedFormBuilder,
-    private accountingService: AccountingService,
-    private route: ActivatedRoute,
-    private router: Router,
-    private configurationWizardService: ConfigurationWizardService,
-    private popoverService: PopoverService,
-    public dialog: MatDialog
-  ) {
+  constructor() {
    this.route.queryParamMap.subscribe((params) => {
      this.accountTypeId = Number(params.get('accountType'));
      this.parentId = Number(params.get('parent'));