Client-stepper: pre-fill existing KYC/address proofs in edit, fix identifier saves

Edit-mode now shows the previously selected KYC document type + uploaded file thumbnail
(loads from /clients/{id}/identifiers + /client_identifiers/{id}/documents). Same for
address proof on the India address step. Closes the gap where editing a client showed
an empty file picker even when proof had been uploaded on create.

Identifier-save hardened across all three callsites (create-client, edit-client,
identities-tab.createIdentifierWithDocs) - the KYC chip picker proofId is a CODE
string ('AADHAAR'), but backend ClientIdentifierRequest.documentTypeId is Long, which
Spring rejects with HttpMessageNotReadableException -> 400. resolveDocumentTypeId
helper looks up the code against /kyc/proof-types?type=id and substitutes the numeric
CodeValue id before posting. Skips silently for constitution-specific non-individual
docs that have no CodeValue mapping.

KYC payload normalises panNumber / enterprisePan / gstinNumber / cinNumber via
toUpperCase + whitespace strip so user-typed lowercase or trailing spaces don't trip
the backend regex (validation.msg.CLIENTKYC.panNumber.does.not.match.regexp).

State name match in client-address save now normalises both sides (lowercase, collapse
underscores + spaces) so legacy MADHYA_PRADESH resolves to 'Madhya Pradesh' returned
by api.postalpincode.in. Backed by tenant migration 0297.

Identities-tab resolver flattened - was returning identifiers before the per-row
forkJoin(getClientIdentificationDocuments) completed, so the view rendered empty
documents arrays. Now uses switchMap + forkJoin so the resolver awaits completion.

Also bundles concurrent work-in-progress on letter-mgmt, organization, users,
bank-calendar, shell, nominee/notes/identifier dialogs, and theming.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/app/clients/client-stepper/client-family-members-step/client-family-member-dialog/client-family-member-dialog.component.ts

@@ -259,7 +259,10 @@ export class ClientFamilyMemberDialogComponent implements OnInit {
       // non-individuals (companies / trusts) have no person-to-person relationship to model here.
       this.clientsService.searchByText(text, 0, 8, '', '', true, 'INDIVIDUAL').subscribe({
         next: (data: any) => {
-          this.searchResults = data?.content || [];
+          // Filter the host client out of results so they can't even appear as
+          // a candidate. The dialog also blocks selection defensively in case
+          // the host slips through (e.g. via a paged search).
+          this.searchResults = (data?.content || []).filter((c: any) => !this.isSelfClient(c?.id));
           this.searching = false;
           this.clientsService.enrichSearchResults(this.searchResults);
         },
@@ -278,6 +281,17 @@ export class ClientFamilyMemberDialogComponent implements OnInit {
    */
   linkedSelectError = '';
 
+  /**
+   * Self-check: prevent a client from being added as their own family member.
+   * The host client's id is passed in via dialog data — comparing as strings
+   * because the search API uses numbers but route params are strings.
+   */
+  isSelfClient(clientId: number | string): boolean {
+    const host = this.data?.hostClientId;
+    if (host == null || clientId == null) return false;
+    return String(host) === String(clientId);
+  }
+
   /**
    * True if the given client id is already linked as a family member of
    * this client. The member currently being edited is excluded so its own
@@ -298,6 +312,10 @@ export class ClientFamilyMemberDialogComponent implements OnInit {
 
   /** Select a client from search results and fetch full details */
   selectClient(client: any): void {
+    if (this.isSelfClient(client?.id)) {
+      this.linkedSelectError = `You can't add this client to their own family. Please pick a different person.`;
+      return;
+    }
     if (this.isClientAlreadyLinked(client?.id)) {
       this.linkedSelectError = `${client?.displayName || 'This client'} is already linked as a family member.`;
       return;

src/app/clients/client-stepper/client-family-members-step/client-family-members-step.component.scss

@@ -6,6 +6,12 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+@use '../stepper-readonly-overrides' as readonly;
+
+:host {
+  @include readonly.readonly-form-overrides;
+}
+
 .zoomable {
   cursor: zoom-in;
   transition:

src/app/clients/client-stepper/client-family-members-step/client-family-members-step.component.ts

@@ -135,7 +135,8 @@ export class ClientFamilyMembersStepComponent implements OnInit {
       data: {
         context: 'Add',
         options: this.clientTemplate.familyMemberOptions,
-        existingMembers: this.clientFamilyMembers
+        existingMembers: this.clientFamilyMembers,
+        hostClientId: this.clientId
       },
       width: '640px',
       maxWidth: '95vw',
@@ -154,7 +155,8 @@ export class ClientFamilyMembersStepComponent implements OnInit {
         context: 'View',
         member,
         options: this.clientTemplate.familyMemberOptions,
-        existingMembers: this.clientFamilyMembers
+        existingMembers: this.clientFamilyMembers,
+        hostClientId: this.clientId
       },
       width: '640px',
       maxWidth: '95vw',
@@ -168,7 +170,8 @@ export class ClientFamilyMembersStepComponent implements OnInit {
         context: 'Edit',
         member,
         options: this.clientTemplate.familyMemberOptions,
-        existingMembers: this.clientFamilyMembers
+        existingMembers: this.clientFamilyMembers,
+        hostClientId: this.clientId
       },
       width: '640px',
       maxWidth: '95vw',