build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated
This commit is contained in:
Ralph Hopman
2024-11-08 09:37:08 +01:00
committed by Adam Saghy
parent e910679673
commit 9034ce2847
204 changed files with 2184 additions and 1173 deletions
@@ -65,7 +65,7 @@
<mat-menu #centerMenu="matMenu">
<span *ngIf="!(centerViewData.status.value=='Active')">
<span *ngIf="!(centerViewData.status.value==='Active')">
<button mat-menu-item *mifosxHasPermission="'ACTIVATE_CENTER'" (click)="doAction('Activate')"><i
class="fa fa-check-sign"></i> {{"labels.buttons.Activate" | translate}} </button>
</span>
@@ -1,5 +1,5 @@
<div class="tab-container mat-typography">
<div *ngIf="centerViewData.status.value=='Closed'">
<div *ngIf="centerViewData.status.value==='Closed'">
<h3 class="closedCenter">{{"labels.heading.Center Closed" | translate}}</h3>
</div>
<h3>{{"labels.heading.Summary Details" | translate}}</h3>
@@ -83,19 +83,19 @@
<th mat-header-cell *matHeaderCellDef> {{"labels.inputs.Actions" | translate}} </th>
<td mat-cell *matCellDef="let element">
<ng-container *ngIf="element.status.active">
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '100'"
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 100"
(click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Deposit']">
<i class="fa fa-arrow-right" matTooltip="{{ 'tooltips.Deposit' | translate}}"></i>
</button>
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '300'"
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 300"
(click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Deposit']">
<i class="fa fa-arrow-right" matTooltip="{{ 'tooltips.Deposit' | translate}}"></i>
</button>
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '100'"
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 100"
(click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Withdrawal']">
<i class="fa fa-arrow-left" matTooltip="{{ 'tooltips.Withdraw' | translate}}"></i>
</button>
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '300'"
<button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 300"
(click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Withdrawal']">
<i class="fa fa-arrow-left" matTooltip="{{ 'tooltips.Withdraw' | translate}}"></i>
</button>
@@ -1,5 +1,5 @@
/** Angular Imports */
import { Component, OnInit, ViewChild } from '@angular/core';
import { Component } from '@angular/core';
import { ActivatedRoute } from '@angular/router';
/**
@@ -10,7 +10,7 @@ import { ActivatedRoute } from '@angular/router';
templateUrl: './general-tab.component.html',
styleUrls: ['./general-tab.component.scss']
})
export class GeneralTabComponent implements OnInit {
export class GeneralTabComponent {
/** Savings Account Table Columns */
savingsAccountColumns: string[] = ['Account No', 'Products', 'Balance', 'Actions'];
@@ -42,10 +42,6 @@ export class GeneralTabComponent implements OnInit {
});
}
ngOnInit() {
}
/**
* Stops the propagation to view pages.
* @param $event Mouse Event
@@ -33,7 +33,7 @@
<input matInput formControlName="externalId">
</mat-form-field>
<ng-container *ngIf="centerData.status.value=='Pending'" (click)="activatedOnDatePicker.open()">
<ng-container *ngIf="centerData.status.value==='Pending'" (click)="activatedOnDatePicker.open()">
<mat-form-field>
<mat-label>{{"labels.inputs.Activation Date" | translate}}</mat-label>
<input matInput [min]="minDate" [max]="maxDate" [matDatepicker]="activatedOnDatePicker" required