build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated
This commit is contained in:
Ralph Hopman
2024-11-08 09:37:08 +01:00
committed by Adam Saghy
parent e910679673
commit 9034ce2847
204 changed files with 2184 additions and 1173 deletions
@@ -1,5 +1,5 @@
/** Angular Imports */
import { Component, OnInit , TemplateRef, ElementRef , ViewChild, AfterViewInit} from '@angular/core';
import { Component, TemplateRef, ElementRef , ViewChild, AfterViewInit} from '@angular/core';
import { ActivatedRoute, Router, NavigationEnd, Data } from '@angular/router';
/** rxjs Imports */
@@ -50,7 +50,7 @@ const routeAddBreadcrumbLink = 'addBreadcrumbLink';
templateUrl: './breadcrumb.component.html',
styleUrls: ['./breadcrumb.component.scss']
})
export class BreadcrumbComponent implements OnInit, AfterViewInit {
export class BreadcrumbComponent implements AfterViewInit {
/** Array of breadcrumbs. */
breadcrumbs: Breadcrumb[];
@@ -74,9 +74,6 @@ export class BreadcrumbComponent implements OnInit, AfterViewInit {
this.generateBreadcrumbs();
}
ngOnInit() {
}
/**
* Generates the array of breadcrumbs for the visited route.
*/
@@ -1,5 +1,5 @@
/** Angular Imports */
import { Component, OnInit } from '@angular/core';
import { Component } from '@angular/core';
/**
* Content component.
@@ -9,11 +9,8 @@ import { Component, OnInit } from '@angular/core';
templateUrl: './content.component.html',
styleUrls: ['./content.component.scss']
})
export class ContentComponent implements OnInit {
export class ContentComponent {
constructor() { }
ngOnInit() {
}
}
+1 -1
View File
@@ -11,7 +11,7 @@
}"
[attr.role]="(isHandset$ | async) ? 'dialog' : 'navigation'"
[mode]="(isHandset$ | async) ? 'over' : 'side'"
[opened]="!(isHandset$ | async)">
[opened]="(isHandset$ | async) === false">
<mifosx-sidenav [sidenavCollapsed]="sidenavCollapsed"></mifosx-sidenav>