build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated
This commit is contained in:
Ralph Hopman
2024-11-08 09:37:08 +01:00
committed by Adam Saghy
parent e910679673
commit 9034ce2847
204 changed files with 2184 additions and 1173 deletions
@@ -85,7 +85,7 @@
<mifosx-fixed-deposit-account-preview-step
[fixedDepositsAccountTemplate]="fixedDepositsAccountTemplate"
[fixedDepositsAccountProductTemplate]="fixedDepositsAccountProductTemplate"
[fixedDepositAccountData]="fixedDepositAccount" (submit)="submit()">
[fixedDepositAccountData]="fixedDepositAccount" (submitEvent)="submit()">
</mifosx-fixed-deposit-account-preview-step>
</mat-step>
@@ -85,7 +85,7 @@
<mifosx-fixed-deposit-account-preview-step
[fixedDepositsAccountTemplate]="fixedDepositsAccountAndTemplate"
[fixedDepositsAccountProductTemplate]="fixedDepositsAccountProductTemplate"
[fixedDepositAccountData]="fixedDepositAccount" (submit)="submit()">
[fixedDepositAccountData]="fixedDepositAccount" (submitEvent)="submit()">
</mifosx-fixed-deposit-account-preview-step>
</mat-step>
@@ -352,7 +352,7 @@
<button mat-raised-button [routerLink]="['../..']">
{{"labels.buttons.Cancel" | translate }}
</button>
<button mat-raised-button color="primary" (click)="submit.emit()">
<button mat-raised-button color="primary" (click)="submitEvent.emit()">
{{"labels.buttons.Submit" | translate }}
</button>
</div>
@@ -40,7 +40,7 @@ export class FixedDepositAccountPreviewStepComponent implements OnChanges {
expandChartSlabIndex: number;
/** Form submission event */
@Output() submit = new EventEmitter();
@Output() submitEvent = new EventEmitter();
constructor() { }
@@ -1,4 +1,4 @@
import { Component, OnInit } from '@angular/core';
import { Component } from '@angular/core';
import { ActivatedRoute, Router } from '@angular/router';
import { Currency } from 'app/shared/models/general.model';
@@ -7,7 +7,7 @@ import { Currency } from 'app/shared/models/general.model';
templateUrl: './general-tab.component.html',
styleUrls: ['./general-tab.component.scss']
})
export class GeneralTabComponent implements OnInit {
export class GeneralTabComponent {
fixedDepositsAccountData: any;
entityType: string;
@@ -28,7 +28,4 @@ export class GeneralTabComponent implements OnInit {
}
}
ngOnInit(): void {
}
}