build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated
This commit is contained in:
Ralph Hopman
2024-11-08 09:37:08 +01:00
committed by Adam Saghy
parent e910679673
commit 9034ce2847
204 changed files with 2184 additions and 1173 deletions
@@ -1,5 +1,5 @@
/** Angular Imports */
import { Component, OnInit, Input, OnDestroy } from '@angular/core';
import { Component, OnInit, Input } from '@angular/core';
import { UntypedFormGroup, UntypedFormBuilder, Validators, UntypedFormControl } from '@angular/forms';
import { ActivatedRoute, Router } from '@angular/router';
@@ -17,7 +17,7 @@ import { Currency } from 'app/shared/models/general.model';
templateUrl: './make-repayment.component.html',
styleUrls: ['./make-repayment.component.scss']
})
export class MakeRepaymentComponent implements OnInit, OnDestroy {
export class MakeRepaymentComponent implements OnInit {
@Input() dataObject: any;
/** Loan Id */
@@ -63,10 +63,6 @@ export class MakeRepaymentComponent implements OnInit, OnDestroy {
}
}
ngOnDestroy(): void {
}
/**
* Creates the create close form.
*/
@@ -1,5 +1,5 @@
/** Angular Imports */
import { Component, OnInit, Input, OnDestroy } from '@angular/core';
import { Component, OnInit, Input } from '@angular/core';
import { UntypedFormGroup, UntypedFormBuilder, Validators, UntypedFormControl } from '@angular/forms';
import { ActivatedRoute, Router } from '@angular/router';
@@ -18,7 +18,7 @@ import { Currency } from 'app/shared/models/general.model';
templateUrl: './prepay-loan.component.html',
styleUrls: ['./prepay-loan.component.scss']
})
export class PrepayLoanComponent implements OnInit, OnDestroy {
export class PrepayLoanComponent implements OnInit {
@Input() dataObject: any;
/** Loan Id */
@@ -71,9 +71,6 @@ export class PrepayLoanComponent implements OnInit, OnDestroy {
}
}
ngOnDestroy(): void {
}
/**
* Creates the prepay loan form.
*/
@@ -161,7 +161,7 @@
<fa-icon icon="eye" class="m-r-10"></fa-icon>
</button>
<button mat-raised-button class="account-action-button" color="primary"
*ngIf="guarantor.status && guarantor.guarantorType.id == 3 && guarantor.id">
*ngIf="guarantor.status && guarantor.guarantorType.id === 3 && guarantor.id">
<fa-icon icon="edit" class="m-r-10"></fa-icon>
</button>
<span *ngIf="guarantor.status">