build: Replace Codelyzer and TSLint with Angular ESLint
Migrate from the deprecated TSLint to Angluar ESLint. Also fix current linting issues in the code, in particular: - Use strict equals operators (=== and !==) - Remove empty lifecycle methods (mostly ngOnInit) - Output bindings including aliases should not be named as standard dom events (submit) - Async pipe results should not be negated
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { Component, Input, OnInit } from '@angular/core';
|
||||
import { Component, Input } from '@angular/core';
|
||||
import { GLAccount } from 'app/shared/models/general.model';
|
||||
|
||||
@Component({
|
||||
@@ -6,7 +6,7 @@ import { GLAccount } from 'app/shared/models/general.model';
|
||||
templateUrl: './gl-account-display.component.html',
|
||||
styleUrls: ['./gl-account-display.component.scss']
|
||||
})
|
||||
export class GlAccountDisplayComponent implements OnInit {
|
||||
export class GlAccountDisplayComponent {
|
||||
|
||||
@Input() glAccount: GLAccount | null = null;
|
||||
@Input() accountTitle: string | null = null;
|
||||
@@ -15,9 +15,6 @@ export class GlAccountDisplayComponent implements OnInit {
|
||||
|
||||
constructor() { }
|
||||
|
||||
ngOnInit(): void {
|
||||
}
|
||||
|
||||
glAccountValue(): string {
|
||||
if (this.glAccount) {
|
||||
return '(' + this.glAccount.glCode + ') ' + (this.glAccount.nameDecorated ? this.glAccount.nameDecorated : this.glAccount.name);
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/** Angular Imports */
|
||||
import { Component, OnInit, Inject } from '@angular/core';
|
||||
import { Component, Inject } from '@angular/core';
|
||||
import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
|
||||
|
||||
/**
|
||||
@@ -10,7 +10,7 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
|
||||
templateUrl: './view-journal-entry.component.html',
|
||||
styleUrls: ['./view-journal-entry.component.scss']
|
||||
})
|
||||
export class ViewJournalEntryComponent implements OnInit {
|
||||
export class ViewJournalEntryComponent {
|
||||
|
||||
existsPaymentDetails = false;
|
||||
/**
|
||||
@@ -23,7 +23,4 @@ export class ViewJournalEntryComponent implements OnInit {
|
||||
this.existsPaymentDetails = (data.journalEntry.transactionDetails != null && data.journalEntry.transactionDetails.paymentDetails != null);
|
||||
}
|
||||
|
||||
ngOnInit() {
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
+2
-5
@@ -1,4 +1,4 @@
|
||||
import { Component, Input, OnInit } from '@angular/core';
|
||||
import { Component, Input } from '@angular/core';
|
||||
import { Accounting } from 'app/core/utils/accounting';
|
||||
import { OptionData } from 'app/shared/models/option-data.model';
|
||||
|
||||
@@ -7,16 +7,13 @@ import { OptionData } from 'app/shared/models/option-data.model';
|
||||
templateUrl: './view-savings-accounting-details.component.html',
|
||||
styleUrls: ['./view-savings-accounting-details.component.scss']
|
||||
})
|
||||
export class ViewSavingsAccountingDetailsComponent implements OnInit {
|
||||
export class ViewSavingsAccountingDetailsComponent {
|
||||
|
||||
@Input() accountingRule: OptionData;
|
||||
@Input() accountingMappings: any[] = [];
|
||||
|
||||
constructor(private accounting: Accounting) { }
|
||||
|
||||
ngOnInit(): void {
|
||||
}
|
||||
|
||||
isCashOrAccrualAccounting(): boolean {
|
||||
if (this.accountingRule) {
|
||||
return this.accounting.isCashOrAccrualAccounting(this.accountingRule);
|
||||
|
||||
Reference in New Issue
Block a user