build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated

src/app/shares/create-shares-account/create-shares-account.component.html

@@ -64,7 +64,7 @@
         [sharesAccountTemplate]="sharesAccountTemplate"
         [sharesAccountTermsForm]="sharesAccountTermsForm"
         [sharesAccount]="sharesAccount"
-        (submit)="submit()"
+        (submitEvent)="submit()"
       >
       </mifosx-shares-account-preview-step>
 

src/app/shares/edit-shares-account/edit-shares-account.component.html

@@ -67,7 +67,7 @@
         [sharesAccountTemplate]="sharesAccountAndTemplate"
         [sharesAccountTermsForm]="sharesAccountTermsForm"
         [sharesAccount]="sharesAccount"
-        (submit)="submit()"
+        (submitEvent)="submit()"
       >
       </mifosx-shares-account-preview-step>
 

src/app/shares/shares-account-stepper/shares-account-preview-step/shares-account-preview-step.component.html

@@ -126,7 +126,7 @@
   <button mat-raised-button [routerLink]="['../']">
     {{'labels.buttons.Cancel' | translate}}
   </button>
-  <button mat-raised-button color="primary" (click)="submit.emit()">
+  <button mat-raised-button color="primary" (click)="submitEvent.emit()">
     {{'labels.buttons.Submit' | translate}}
   </button>
 </div>

src/app/shares/shares-account-stepper/shares-account-preview-step/shares-account-preview-step.component.ts

@@ -24,7 +24,7 @@ export class SharesAccountPreviewStepComponent {
   chargesDisplayedColumns: string[] = ['name', 'chargeCalculationType', 'amount', 'chargeTimeType'];
 
   /** Form submission event */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   constructor() { }
 

src/app/shares/shares-account-view/general-tab/general-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 @Component({
@@ -6,7 +6,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './general-tab.component.html',
   styleUrls: ['./general-tab.component.scss']
 })
-export class GeneralTabComponent implements OnInit {
+export class GeneralTabComponent {
   /** Shares Account Data */
   sharesAccountData: any;
 
@@ -20,7 +20,4 @@ export class GeneralTabComponent implements OnInit {
     });
   }
 
-  ngOnInit(): void {
-  }
-
 }