build: Replace Codelyzer and TSLint with Angular ESLint

Migrate from the deprecated TSLint to Angluar ESLint. Also fix current
linting issues in the code, in particular:

- Use strict equals operators (=== and !==)
- Remove empty lifecycle methods (mostly ngOnInit)
- Output bindings including aliases should not be named as standard dom
  events (submit)
- Async pipe results should not be negated

.eslintrc.json

@@ -0,0 +1,51 @@
+{
+  "root": true,
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts"
+      ],
+      "parserOptions": {
+        "project": [
+          "tsconfig.json",
+          "e2e/tsconfig.json"
+        ],
+        "createDefaultProgram": true
+      },
+      "extends": [
+        "plugin:@angular-eslint/recommended",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
+      "rules": {
+        "@angular-eslint/component-selector": [
+          "error",
+          {
+            "prefix": "mifosx",
+            "style": "kebab-case",
+            "type": "element"
+          }
+        ],
+        "@angular-eslint/directive-selector": [
+          "error",
+          {
+            "prefix": "mifosx",
+            "style": "camelCase",
+            "type": "attribute"
+          }
+        ]
+      }
+    },
+    {
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended"
+      ],
+      "rules": {}
+    }
+  ]
+}

.github/workflows/build.yml

@@ -34,8 +34,8 @@ jobs:
       - name: Npm install
         run: npm install
 
-      - name: Run tslint
-        run : npx tslint src/**/*.ts
+      - name: Run eslint
+        run : npx ng lint
 
       - name: Run build
         run : npm run build:prod

angular.json

@@ -135,15 +135,11 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "src/tsconfig.app.json",
-              "src/tsconfig.spec.json",
-              "cypress/tsconfig.json"
-            ],
-            "exclude": [
-              "**/node_modules/**"
+            "lintFilePatterns": [
+              "src/**/*.ts",
+              "src/**/*.html"
             ]
           }
         },
@@ -198,13 +194,11 @@
           }
         },
         "lint": {
-          "builder": "@angular-devkit/build-angular:tslint",
+          "builder": "@angular-eslint/builder:lint",
           "options": {
-            "tsConfig": [
-              "e2e/cypress/tsconfig.json"
-            ],
-            "exclude": [
-              "**/node_modules/**"
+            "lintFilePatterns": [
+              "e2e/**/*.ts",
+              "e2e/**/*.html"
             ]
           }
         },
@@ -232,6 +226,9 @@
     }
   },
   "cli": {
-    "analytics": false
+    "analytics": false,
+    "schematicCollections": [
+      "@angular-eslint/schematics"
+    ]
   }
 }

docs/coding-guides/typescript.md

@@ -54,8 +54,7 @@ To manage type definitions, use standard `npm install|update|remove` commands.
 
 ## Enforcement
 
-Coding rules are enforced in this project via [TSLint](https://github.com/palantir/tslint).
-Angular-specific rules are also enforced via the [Codelyzer](https://github.com/mgechev/codelyzer) rule extensions.
+Coding rules are enforced in this project via [Angular ESLint](https://github.com/angular-eslint/angular-eslint).
 
 ## Learn more
 

e2e/.eslintrc.json

@@ -0,0 +1,43 @@
+{
+  "extends": "../.eslintrc.json",
+  "ignorePatterns": [
+    "!**/*"
+  ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts"
+      ],
+      "parserOptions": {
+        "project": [
+          "e2e/tsconfig.app.json",
+          "e2e/tsconfig.spec.json",
+          "e2e/e2e/tsconfig.json"
+        ],
+        "createDefaultProgram": true
+      },
+      "rules": {
+        "@angular-eslint/directive-selector": [
+          "error",
+          {
+            "type": "attribute",
+            "style": "camelCase"
+          }
+        ],
+        "@angular-eslint/component-selector": [
+          "error",
+          {
+            "type": "element",
+            "style": "kebab-case"
+          }
+        ]
+      }
+    },
+    {
+      "files": [
+        "*.html"
+      ],
+      "rules": {}
+    }
+  ]
+}

package.json

@@ -70,6 +70,11 @@
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "14.2.12",
+    "@angular-eslint/builder": "14.4.0",
+    "@angular-eslint/eslint-plugin": "14.4.0",
+    "@angular-eslint/eslint-plugin-template": "14.4.0",
+    "@angular-eslint/schematics": "14.4.0",
+    "@angular-eslint/template-parser": "14.4.0",
     "@angular/cli": "14.2.12",
     "@angular/compiler-cli": "14.3.0",
     "@angular/language-service": "14.3.0",
@@ -85,8 +90,10 @@
     "@types/lodash": "4.14.132",
     "@types/node": "12.11.1",
     "@types/vkbeautify": "^0.99.2",
-    "codelyzer": "6.0.0",
+    "@typescript-eslint/eslint-plugin": "5.43.0",
+    "@typescript-eslint/parser": "5.43.0",
     "cypress": "^10.7.0",
+    "eslint": "^8.28.0",
     "git-describe": "^4.1.1",
     "hads": "^3.0.3",
     "htmlhint": "1.1.4",
@@ -110,7 +117,6 @@
     "stylelint-scss": "3.6.1",
     "tailwindcss": "^3.3.3",
     "ts-node": "8.2.0",
-    "tslint": "~6.1.0",
     "typescript": "4.6.4"
   },
   "repository": {
@@ -124,4 +130,4 @@
     "node": ">= 16.15.1",
     "npm": ">= 8.11.0"
   }
-}
+}

src/app/account-transfers/list-standing-instructions/list-standing-instructions.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { MatPaginator } from '@angular/material/paginator';
 import { MatTableDataSource, MatTable } from '@angular/material/table';
@@ -21,7 +21,7 @@ import { SettingsService } from 'app/settings/settings.service';
   templateUrl: './list-standing-instructions.component.html',
   styleUrls: ['./list-standing-instructions.component.scss']
 })
-export class ListStandingInstructionsComponent implements OnInit {
+export class ListStandingInstructionsComponent {
 
   /** Recurring Deposits Data */
   standingIntructionsTemplateData: any;
@@ -80,9 +80,6 @@ export class ListStandingInstructionsComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   setParams() {
     this.accountType = this.route.snapshot.queryParams['accountType'];
     switch (this.accountType) {

src/app/accounting/accounting-rules/view-rule/view-rule.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -17,7 +17,7 @@ import { DeleteDialogComponent } from '../../../shared/delete-dialog/delete-dial
   templateUrl: './view-rule.component.html',
   styleUrls: ['./view-rule.component.scss']
 })
-export class ViewRuleComponent implements OnInit {
+export class ViewRuleComponent {
 
   /** Accounting rule. */
   accountingRule: any;
@@ -38,9 +38,6 @@ export class ViewRuleComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the accounting rule and redirects to accounting rules.
    */

src/app/accounting/accounting.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { AfterViewInit, Component, ElementRef, OnInit, TemplateRef, ViewChild } from '@angular/core';
+import { AfterViewInit, Component, ElementRef, TemplateRef, ViewChild } from '@angular/core';
 import { Router } from '@angular/router';
 
 /** Custom Services */
@@ -14,7 +14,7 @@ import { PopoverService } from '../configuration-wizard/popover/popover.service'
   templateUrl: './accounting.component.html',
   styleUrls: ['./accounting.component.scss']
 })
-export class AccountingComponent implements OnInit, AfterViewInit {
+export class AccountingComponent implements AfterViewInit {
 
   /* Reference of Chart of Accounts */
   @ViewChild('chartofAccounts') chartofAccounts: ElementRef<any>;
@@ -48,9 +48,6 @@ export class AccountingComponent implements OnInit, AfterViewInit {
               private configurationWizardService: ConfigurationWizardService,
               private popoverService: PopoverService) { }
 
-  ngOnInit() {
-  }
-
   /**
    * Popover function
    * @param template TemplateRef<any>.

src/app/accounting/chart-of-accounts/view-gl-account/view-gl-account.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -18,7 +18,7 @@ import { Location } from '@angular/common';
   templateUrl: './view-gl-account.component.html',
   styleUrls: ['./view-gl-account.component.scss']
 })
-export class ViewGlAccountComponent implements OnInit {
+export class ViewGlAccountComponent {
 
   /** GL Account. */
   glAccount: any;
@@ -40,9 +40,6 @@ export class ViewGlAccountComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the gl account and redirects to chart of accounts.
    */

src/app/accounting/closing-entries/view-closure/view-closure.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -17,7 +17,7 @@ import { DeleteDialogComponent } from '../../../shared/delete-dialog/delete-dial
   templateUrl: './view-closure.component.html',
   styleUrls: ['./view-closure.component.scss']
 })
-export class ViewClosureComponent implements OnInit {
+export class ViewClosureComponent {
 
   /** GL Account closure. */
   glAccountClosure: any;
@@ -38,9 +38,6 @@ export class ViewClosureComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the gl account closure and redirects to closing entries.
    */

src/app/accounting/financial-activity-mappings/view-financial-activity-mapping/view-financial-activity-mapping.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -18,7 +18,7 @@ import { Location } from '@angular/common';
   templateUrl: './view-financial-activity-mapping.component.html',
   styleUrls: ['./view-financial-activity-mapping.component.scss']
 })
-export class ViewFinancialActivityMappingComponent implements OnInit {
+export class ViewFinancialActivityMappingComponent {
 
   /** Financial activity account ID. */
   financialActivityAccountId: any;
@@ -43,9 +43,6 @@ export class ViewFinancialActivityMappingComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the financial activity account and redirects to financial activity mappings.
    */

src/app/accounting/revert-transaction/revert-transaction.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 import { UntypedFormControl } from '@angular/forms';
 
@@ -11,7 +11,7 @@ import { UntypedFormControl } from '@angular/forms';
   templateUrl: './revert-transaction.component.html',
   styleUrls: ['./revert-transaction.component.scss']
 })
-export class RevertTransactionComponent implements OnInit {
+export class RevertTransactionComponent {
 
   /** Comments input form control. */
   comments = new UntypedFormControl('');
@@ -23,7 +23,4 @@ export class RevertTransactionComponent implements OnInit {
   constructor(public dialogRef: MatDialogRef<RevertTransactionComponent>,
               @Inject(MAT_DIALOG_DATA) public data: any) { }
 
-  ngOnInit() {
-  }
-
 }

src/app/centers/centers-view/centers-view.component.html

@@ -65,7 +65,7 @@
 
       <mat-menu #centerMenu="matMenu">
 
-        <span *ngIf="!(centerViewData.status.value=='Active')">
+        <span *ngIf="!(centerViewData.status.value==='Active')">
           <button mat-menu-item *mifosxHasPermission="'ACTIVATE_CENTER'" (click)="doAction('Activate')"><i
               class="fa fa-check-sign"></i> {{"labels.buttons.Activate" | translate}} </button>
         </span>

src/app/centers/centers-view/general-tab/general-tab.component.html

@@ -1,5 +1,5 @@
 <div class="tab-container mat-typography">
-  <div *ngIf="centerViewData.status.value=='Closed'">
+  <div *ngIf="centerViewData.status.value==='Closed'">
     <h3 class="closedCenter">{{"labels.heading.Center Closed" | translate}}</h3>
   </div>
   <h3>{{"labels.heading.Summary Details" | translate}}</h3>
@@ -83,19 +83,19 @@
           <th mat-header-cell *matHeaderCellDef> {{"labels.inputs.Actions" | translate}} </th>
           <td mat-cell *matCellDef="let element">
             <ng-container *ngIf="element.status.active">
-              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '100'"
+              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 100"
                 (click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Deposit']">
                 <i class="fa fa-arrow-right" matTooltip="{{ 'tooltips.Deposit' | translate}}"></i>
               </button>
-              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '300'"
+              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 300"
                 (click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Deposit']">
                 <i class="fa fa-arrow-right" matTooltip="{{ 'tooltips.Deposit' | translate}}"></i>
               </button>
-              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '100'"
+              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 100"
                 (click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Withdrawal']">
                 <i class="fa fa-arrow-left" matTooltip="{{ 'tooltips.Withdraw' | translate}}"></i>
               </button>
-              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id == '300'"
+              <button class="account-action-button" mat-raised-button color="primary" *ngIf="element.depositType.id === 300"
                 (click)="routeEdit($event)" [routerLink]="['../','savings-accounts', element.id, 'actions', 'Withdrawal']">
                 <i class="fa fa-arrow-left" matTooltip="{{ 'tooltips.Withdraw' | translate}}"></i>
               </button>

src/app/centers/centers-view/general-tab/general-tab.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /**
@@ -10,7 +10,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './general-tab.component.html',
   styleUrls: ['./general-tab.component.scss']
 })
-export class GeneralTabComponent implements OnInit {
+export class GeneralTabComponent {
 
   /** Savings Account Table Columns */
   savingsAccountColumns: string[] = ['Account No', 'Products', 'Balance', 'Actions'];
@@ -42,10 +42,6 @@ export class GeneralTabComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
-
   /**
    * Stops the propagation to view pages.
    * @param $event Mouse Event

src/app/centers/edit-center/edit-center.component.html

@@ -33,7 +33,7 @@
             <input matInput formControlName="externalId">
           </mat-form-field>
 
-          <ng-container *ngIf="centerData.status.value=='Pending'" (click)="activatedOnDatePicker.open()">
+          <ng-container *ngIf="centerData.status.value==='Pending'" (click)="activatedOnDatePicker.open()">
             <mat-form-field>
               <mat-label>{{"labels.inputs.Activation Date" | translate}}</mat-label>
               <input matInput [min]="minDate" [max]="maxDate" [matDatepicker]="activatedOnDatePicker" required

src/app/clients/client-stepper/client-preview-step/client-preview-step.component.html

@@ -219,7 +219,7 @@
   <button mat-raised-button [routerLink]="['../']">
     {{"labels.buttons.Cancel" | translate}}
   </button>
-  <button mat-raised-button color="primary" (click)="submit.emit()">
+  <button mat-raised-button color="primary" (click)="submitEvent.emit()">
     {{"labels.buttons.Submit" | translate}}
   </button>
 </div>

src/app/clients/client-stepper/client-preview-step/client-preview-step.component.ts

@@ -19,7 +19,7 @@ export class ClientPreviewStepComponent {
   @Input() client: any;
 
   /** Form submission event */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   constructor() { }
 

src/app/clients/clients-view/charges/view-charge/view-charge.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { ClientsService } from 'app/clients/clients.service';
 
@@ -11,7 +11,7 @@ import { ClientsService } from 'app/clients/clients.service';
   templateUrl: './view-charge.component.html',
   styleUrls: ['./view-charge.component.scss']
 })
-export class ViewChargeComponent implements OnInit {
+export class ViewChargeComponent {
 
   /** Charge Data. */
   chargeData: any;
@@ -31,10 +31,6 @@ export class ViewChargeComponent implements OnInit {
     });
    }
 
-  ngOnInit() {
-
-  }
-
   /**
    * Waive Charge.
    */

src/app/clients/clients-view/clients-view.component.html

@@ -192,7 +192,7 @@
         <button mat-menu-item (click)="doAction('Client Screen Reports')"> {{"labels.buttons.Client Screen Reports" | translate}} </button>
         <button mat-menu-item (click)="doAction('Create Standing Instructions')"
           *mifosxHasPermission="'CREATE_STANDINGINSTRUCTION'"> {{"labels.buttons.Create Standing Instructions" | translate}}</button>
-        <span *ngIf="clientViewData.status.value!='Transfer on hold'">
+        <span *ngIf="clientViewData.status.value!=='Transfer on hold'">
           <button mat-menu-item (click)="doAction('View Standing Instructions')"
             *mifosxHasPermission="'READ_STANDINGINSTRUCTION'"> {{"labels.buttons.View Standing Instructions" | translate}}</button>
         </span>

src/app/clients/clients-view/datatable-tab/datatable-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 @Component({
@@ -6,7 +6,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './datatable-tab.component.html',
   styleUrls: ['./datatable-tab.component.scss']
 })
-export class DatatableTabComponent implements OnInit {
+export class DatatableTabComponent {
   entityId: string;
   entityDatatable: any;
   multiRowDatatableFlag: boolean;
@@ -20,7 +20,4 @@ export class DatatableTabComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/clients/clients-view/documents-tab/documents-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -10,7 +10,7 @@ import { ClientsService } from '../../clients.service';
   templateUrl: './documents-tab.component.html',
   styleUrls: ['./documents-tab.component.scss']
 })
-export class DocumentsTabComponent implements OnInit {
+export class DocumentsTabComponent {
   entityDocuments: any;
   entityId: string;
   entityType = 'clients';
@@ -24,9 +24,6 @@ export class DocumentsTabComponent implements OnInit {
     this.entityId = this.route.parent.snapshot.paramMap.get('clientId');
   }
 
-  ngOnInit() {
-  }
-
   downloadDocument(documentId: string) {
     this.clientsService.downloadClientDocument(this.entityId, documentId).subscribe(res => {
       const url = window.URL.createObjectURL(res);

src/app/clients/clients-view/notes-tab/notes-tab.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /** Custom Components */
@@ -16,7 +16,7 @@ import { AuthenticationService } from 'app/core/authentication/authentication.se
   templateUrl: './notes-tab.component.html',
   styleUrls: ['./notes-tab.component.scss']
 })
-export class NotesTabComponent implements OnInit {
+export class NotesTabComponent {
 
   /** Client ID */
   entityId: string;
@@ -41,8 +41,6 @@ export class NotesTabComponent implements OnInit {
     });
   }
 
-  ngOnInit() { }
-
   /**
    * Edits a client note.
    * @param {string} noteId Note Id

src/app/clients/create-client/create-client.component.html

@@ -63,7 +63,7 @@
       <mifosx-client-preview-step
         [clientTemplate]="clientTemplate"
         [clientAddressFieldConfig]="clientAddressFieldConfig"
-        [client]="client" (submit)="submit()"
+        [client]="client" (submitEvent)="submit()"
       >
       </mifosx-client-preview-step>
 

src/app/collaterals/view-collateral/view-collateral.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { CollateralsService } from '../collaterals.service';
 import { MatDialog } from '@angular/material/dialog';
@@ -12,7 +12,7 @@ import { DeleteDialogComponent } from '../../shared/delete-dialog/delete-dialog.
   templateUrl: './view-collateral.component.html',
   styleUrls: ['./view-collateral.component.scss']
 })
-export class ViewCollateralComponent implements OnInit {
+export class ViewCollateralComponent {
 
   clientCollateralData: any;
 
@@ -29,9 +29,6 @@ export class ViewCollateralComponent implements OnInit {
     });
   }
 
-  ngOnInit(): void {
-  }
-
   /**
    * Deletes the Collateral and redirects to CLients Page.
    */

src/app/configuration-wizard/completion-dialog/completion-dialog.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 
 /**
@@ -10,12 +10,9 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
   templateUrl: './completion-dialog.component.html',
   styleUrls: ['./completion-dialog.component.scss']
 })
-export class CompletionDialogComponent implements OnInit {
+export class CompletionDialogComponent {
 
   constructor(public dialogRef: MatDialogRef<CompletionDialogComponent>,
   @Inject(MAT_DIALOG_DATA) public data: any) { }
 
-  ngOnInit() {
-  }
-
 }

src/app/configuration-wizard/configuration-wizard.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 
 /**
@@ -10,7 +10,7 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
   templateUrl: './configuration-wizard.component.html',
   styleUrls: ['./configuration-wizard.component.scss']
 })
-export class ConfigurationWizardComponent implements OnInit {
+export class ConfigurationWizardComponent {
 
   show: number;
   /**
@@ -19,7 +19,4 @@ export class ConfigurationWizardComponent implements OnInit {
   constructor(public dialogRef: MatDialogRef<ConfigurationWizardComponent>,
   @Inject(MAT_DIALOG_DATA) public data: any) { }
 
-  ngOnInit() {
-  }
-
 }

src/app/configuration-wizard/continue-setup-dialog/continue-setup-dialog.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 
 /**
@@ -10,7 +10,7 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
   templateUrl: './continue-setup-dialog.component.html',
   styleUrls: ['./continue-setup-dialog.component.scss']
 })
-export class ContinueSetupDialogComponent implements OnInit {
+export class ContinueSetupDialogComponent {
 
   /* Current Step Name*/
   stepName: number;
@@ -23,7 +23,4 @@ export class ContinueSetupDialogComponent implements OnInit {
     this.stepName = data.stepName;
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/configuration-wizard/next-step-dialog/next-step-dialog.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 
 /**
@@ -10,7 +10,7 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
   templateUrl: './next-step-dialog.component.html',
   styleUrls: ['./next-step-dialog.component.scss']
 })
-export class NextStepDialogComponent implements OnInit {
+export class NextStepDialogComponent {
 
   /* Step Percentage */
   stepPercentage: number;
@@ -29,7 +29,4 @@ export class NextStepDialogComponent implements OnInit {
       this.previousStepName = data.previousStepName;
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/core/shell/breadcrumb/breadcrumb.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit , TemplateRef, ElementRef , ViewChild, AfterViewInit} from '@angular/core';
+import { Component, TemplateRef, ElementRef , ViewChild, AfterViewInit} from '@angular/core';
 import { ActivatedRoute, Router, NavigationEnd, Data } from '@angular/router';
 
 /** rxjs Imports */
@@ -50,7 +50,7 @@ const routeAddBreadcrumbLink = 'addBreadcrumbLink';
   templateUrl: './breadcrumb.component.html',
   styleUrls: ['./breadcrumb.component.scss']
 })
-export class BreadcrumbComponent implements OnInit, AfterViewInit {
+export class BreadcrumbComponent implements AfterViewInit {
 
   /** Array of breadcrumbs. */
   breadcrumbs: Breadcrumb[];
@@ -74,9 +74,6 @@ export class BreadcrumbComponent implements OnInit, AfterViewInit {
     this.generateBreadcrumbs();
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Generates the array of breadcrumbs for the visited route.
    */

src/app/core/shell/content/content.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 
 /**
  * Content component.
@@ -9,11 +9,8 @@ import { Component, OnInit } from '@angular/core';
   templateUrl: './content.component.html',
   styleUrls: ['./content.component.scss']
 })
-export class ContentComponent implements OnInit {
+export class ContentComponent {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/core/shell/shell.component.html

@@ -11,7 +11,7 @@
     }"
     [attr.role]="(isHandset$ | async) ? 'dialog' : 'navigation'"
     [mode]="(isHandset$ | async) ? 'over' : 'side'"
-    [opened]="!(isHandset$ | async)">
+    [opened]="(isHandset$ | async) === false">
 
     <mifosx-sidenav [sidenavCollapsed]="sidenavCollapsed"></mifosx-sidenav>
 

src/app/deposits/fixed-deposits/create-fixed-deposit-account/create-fixed-deposit-account.component.html

@@ -85,7 +85,7 @@
       <mifosx-fixed-deposit-account-preview-step
         [fixedDepositsAccountTemplate]="fixedDepositsAccountTemplate"
         [fixedDepositsAccountProductTemplate]="fixedDepositsAccountProductTemplate"
-        [fixedDepositAccountData]="fixedDepositAccount" (submit)="submit()">
+        [fixedDepositAccountData]="fixedDepositAccount" (submitEvent)="submit()">
       </mifosx-fixed-deposit-account-preview-step>
 
     </mat-step>

src/app/deposits/fixed-deposits/edit-fixed-deposit-account/edit-fixed-deposit-account.component.html

@@ -85,7 +85,7 @@
       <mifosx-fixed-deposit-account-preview-step
         [fixedDepositsAccountTemplate]="fixedDepositsAccountAndTemplate"
         [fixedDepositsAccountProductTemplate]="fixedDepositsAccountProductTemplate"
-        [fixedDepositAccountData]="fixedDepositAccount" (submit)="submit()">
+        [fixedDepositAccountData]="fixedDepositAccount" (submitEvent)="submit()">
       </mifosx-fixed-deposit-account-preview-step>
 
     </mat-step>

src/app/deposits/fixed-deposits/fixed-deposit-account-stepper/fixed-deposit-account-preview-step/fixed-deposit-account-preview-step.component.html

@@ -352,7 +352,7 @@
   <button mat-raised-button [routerLink]="['../..']">
     {{"labels.buttons.Cancel" | translate }}
   </button>
-  <button mat-raised-button color="primary" (click)="submit.emit()">
+  <button mat-raised-button color="primary" (click)="submitEvent.emit()">
     {{"labels.buttons.Submit" | translate }}
   </button>
 </div>

src/app/deposits/fixed-deposits/fixed-deposit-account-stepper/fixed-deposit-account-preview-step/fixed-deposit-account-preview-step.component.ts

@@ -40,7 +40,7 @@ export class FixedDepositAccountPreviewStepComponent implements OnChanges {
   expandChartSlabIndex: number;
 
   /** Form submission event */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   constructor() { }
 

src/app/deposits/fixed-deposits/fixed-deposit-account-view/general-tab/general-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { Currency } from 'app/shared/models/general.model';
 
@@ -7,7 +7,7 @@ import { Currency } from 'app/shared/models/general.model';
   templateUrl: './general-tab.component.html',
   styleUrls: ['./general-tab.component.scss']
 })
-export class GeneralTabComponent implements OnInit {
+export class GeneralTabComponent {
 
   fixedDepositsAccountData: any;
   entityType: string;
@@ -28,7 +28,4 @@ export class GeneralTabComponent implements OnInit {
     }
   }
 
-  ngOnInit(): void {
-  }
-
 }

src/app/deposits/recurring-deposits/create-recurring-deposits-account/create-recurring-deposits-account.component.html

@@ -84,7 +84,7 @@
       <mifosx-recurring-deposits-account-preview-step
         [recurringDepositsAccountTemplate]="recurringDepositsAccountTemplate"
         [recurringDepositsAccountProductTemplate]="recurringDepositsAccountProductTemplate"
-        [recurringDepositAccountData]="recurringDepositAccountData" (submit)="submit()">
+        [recurringDepositAccountData]="recurringDepositAccountData" (submitEvent)="submit()">
       </mifosx-recurring-deposits-account-preview-step>
 
     </mat-step>

src/app/deposits/recurring-deposits/create-recurring-deposits-account/create-recurring-deposits-account.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 
 /** Custom Services */
@@ -21,7 +21,7 @@ import { Dates } from 'app/core/utils/dates';
   templateUrl: './create-recurring-deposits-account.component.html',
   styleUrls: ['./create-recurring-deposits-account.component.scss']
 })
-export class CreateRecurringDepositsAccountComponent implements OnInit {
+export class CreateRecurringDepositsAccountComponent {
 
   /** Imports all the step component */
   @ViewChild(RecurringDepositsAccountDetailsStepComponent, { static: true }) recurringDepositsAccountDetailsStep: RecurringDepositsAccountDetailsStepComponent;
@@ -53,9 +53,6 @@ export class CreateRecurringDepositsAccountComponent implements OnInit {
     this.recurringDepositsAccountProductTemplate = $event;
   }
 
-  ngOnInit() {
-  }
-
   /** Get Recurring Deposit Account Details Form Data */
   get recurringDepositAccountDetailsForm() {
     return this.recurringDepositsAccountDetailsStep.recurringDepositAccountDetailsForm;

src/app/deposits/recurring-deposits/edit-recurring-deposit-account/edit-recurring-deposit-account.component.html

@@ -84,7 +84,7 @@
       <mifosx-recurring-deposits-account-preview-step
         [recurringDepositsAccountTemplate]="recurringDepositsAccountAndTemplate"
         [recurringDepositsAccountProductTemplate]="recurringDepositsAccountProductTemplate"
-        [recurringDepositAccountData]="recurringDepositAccountData" (submit)="submit()">
+        [recurringDepositAccountData]="recurringDepositAccountData" (submitEvent)="submit()">
       </mifosx-recurring-deposits-account-preview-step>
 
     </mat-step>

src/app/deposits/recurring-deposits/edit-recurring-deposit-account/edit-recurring-deposit-account.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 
 /** Custom Services */
@@ -21,7 +21,7 @@ import { Dates } from 'app/core/utils/dates';
   templateUrl: './edit-recurring-deposit-account.component.html',
   styleUrls: ['./edit-recurring-deposit-account.component.scss']
 })
-export class EditRecurringDepositAccountComponent implements OnInit {
+export class EditRecurringDepositAccountComponent {
 
   /** Imports all the step component */
   @ViewChild(RecurringDepositsAccountDetailsStepComponent, { static: true }) recurringDepositsAccountDetailsStep: RecurringDepositsAccountDetailsStepComponent;
@@ -53,9 +53,6 @@ export class EditRecurringDepositAccountComponent implements OnInit {
     this.recurringDepositsAccountProductTemplate = $event;
   }
 
-  ngOnInit() {
-  }
-
   /** Get Recurring Deposit Account Details Form Data */
   get recurringDepositAccountDetailsForm() {
     return this.recurringDepositsAccountDetailsStep.recurringDepositAccountDetailsForm;

src/app/deposits/recurring-deposits/recurring-deposits-account-stepper/recurring-deposits-account-preview-step/recurring-deposits-account-preview-step.component.html

@@ -352,7 +352,7 @@
   <button mat-raised-button [routerLink]="['../..']">
     {{"labels.buttons.Cancel" | translate }}
   </button>
-  <button mat-raised-button color="primary" (click)="submit.emit()">
+  <button mat-raised-button color="primary" (click)="submitEvent.emit()">
     {{"labels.buttons.Submit" | translate }}
   </button>
 </div>

src/app/deposits/recurring-deposits/recurring-deposits-account-stepper/recurring-deposits-account-preview-step/recurring-deposits-account-preview-step.component.ts

@@ -24,7 +24,7 @@ export class RecurringDepositsAccountPreviewStepComponent implements OnChanges {
   @Input() recurringDepositsAccountProductTemplate: any;
   @Input() recurringDepositAccountData: any;
   /** Output the submit action */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   /** Charges Displayed Columns */
   chargesDisplayedColumns: string[] = ['name', 'chargeCalculationType', 'amount', 'chargeTimeType', 'date', 'repaymentsEvery'];

src/app/deposits/recurring-deposits/recurring-deposits-account-view/charges-tab/charges-tab.component.html

@@ -75,7 +75,7 @@
             </button>
           </span>
           <span *ngIf="recurringDepositsAccountData.status.value !== 'Submitted and pending approval' && charge.amountOutstanding !== 0">
-            <span *ngIf="charge.chargeTimeType.value == 'Monthly Fee' || charge.chargeTimeType.value == 'Annual Fee'|| charge.chargeTimeType.value == 'Specified due date'">
+            <span *ngIf="charge.chargeTimeType.value === 'Monthly Fee' || charge.chargeTimeType.value === 'Annual Fee'|| charge.chargeTimeType.value === 'Specified due date'">
               <button class="account-action-button" mat-raised-button color="primary" matTooltip="{{ 'tooltips.Pay Charge' | translate}}"
               *mifosxHasPermission="'PAY_SAVINGSACCOUNTCHARGE'" (click)="routeEdit($event); payCharge(charge.id)">
                 <i class="fa fa-dollar"></i>

src/app/deposits/recurring-deposits/recurring-deposits-account-view/custom-dialogs/recurring-deposit-confirmation-dialog/recurring-deposit-confirmation-dialog.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, Inject } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
 
 @Component({
@@ -6,7 +6,7 @@ import { MatDialogRef, MAT_DIALOG_DATA } from '@angular/material/dialog';
   templateUrl: './recurring-deposit-confirmation-dialog.component.html',
   styleUrls: ['./recurring-deposit-confirmation-dialog.component.scss']
 })
-export class RecurringDepositConfirmationDialogComponent implements OnInit {
+export class RecurringDepositConfirmationDialogComponent {
 
   /**
    * @param {MatDialogRef} dialogRef Component reference to dialog.
@@ -15,7 +15,4 @@ export class RecurringDepositConfirmationDialogComponent implements OnInit {
   constructor(public dialogRef: MatDialogRef<RecurringDepositConfirmationDialogComponent>,
     @Inject(MAT_DIALOG_DATA) public data: any) { }
 
-  ngOnInit() {
-  }
-
 }

src/app/deposits/recurring-deposits/recurring-deposits-account-view/general-tab/general-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { Currency } from 'app/shared/models/general.model';
 
@@ -7,7 +7,7 @@ import { Currency } from 'app/shared/models/general.model';
   templateUrl: './general-tab.component.html',
   styleUrls: ['./general-tab.component.scss']
 })
-export class GeneralTabComponent implements OnInit {
+export class GeneralTabComponent {
 
   recurringDepositsAccountData: any;
   isprematureAllowed = false;
@@ -29,7 +29,5 @@ export class GeneralTabComponent implements OnInit {
       }
     });
   }
-  ngOnInit(): void {
-  }
 
 }

src/app/deposits/recurring-deposits/recurring-deposits-account-view/transactions-tab/view-transaction/view-transaction.component.html

@@ -2,7 +2,7 @@
   *ngIf="!(transactionData.reversed)">
   <span *mifosxHasPermission="'ADJUSTTRANSACTION_SAVINGSACCOUNT'">
     <button mat-raised-button color="primary"
-      *ngIf="!(transactionData.transactionType.value == 'Transfer' || transactionData.reversed == 'true')"
+      *ngIf="!(transactionData.transactionType.value === 'Transfer' || transactionData.reversed === 'true')"
       [routerLink]="'edit'">
       <fa-icon icon="edit" class="m-r-10"></fa-icon>{{"labels.buttons.Edit" | translate }}
     </button>

src/app/groups/groups-view/notes-tab/notes-tab.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /** Custom Services */
@@ -16,7 +16,7 @@ import { GroupsService } from '../../groups.service';
   templateUrl: './notes-tab.component.html',
   styleUrls: ['./notes-tab.component.scss']
 })
-export class NotesTabComponent implements OnInit {
+export class NotesTabComponent {
 
   /** Group ID */
   entityId: string;
@@ -42,9 +42,6 @@ export class NotesTabComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Adds a new note.
    */

src/app/home/timeout-dialog/session-timeout-dialog.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { MatDialogRef } from '@angular/material/dialog';
 
 @Component({
@@ -6,12 +6,9 @@ import { MatDialogRef } from '@angular/material/dialog';
   templateUrl: './session-timeout-dialog.component.html',
   styleUrls: ['./session-timeout-dialog.component.scss']
 })
-export class SessionTimeoutDialogComponent implements OnInit {
+export class SessionTimeoutDialogComponent {
 
   constructor(public dialogRef: MatDialogRef<SessionTimeoutDialogComponent>) {
   }
 
-  ngOnInit(): void {
-  }
-
 }

src/app/home/warning-dialog/warning-dialog.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { MatDialogRef } from '@angular/material/dialog';
 import { environment } from '../../../environments/environment';
 
@@ -7,7 +7,7 @@ import { environment } from '../../../environments/environment';
   templateUrl: './warning-dialog.component.html',
   styleUrls: ['./warning-dialog.component.scss']
 })
-export class WarningDialogComponent implements OnInit {
+export class WarningDialogComponent {
 
   title: string;
   content: string;
@@ -19,7 +19,4 @@ export class WarningDialogComponent implements OnInit {
     this.buttonText = environment.warningDialog.buttonText;
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/loans/create-loans-account/create-loans-account.component.html

@@ -76,7 +76,7 @@
       <ng-template matStepLabel>{{"labels.inputs.PREVIEW" | translate}}</ng-template>
 
       <mifosx-loans-account-preview-step [loansAccountTemplate]="loansAccountTemplate"
-        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submit)="submit()">
+        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submitEvent)="submit()">
       </mifosx-loans-account-preview-step>
 
     </mat-step>

src/app/loans/create-loans-account/create-loans-account.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, QueryList, ViewChild, ViewChildren } from '@angular/core';
+import { Component, QueryList, ViewChild, ViewChildren } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 
 /** Custom Services */
@@ -21,7 +21,7 @@ import { LoansAccountDatatableStepComponent } from '../loans-account-stepper/loa
   templateUrl: './create-loans-account.component.html',
   styleUrls: ['./create-loans-account.component.scss']
 })
-export class CreateLoansAccountComponent implements OnInit {
+export class CreateLoansAccountComponent {
 
   /** Imports all the step component */
   @ViewChild(LoansAccountDetailsStepComponent, { static: true }) loansAccountDetailsStep: LoansAccountDetailsStepComponent;
@@ -63,8 +63,6 @@ export class CreateLoansAccountComponent implements OnInit {
     });
   }
 
-  ngOnInit() { }
-
   /**
    * Sets loans account product template and collateral template
    * @param {any} $event API response

src/app/loans/custom-dialog/loan-delinquency-action-dialog/loan-delinquency-action-dialog.component.ts

@@ -1,4 +1,4 @@
-import { Component, Inject, OnInit } from '@angular/core';
+import { Component, Inject } from '@angular/core';
 import { UntypedFormBuilder, UntypedFormGroup, Validators } from '@angular/forms';
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
 
@@ -7,7 +7,7 @@ import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
   templateUrl: './loan-delinquency-action-dialog.component.html',
   styleUrls: ['./loan-delinquency-action-dialog.component.scss']
 })
-export class LoanDelinquencyActionDialogComponent implements OnInit {
+export class LoanDelinquencyActionDialogComponent {
 
   delinquencyActionForm: UntypedFormGroup;
   /** Minimum date allowed. */
@@ -21,8 +21,6 @@ export class LoanDelinquencyActionDialogComponent implements OnInit {
       this.createDelinquencyActionForm();
   }
 
-  ngOnInit(): void { }
-
   createDelinquencyActionForm() {
     this.delinquencyActionForm = this.formBuilder.group({
       'startDate': [new Date(), Validators.required],

src/app/loans/edit-loans-account/edit-loans-account.component.html

@@ -68,7 +68,7 @@
       <ng-template matStepLabel>{{"labels.inputs.PREVIEW" | translate}}</ng-template>
 
       <mifosx-loans-account-preview-step [loansAccountTemplate]="loansAccountAndTemplate"
-        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submit)="submit()">
+        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submitEvent)="submit()">
       </mifosx-loans-account-preview-step>
 
     </mat-step>

src/app/loans/edit-loans-account/edit-loans-account.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { LoansService } from '../loans.service';
 import { LoansAccountDetailsStepComponent } from '../loans-account-stepper/loans-account-details-step/loans-account-details-step.component';
@@ -17,7 +17,7 @@ import { Dates } from 'app/core/utils/dates';
   templateUrl: './edit-loans-account.component.html',
   styleUrls: ['./edit-loans-account.component.scss']
 })
-export class EditLoansAccountComponent implements OnInit {
+export class EditLoansAccountComponent {
 
   @ViewChild(LoansAccountDetailsStepComponent, { static: true }) loansAccountDetailsStep: LoansAccountDetailsStepComponent;
   @ViewChild(LoansAccountTermsStepComponent, { static: true }) loansAccountTermsStep: LoansAccountTermsStepComponent;
@@ -53,9 +53,6 @@ export class EditLoansAccountComponent implements OnInit {
     this.loanId = this.route.snapshot.params['loanId'];
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Sets loans account product template and collateral template
    * @param {any} $event API response

src/app/loans/glim-account/create-glim-account/create-glim-account.component.html

@@ -58,7 +58,7 @@
       <ng-template matStepLabel>{{"labels.inputs.PREVIEW" | translate}}</ng-template>
 
       <mifosx-loans-account-preview-step [loansAccountTemplate]="loansAccountTemplate"
-        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submit)="submit()">
+        [loansAccountProductTemplate]="loansAccountProductTemplate" [loansAccount]="loansAccount" (submitEvent)="submit()">
       </mifosx-loans-account-preview-step>
 
     </mat-step>

src/app/loans/glim-account/create-glim-account/create-glim-account.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, ViewChild } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { ActivatedRoute, Router } from '@angular/router';
 import { Dates } from 'app/core/utils/dates';
@@ -13,7 +13,7 @@ import { GlimTermsStepComponent } from './glim-account-stepper/glim-terms-step/g
   templateUrl: './create-glim-account.component.html',
   styleUrls: ['./create-glim-account.component.scss']
 })
-export class CreateGlimAccountComponent implements OnInit {
+export class CreateGlimAccountComponent {
 
   /** Imports all the step component */
   @ViewChild(GlimDetailsStepComponent, { static: true }) loansAccountDetailsStep: GlimDetailsStepComponent;
@@ -61,9 +61,6 @@ export class CreateGlimAccountComponent implements OnInit {
     });
    }
 
-  ngOnInit(): void {
-  }
-
   /**
    * Sets loans account product template and collateral template
    * @param {any} $event API response

src/app/loans/glim-account/create-glim-account/glim-account-stepper/glim-preview-step/glim-preview-step.component.html

@@ -269,7 +269,7 @@
     <button mat-raised-button [routerLink]="['../']">
       {{"labels.buttons.Cancel" | translate}}
     </button>
-    <button mat-raised-button color="primary" (click)="submit.emit()">
+    <button mat-raised-button color="primary" (click)="submitEvent.emit()">
       {{"labels.buttons.Submit" | translate}}
     </button>
   </div>

src/app/loans/glim-account/create-glim-account/glim-account-stepper/glim-preview-step/glim-preview-step.component.ts

@@ -1,11 +1,11 @@
-import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
+import { Component, EventEmitter, Input, Output } from '@angular/core';
 
 @Component({
   selector: 'mifosx-glim-preview-step',
   templateUrl: './glim-preview-step.component.html',
   styleUrls: ['./glim-preview-step.component.scss']
 })
-export class GlimPreviewStepComponent implements OnInit {
+export class GlimPreviewStepComponent {
 
 
   /** Loans Account Template */
@@ -15,7 +15,7 @@ export class GlimPreviewStepComponent implements OnInit {
   /** Loans Account Data */
   @Input() loansAccount: any;
   /** Submit Loans Account */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   /** Charges Displayed Columns */
   chargesDisplayedColumns: string[] = ['name', 'chargeCalculationType', 'amount', 'chargeTimeType', 'date'];
@@ -24,7 +24,4 @@ export class GlimPreviewStepComponent implements OnInit {
 
   constructor() { }
 
-  ngOnInit(): void {
-  }
-
 }

src/app/loans/glim-account/create-glim-account/glim-account-stepper/glim-terms-step/glim-terms-step.component.html

@@ -62,7 +62,7 @@
         </mat-select>
       </mat-form-field>
 
-      <mat-form-field fxFlex="48%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value == 2">
+      <mat-form-field fxFlex="48%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value === 2">
         <mat-label>{{"labels.inputs.Select On" | translate}}</mat-label>
         <mat-select formControlName="repaymentFrequencyNthDayType">
           <mat-option
@@ -73,7 +73,7 @@
         </mat-select>
       </mat-form-field>
 
-      <mat-form-field fxFlex="48%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value == 2">
+      <mat-form-field fxFlex="48%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value === 2">
         <mat-label>{{"labels.inputs.Select Day" | translate}}</mat-label>
         <mat-select formControlName="repaymentFrequencyDayOfWeekType">
           <mat-option

src/app/loans/loans-account-stepper/loans-account-preview-step/loans-account-preview-step.component.html

@@ -290,7 +290,7 @@
   <button mat-raised-button [routerLink]="['../..']">
     {{"labels.buttons.Cancel" | translate}}
   </button>
-  <button mat-raised-button color="primary" (click)="submit.emit()">
+  <button mat-raised-button color="primary" (click)="submitEvent.emit()">
     {{"labels.buttons.Submit" | translate}}
   </button>
 </div>

src/app/loans/loans-account-stepper/loans-account-preview-step/loans-account-preview-step.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, Output, EventEmitter, OnDestroy, OnChanges, SimpleChanges } from '@angular/core';
+import { Component, Input, Output, EventEmitter, OnChanges, SimpleChanges } from '@angular/core';
 
 /**
  * Create Loans Account Preview Step
@@ -9,7 +9,7 @@ import { Component, OnInit, Input, Output, EventEmitter, OnDestroy, OnChanges, S
   templateUrl: './loans-account-preview-step.component.html',
   styleUrls: ['./loans-account-preview-step.component.scss']
 })
-export class LoansAccountPreviewStepComponent implements OnInit, OnChanges {
+export class LoansAccountPreviewStepComponent implements OnChanges {
 
   /** Loans Account Template */
   @Input() loansAccountTemplate: any = [];
@@ -18,7 +18,7 @@ export class LoansAccountPreviewStepComponent implements OnInit, OnChanges {
   /** Loans Account Data */
   @Input() loansAccount: any;
   /** Submit Loans Account */
-  @Output() submit = new EventEmitter();
+  @Output() submitEvent = new EventEmitter();
 
   /** Charges Displayed Columns */
   chargesDisplayedColumns: string[] = ['name', 'chargeCalculationType', 'amount', 'chargeTimeType', 'date'];
@@ -29,8 +29,6 @@ export class LoansAccountPreviewStepComponent implements OnInit, OnChanges {
 
   constructor() { }
 
-  ngOnInit() { }
-
   ngOnChanges(changes: SimpleChanges): void {
     this.productEnableDownPayment = this.loansAccountProductTemplate.product.enableDownPayment;
   }

src/app/loans/loans-account-stepper/loans-account-schedule-step/loans-account-schedule-step.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, OnInit } from '@angular/core';
+import { Component, Input } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 import { LoansService } from 'app/loans/loans.service';
 import { SettingsService } from 'app/settings/settings.service';
@@ -8,7 +8,7 @@ import { SettingsService } from 'app/settings/settings.service';
   templateUrl: './loans-account-schedule-step.component.html',
   styleUrls: ['./loans-account-schedule-step.component.scss']
 })
-export class LoansAccountScheduleStepComponent implements OnInit {
+export class LoansAccountScheduleStepComponent {
 
   /** Currency Code */
   @Input() currencyCode: string;
@@ -29,8 +29,6 @@ export class LoansAccountScheduleStepComponent implements OnInit {
       this.loanId = this.route.snapshot.params['loanId'];
   }
 
-  ngOnInit(): void { }
-
   showRepaymentInfo(): void {
     this.repaymentScheduleDetails = {periods: []};
     const locale = this.settingsService.language.code;

src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html

@@ -83,7 +83,7 @@
       </mat-select>
     </mat-form-field>
 
-    <mat-form-field fxFlex="14%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value == 2">
+    <mat-form-field fxFlex="14%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value === 2">
       <mat-label>{{"labels.inputs.Select On" | translate}}</mat-label>
       <mat-select formControlName="repaymentFrequencyNthDayType">
         <mat-option *ngFor="let repaymentFrequencyNthDayType of repaymentFrequencyNthDayTypeData"
@@ -93,7 +93,7 @@
       </mat-select>
     </mat-form-field>
 
-    <mat-form-field fxFlex="14%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value == 2">
+    <mat-form-field fxFlex="14%" *ngIf="loansAccountTermsForm.controls.repaymentFrequencyType.value === 2">
       <mat-label>{{"labels.inputs.Select Day" | translate}}</mat-label>
       <mat-select formControlName="repaymentFrequencyDayOfWeekType">
         <mat-option *ngFor="let repaymentFrequencyDayOfWeekType of repaymentFrequencyDaysOfWeekTypeData"
@@ -329,15 +329,15 @@
         <span fxFlex="40%">{{"labels.inputs.Frequency Interval for recalculation" | translate}}</span>
         <span fxFlex="60%">
           <span>{{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.value}}</span>
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id == 3 &&
-                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyWeekday != null">
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id === 3 &&
+                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyWeekday">
             on {{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyWeekday.value}}</span>
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id == 4 &&
-                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyOnDay != null">on day
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id === 4 &&
+                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyOnDay">on day
             {{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyOnDay}}</span>
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id == 4 &&
-                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyOnDay == null &&
-                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyNthDay != null">on
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id === 4 &&
+                ! loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyOnDay &&
+                loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyNthDay">on
             {{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyNthDay.value}}
             {{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyWeekday.value}}</span>
         </span>
@@ -346,7 +346,7 @@
     </ng-container>
 
     <div fxFlexFill
-      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled && loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id != 1">
+      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled && loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyType.id !== 1">
       <span fxFlex="40%">{{"labels.inputs.Frequency Interval for recalculation" | translate}}</span>
       <span fxFlex="60%">{{ loansAccountTermsData.interestRecalculationData.recalculationRestFrequencyInterval}}</span>
     </div>
@@ -401,23 +401,23 @@
     </ng-container>
 
     <ng-container
-      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled  && loansAccountTermsData.interestRecalculationData.interestRecalculationCompoundingType.id != 0">
+      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled  && loansAccountTermsData.interestRecalculationData.interestRecalculationCompoundingType.id !== 0">
 
       <div fxFlexFill>
         <span fxFlex="40%">{{"labels.inputs.Frequency for compounding" | translate}}</span>
         <span fxFlex="60%">{{
           loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.value}}
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id == 3 &&
-            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyWeekday != null">
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id === 3 &&
+            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyWeekday">
             on {{ loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyWeekday.value}}
           </span>
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id == 4 &&
-            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyOnDay != null">on day
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id === 4 &&
+            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyOnDay">on day
             {{ loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyOnDay}}
           </span>
-          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id == 4 &&
-            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyOnDay == null &&
-            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyNthDay != null">on
+          <span *ngIf="loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id === 4 &&
+            ! loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyOnDay &&
+            loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyNthDay">on
             {{ loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyNthDay.value}}
             {{ loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyWeekday.value}}
           </span>
@@ -426,7 +426,7 @@
     </ng-container>
 
     <div fxFlexFill
-      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled && loansAccountTermsData.interestRecalculationData.interestRecalculationCompoundingType.id != 0 && loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id != 1">
+      *ngIf="loansAccountTermsData?.isInterestRecalculationEnabled && loansAccountTermsData.interestRecalculationData.interestRecalculationCompoundingType.id !== 0 && loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyType.id !== 1">
       <span fxFlex="40%">{{"labels.inputs.Frequency Interval for compounding" | translate}}</span>
       <span fxFlex="60%">{{
         loansAccountTermsData.interestRecalculationData.recalculationCompoundingFrequencyInterval}}</span>

src/app/loans/loans-view/account-details/account-details.component.html

@@ -11,7 +11,7 @@
         <div fxFlexFill>
             <span fxFlex="50%">{{"labels.inputs.Repayments" | translate}}</span>
             <span fxFlex="50%">{{loanDetails.numberOfRepayments}} every {{loanDetails.repaymentEvery}}&nbsp;{{loanDetails.repaymentFrequencyType.value | translateKey:'catalogs' }}
-            <span *ngIf="loanDetails.repaymentFrequencyType?.id == 2 && loanDetails.repaymentFrequencyNthDayType?.id != 0 && loanDetails.repaymentFrequencyDayOfWeekType?.id != 0" class="m-l-10">
+            <span *ngIf="loanDetails.repaymentFrequencyType?.id === 2 && loanDetails.repaymentFrequencyNthDayType?.id !== 0 && loanDetails.repaymentFrequencyDayOfWeekType?.id !== 0" class="m-l-10">
               <span *ngIf="loanDetails.repaymentFrequencyDayOfWeekType">
                 <span class="m-l-10">{{"labels.commons.on" | translate}}</span>{{loanDetails.repaymentFrequencyNthDayType?.value}}
                 <span class="m-l-10">{{loanDetails.repaymentFrequencyDayOfWeekType?.value | translateKey:'catalogs' }}</span>
@@ -166,7 +166,7 @@
             <span fxFlex="50%"> {{loanDetails.interestRecalculationData.calendarData.humanReadable}} </span>
         </div>
 
-        <div fxFlexFill *ngIf="loanDetails.isInterestRecalculationEnabled && loanDetails.interestRecalculationData.interestRecalculationCompoundingType.id !=0">
+        <div fxFlexFill *ngIf="loanDetails.isInterestRecalculationEnabled && loanDetails.interestRecalculationData.interestRecalculationCompoundingType.id !== 0">
             <span fxFlex="50%"> {{"labels.inputs.Frequency for compounding" | translate}}</span>
             <span fxFlex="50%"> {{loanDetails.interestRecalculationData.compoundingCalendarData.humanReadable}} </span>
         </div>

src/app/loans/loans-view/account-details/account-details.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 @Component({
@@ -6,7 +6,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './account-details.component.html',
   styleUrls: ['./account-details.component.scss']
 })
-export class AccountDetailsComponent implements OnInit {
+export class AccountDetailsComponent {
 
   loanDetails: any;
   dataObject: {
@@ -20,7 +20,4 @@ export class AccountDetailsComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/loans/loans-view/charges-tab/charges-tab.component.html

@@ -79,12 +79,12 @@
           </button>
         </span>
         <button class="account-action-button" mat-raised-button color="accent" matTooltip="{{ 'tooltips.Adjust Charge' | translate}}"
-          *ngIf="!charge.paid && status=='Active'"
+          *ngIf="!charge.paid && status==='Active'"
           (click)="routeEdit($event); adjustCharge(charge.id)">
           <i class="fa fa-pencil"></i>
         </button>
         <button class="account-action-button" mat-raised-button color="primary" matTooltip="{{ 'tooltips.Pay Charge' | translate}}"
-          *ngIf="charge.chargePayable && !charge.paid && status=='Active'"
+          *ngIf="charge.chargePayable && !charge.paid && status==='Active'"
           (click)="routeEdit($event); payCharge(charge.id)">
           <i class="fa fa-dollar"></i>
         </button>

src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, OnDestroy } from '@angular/core';
+import { Component, OnInit, Input } from '@angular/core';
 import { UntypedFormGroup, UntypedFormBuilder, Validators, UntypedFormControl } from '@angular/forms';
 import { ActivatedRoute, Router } from '@angular/router';
 
@@ -17,7 +17,7 @@ import { Currency } from 'app/shared/models/general.model';
   templateUrl: './make-repayment.component.html',
   styleUrls: ['./make-repayment.component.scss']
 })
-export class MakeRepaymentComponent implements OnInit, OnDestroy {
+export class MakeRepaymentComponent implements OnInit {
 
   @Input() dataObject: any;
   /** Loan Id */
@@ -63,10 +63,6 @@ export class MakeRepaymentComponent implements OnInit, OnDestroy {
     }
   }
 
-  ngOnDestroy(): void {
-
-  }
-
   /**
    * Creates the create close form.
    */

src/app/loans/loans-view/loan-account-actions/prepay-loan/prepay-loan.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, OnDestroy } from '@angular/core';
+import { Component, OnInit, Input } from '@angular/core';
 import { UntypedFormGroup, UntypedFormBuilder, Validators, UntypedFormControl } from '@angular/forms';
 import { ActivatedRoute, Router } from '@angular/router';
 
@@ -18,7 +18,7 @@ import { Currency } from 'app/shared/models/general.model';
   templateUrl: './prepay-loan.component.html',
   styleUrls: ['./prepay-loan.component.scss']
 })
-export class PrepayLoanComponent implements OnInit, OnDestroy {
+export class PrepayLoanComponent implements OnInit {
 
   @Input() dataObject: any;
   /** Loan Id */
@@ -71,9 +71,6 @@ export class PrepayLoanComponent implements OnInit, OnDestroy {
     }
   }
 
-  ngOnDestroy(): void {
-  }
-
   /**
    * Creates the prepay loan form.
    */

src/app/loans/loans-view/loan-account-actions/view-guarantors/view-guarantors.component.html

@@ -161,7 +161,7 @@
                 <fa-icon icon="eye" class="m-r-10"></fa-icon>
               </button>
               <button mat-raised-button class="account-action-button" color="primary"
-                *ngIf="guarantor.status && guarantor.guarantorType.id == 3 && guarantor.id">
+                *ngIf="guarantor.status && guarantor.guarantorType.id === 3 && guarantor.id">
                 <fa-icon icon="edit" class="m-r-10"></fa-icon>
               </button>
               <span *ngIf="guarantor.status">

src/app/loans/loans-view/loan-documents-tab/loan-documents-tab.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /** Custom Services */
@@ -15,7 +15,7 @@ import { SettingsService } from 'app/settings/settings.service';
   templateUrl: './loan-documents-tab.component.html',
   styleUrls: ['./loan-documents-tab.component.scss']
 })
-export class LoanDocumentsTabComponent implements OnInit {
+export class LoanDocumentsTabComponent {
 
   /** Stores the resolved loan documents data */
   entityDocuments: any;
@@ -37,8 +37,6 @@ export class LoanDocumentsTabComponent implements OnInit {
       });
   }
 
-  ngOnInit() { }
-
   getLoanDocumentsData(data: any) {
     data.forEach((ele: any) => {
       ele.docUrl = this.settingsService.serverUrl + '/loans/' + ele.parentEntityId + '/documents/' + ele.id + '/attachment?tenantIdentifier=' + environment.fineractPlatformTenantId;

src/app/loans/loans-view/loans-view.component.html

@@ -28,7 +28,7 @@
                 <span class="m-r-10">{{'labels.text.' + entityType | translate}} {{"labels.inputs.name" | translate}} :</span> {{loanDetailsData.clientName ||
                 loanDetailsData.groupName}}<span class="m-l-5">({{loanDetailsData.clientAccountNo}})</span><br />
               </span>
-              <div *ngIf="loanDisplayArrearsDelinquency != 1">
+              <div *ngIf="loanDisplayArrearsDelinquency !== 1">
                 <table class="account-overview">
                   <tbody>
                     <tr *ngIf="loanDetailsData.delinquencyRange">
@@ -43,7 +43,7 @@
                       <td>{{loanDetailsData?.delinquent.pastDueDays | formatNumber }}</td>
                     </tr>
                     <tr *ngIf="loanDetailsData.delinquent && loanDetailsData.delinquent.delinquentDays > 0
-                      && loanDetailsData.delinquent.pastDueDays != loanDetailsData.delinquent.delinquentDays">
+                      && loanDetailsData.delinquent.pastDueDays !== loanDetailsData.delinquent.delinquentDays">
                       <td>{{"labels.inputs.Delinquent Days" | translate}} :</td>
                       <td>{{loanDetailsData?.delinquent.delinquentDays | formatNumber }}</td>
                     </tr>

src/app/loans/loans-view/notes-tab/notes-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /** Custom Components */
@@ -12,7 +12,7 @@ import { AuthenticationService } from '../../../core/authentication/authenticati
   templateUrl: './notes-tab.component.html',
   styleUrls: ['./notes-tab.component.scss']
 })
-export class NotesTabComponent implements OnInit {
+export class NotesTabComponent {
 
   entityId: string;
   username: string;
@@ -29,8 +29,6 @@ export class NotesTabComponent implements OnInit {
     });
   }
 
-  ngOnInit() { }
-
   addNote(noteContent: any) {
     this.loansService.createLoanNote(this.entityId, noteContent).subscribe((response: any) => {
       this.entityNotes.push({

src/app/loans/loans-view/reschedule-loan-tab/reschedule-loan-tab.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input, OnInit } from '@angular/core';
+import { Component, Input } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { ActivatedRoute, Router } from '@angular/router';
 import { TranslateService } from '@ngx-translate/core';
@@ -13,7 +13,7 @@ import { ConfirmationDialogComponent } from 'app/shared/confirmation-dialog/conf
   templateUrl: './reschedule-loan-tab.component.html',
   styleUrls: ['./reschedule-loan-tab.component.scss']
 })
-export class RescheduleLoanTabComponent implements OnInit {
+export class RescheduleLoanTabComponent {
   @Input() loanStatus: LoanStatus;
 
   loanRescheduleData: any;
@@ -33,9 +33,6 @@ export class RescheduleLoanTabComponent implements OnInit {
     });
   }
 
-  ngOnInit(): void {
-  }
-
   manageRequest(request: any, command: string): void {
     const approveLoanRescheduleDialogRef = this.dialog.open(ConfirmationDialogComponent, {
       data: { heading: `${command}` + this.translateService.instant('labels.heading.Loan Reschedule'), dialogContext: this.translateService.instant('labels.dialogContext.Are you sure you want') + `${command}` + this.translateService.instant('labels.dialogContext.the Loan Reschedule') + `${request.id}` }

src/app/loans/loans-view/standing-instructions-tab/standing-instructions-tab.component.html

@@ -23,8 +23,8 @@
       <ng-container matColumnDef="beneficiary">
         <th mat-header-cell *matHeaderCellDef> {{"labels.inputs.Beneficiary" | translate}} </th>
         <td mat-cell *matCellDef="let instruction">
-          <span *ngIf="instruction.fromClient.id != instruction.toClient.id"> {{instruction.toClient.displayName}} </span>
-          <span *ngIf="instruction.fromClient.id == instruction.toClient.id">{{"labels.inputs.Own Account" | translate}}</span>
+          <span *ngIf="instruction.fromClient.id !== instruction.toClient.id"> {{instruction.toClient.displayName}} </span>
+          <span *ngIf="instruction.fromClient.id === instruction.toClient.id">{{"labels.inputs.Own Account" | translate}}</span>
         </td>
       </ng-container>
 

src/app/navigation/center-navigation/center-navigation.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 
 /** Custom Components */
 import { LoanAccountTableComponent } from '../loan-account-table/loan-account-table.component';
@@ -11,7 +11,7 @@ import { SavingsAccountTableComponent } from '../savings-account-table/savings-a
   templateUrl: './center-navigation.component.html',
   styleUrls: ['./center-navigation.component.scss']
 })
-export class CenterNavigationComponent implements OnInit {
+export class CenterNavigationComponent {
 
   @ViewChild(LoanAccountTableComponent) loanAccountTableComponent: LoanAccountTableComponent;
   @ViewChild(SavingsAccountTableComponent) savingsAccountTableComponent: SavingsAccountTableComponent;
@@ -23,7 +23,4 @@ export class CenterNavigationComponent implements OnInit {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/navigation/client-navigation/client-navigation.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 
 /** Custom Components */
 import { LoanAccountTableComponent } from '../loan-account-table/loan-account-table.component';
@@ -12,7 +12,7 @@ import { MemberGroupsComponent } from '../member-groups/member-groups.component'
   templateUrl: './client-navigation.component.html',
   styleUrls: ['./client-navigation.component.scss']
 })
-export class ClientNavigationComponent implements OnInit {
+export class ClientNavigationComponent {
 
   @ViewChild(LoanAccountTableComponent) loanAccountTableComponent: LoanAccountTableComponent;
   @ViewChild(SavingsAccountTableComponent) savingsAccountTableComponent: SavingsAccountTableComponent;
@@ -24,7 +24,4 @@ export class ClientNavigationComponent implements OnInit {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/navigation/group-navigation/group-navigation.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 
 /** Custom Components */
 import { LoanAccountTableComponent } from '../loan-account-table/loan-account-table.component';
@@ -11,7 +11,7 @@ import { SavingsAccountTableComponent } from '../savings-account-table/savings-a
   templateUrl: './group-navigation.component.html',
   styleUrls: ['./group-navigation.component.scss']
 })
-export class GroupNavigationComponent implements OnInit {
+export class GroupNavigationComponent {
 
   @ViewChild(LoanAccountTableComponent) loanAccountTableComponent: LoanAccountTableComponent;
   @ViewChild(SavingsAccountTableComponent) savingsAccountTableComponent: SavingsAccountTableComponent;
@@ -22,7 +22,4 @@ export class GroupNavigationComponent implements OnInit {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/navigation/loan-account-table/loan-account-table.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 import { MatPaginator } from '@angular/material/paginator';
 import { MatSort } from '@angular/material/sort';
 import { MatTableDataSource } from '@angular/material/table';
@@ -12,7 +12,7 @@ import { AccountsFilterPipe } from '../../pipes/accounts-filter.pipe';
   templateUrl: './loan-account-table.component.html',
   styleUrls: ['./loan-account-table.component.scss']
 })
-export class LoanAccountTableComponent implements OnInit {
+export class LoanAccountTableComponent {
 
   /** Columns to be displayed in the loan accounts table. */
   displayedColumns: string[] = ['accountNo', 'productName', 'Type', 'Status'];
@@ -50,9 +50,6 @@ export class LoanAccountTableComponent implements OnInit {
     this.dataSource.filter = filterValue.trim().toLowerCase();
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Toggles the loan status
    */

src/app/navigation/member-groups/member-groups.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 import { MatPaginator } from '@angular/material/paginator';
 import { MatSort } from '@angular/material/sort';
 import { MatTableDataSource } from '@angular/material/table';
@@ -9,7 +9,7 @@ import { MatTableDataSource } from '@angular/material/table';
   templateUrl: './member-groups.component.html',
   styleUrls: ['./member-groups.component.scss']
 })
-export class MemberGroupsComponent implements OnInit {
+export class MemberGroupsComponent {
 
   /** Columns to be displayed in the member groups table. */
   displayedColumns: string[] = ['accountNo', 'name'];
@@ -38,6 +38,4 @@ export class MemberGroupsComponent implements OnInit {
     this.dataSource.filter = filterValue.trim().toLowerCase();
   }
 
-  ngOnInit() { }
-
 }

src/app/navigation/office-navigation/office-navigation.component.ts

@@ -1,20 +1,17 @@
 
 /** Angular Imports */
-import { Component, OnInit, Input } from '@angular/core';
+import { Component, Input } from '@angular/core';
 
 @Component({
   selector: 'mifosx-office-navigation',
   templateUrl: './office-navigation.component.html',
   styleUrls: ['./office-navigation.component.scss']
 })
-export class OfficeNavigationComponent implements OnInit {
+export class OfficeNavigationComponent {
 
   @Input() officeData: any;
   @Input() employeeData: any;
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/navigation/savings-account-table/savings-account-table.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 import { MatPaginator } from '@angular/material/paginator';
 import { MatSort } from '@angular/material/sort';
 import { MatTableDataSource } from '@angular/material/table';
@@ -12,7 +12,7 @@ import { AccountsFilterPipe } from '../../pipes/accounts-filter.pipe';
   templateUrl: './savings-account-table.component.html',
   styleUrls: ['./savings-account-table.component.scss']
 })
-export class SavingsAccountTableComponent implements OnInit {
+export class SavingsAccountTableComponent {
 
   /** Columns to be displayed in the savings accounts table. */
   displayedColumns: string[] = ['accountNo', 'productName', 'accountBalance', 'Status'];
@@ -50,9 +50,6 @@ export class SavingsAccountTableComponent implements OnInit {
     this.dataSource.filter = filterValue.trim().toLowerCase();
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Toggles the savings status
    */

src/app/navigation/share-account-table/share-account-table.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit, Input, ViewChild } from '@angular/core';
+import { Component, Input, ViewChild } from '@angular/core';
 import { MatPaginator } from '@angular/material/paginator';
 import { MatSort } from '@angular/material/sort';
 import { MatTableDataSource } from '@angular/material/table';
@@ -12,7 +12,7 @@ import { AccountsFilterPipe } from '../../pipes/accounts-filter.pipe';
   templateUrl: './share-account-table.component.html',
   styleUrls: ['./share-account-table.component.scss']
 })
-export class ShareAccountTableComponent implements OnInit {
+export class ShareAccountTableComponent {
 
   /** Columns to be displayed in the share accounts table. */
   displayedColumns: string[] = ['accountNo', 'productName', 'totalApprovedShares', 'Status'];
@@ -50,9 +50,6 @@ export class ShareAccountTableComponent implements OnInit {
     this.dataSource.filter = filterValue.trim().toLowerCase();
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Toggles the share status
    */

src/app/navigation/staff-navigation/staff-navigation.component.ts

@@ -1,19 +1,16 @@
 /** Angular Imports */
-import { Component, OnInit, Input } from '@angular/core';
+import { Component, Input } from '@angular/core';
 
 @Component({
   selector: 'mifosx-staff-navigation',
   templateUrl: './staff-navigation.component.html',
   styleUrls: ['./staff-navigation.component.scss']
 })
-export class StaffNavigationComponent implements OnInit {
+export class StaffNavigationComponent {
 
   @Input() employeeData: any;
   @Input() centerData: any;
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
 }

src/app/organization/adhoc-query/view-adhoc-query/view-adhoc-query.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -17,7 +17,7 @@ import { DeleteDialogComponent } from 'app/shared/delete-dialog/delete-dialog.co
   templateUrl: './view-adhoc-query.component.html',
   styleUrls: ['./view-adhoc-query.component.scss']
 })
-export class ViewAdhocQueryComponent implements OnInit {
+export class ViewAdhocQueryComponent {
 
   /** Adhoc query data. */
   adhocQueryData: any;
@@ -38,9 +38,6 @@ export class ViewAdhocQueryComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Retrieves the report run frequency value from id
    * @returns {string} Report run frequency value.

src/app/organization/bulk-import/bulk-import.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 
 /**
  * Bulk Import component.
@@ -9,14 +9,12 @@ import { Component, OnInit } from '@angular/core';
   templateUrl: './bulk-import.component.html',
   styleUrls: ['./bulk-import.component.scss']
 })
-export class BulkImportComponent implements OnInit {
+export class BulkImportComponent {
   // Initialize an array of 17 boolean values, all set to false
   arrowBooleans: boolean[] = new Array(17).fill(false);
 
   constructor() {}
 
-  ngOnInit() {}
-
   /**
    * Popover function
    * @param arrowNumber - The index of the boolean value to toggle.

src/app/organization/employees/view-employee/view-employee.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 /**
@@ -10,7 +10,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './view-employee.component.html',
   styleUrls: ['./view-employee.component.scss']
 })
-export class ViewEmployeeComponent implements OnInit {
+export class ViewEmployeeComponent {
 
   /** Employee data. */
   employeeData: any;
@@ -25,7 +25,4 @@ export class ViewEmployeeComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/organization/manage-funds/view-fund/view-fund.component.ts

@@ -1,4 +1,4 @@
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
 @Component({
@@ -6,7 +6,7 @@ import { ActivatedRoute } from '@angular/router';
   templateUrl: './view-fund.component.html',
   styleUrls: ['./view-fund.component.scss']
 })
-export class ViewFundComponent implements OnInit {
+export class ViewFundComponent {
 
   /** Fund data. */
   fundData: any;
@@ -21,7 +21,4 @@ export class ViewFundComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
 }

src/app/organization/organization.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { AfterViewInit, Component, ElementRef, OnInit, TemplateRef, ViewChild } from '@angular/core';
+import { AfterViewInit, Component, ElementRef, TemplateRef, ViewChild } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 
 /** Custom Services */
@@ -14,7 +14,7 @@ import { PopoverService } from '../configuration-wizard/popover/popover.service'
   templateUrl: './organization.component.html',
   styleUrls: ['./organization.component.scss']
 })
-export class OrganizationComponent implements OnInit, AfterViewInit {
+export class OrganizationComponent implements AfterViewInit {
 
   shouldShowFundMapping = false;
   /* Reference of manage offices */
@@ -55,9 +55,6 @@ export class OrganizationComponent implements OnInit, AfterViewInit {
               private configurationWizardService: ConfigurationWizardService,
               private popoverService: PopoverService) { }
 
-  ngOnInit() {
-  }
-
   /**
    * Popover function
    * @param template TemplateRef<any>.

src/app/organization/sms-campaigns/create-campaign/create-campaign.component.html

@@ -52,7 +52,7 @@
 
       <mifosx-campaign-preview-step 
         [smsCampaignTemplate]="smsCampaignTemplate"
-        [campaign]="smsCampaign" (submit)="submit()"
+        [campaign]="smsCampaign" (submitEvent)="submit()"
       >
       </mifosx-campaign-preview-step>
 

src/app/organization/sms-campaigns/edit-campaign/edit-campaign.component.html

@@ -54,7 +54,7 @@
       <mifosx-campaign-preview-step
         [campaign]="smsCampaign"
         [editedCampaignMessage]="campaignMessage"
-        [smsCampaignTemplate]="smsCampaignTemplate" (submit)="submit()"
+        [smsCampaignTemplate]="smsCampaignTemplate" (submitEvent)="submit()"
       >
       </mifosx-campaign-preview-step>
 

src/app/organization/sms-campaigns/sms-campaign-stepper/campaign-preview-step/campaign-preview-step.component.html

@@ -29,7 +29,7 @@
     <button mat-raised-button [routerLink]="['../']">
       {{'labels.buttons.Cancel' | translate }}
     </button>
-    <button mat-raised-button color="primary" (click)="submit.emit()">
+    <button mat-raised-button color="primary" (click)="submitEvent.emit()">
       {{'labels.buttons.Submit' | translate }}
     </button>
   </div>

src/app/organization/sms-campaigns/sms-campaign-stepper/campaign-preview-step/campaign-preview-step.component.ts

@@ -24,7 +24,7 @@ export class CampaignPreviewStepComponent implements OnInit {
   smsProviders: any[];
 
   /** Emits submit() event */
-  @Output() submit = new EventEmitter;
+  @Output() submitEvent = new EventEmitter;
 
   constructor() { }
 

src/app/organization/tellers/view-teller/view-teller.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { ActivatedRoute, Router } from '@angular/router';
 import { MatDialog } from '@angular/material/dialog';
 
@@ -17,7 +17,7 @@ import { DeleteDialogComponent } from '../../../shared/delete-dialog/delete-dial
   templateUrl: './view-teller.component.html',
   styleUrls: ['./view-teller.component.scss']
 })
-export class ViewTellerComponent implements OnInit {
+export class ViewTellerComponent {
 
   /** Teller data. */
   tellerData: any;
@@ -38,9 +38,6 @@ export class ViewTellerComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the teller and redirects to tellers.
    */

src/app/products/charges/edit-charge/edit-charge.component.html

@@ -95,12 +95,12 @@
    * In shares case: Only for charge time type: SHARE_PURCHASE and SHARE_REDEEM and with charge calculation type as % amount only
   -->
           <mat-form-field fxFlex="48%"
-            *ngIf="(chargeForm.controls.chargeAppliesTo.value === 1 && (chargeForm.controls.chargeCalculationType.value === 2 || chargeForm.controls.chargeCalculationType.value === 3 || chargeForm.controls.chargeCalculationType.value === 4 || chargeForm.controls.chargeCalculationType.value==5)) || (chargeForm.controls.chargeAppliesTo.value === 2 && (chargeForm.controls.chargeTimeType.value === 16 || chargeForm.controls.chargeTimeType.value === 5)&&(chargeForm.controls.chargeCalculationType.value === 2)) || (chargeForm.controls.chargeAppliesTo.value === 4 && (chargeForm.controls.chargeTimeType.value==14 || chargeForm.controls.chargeTimeType.value==15) && chargeForm.controls.chargeCalculationType.value === 2)">
+            *ngIf="(chargeForm.controls.chargeAppliesTo.value === 1 && (chargeForm.controls.chargeCalculationType.value === 2 || chargeForm.controls.chargeCalculationType.value === 3 || chargeForm.controls.chargeCalculationType.value === 4 || chargeForm.controls.chargeCalculationType.value===5)) || (chargeForm.controls.chargeAppliesTo.value === 2 && (chargeForm.controls.chargeTimeType.value === 16 || chargeForm.controls.chargeTimeType.value === 5)&&(chargeForm.controls.chargeCalculationType.value === 2)) || (chargeForm.controls.chargeAppliesTo.value === 4 && (chargeForm.controls.chargeTimeType.value===14 || chargeForm.controls.chargeTimeType.value===15) && chargeForm.controls.chargeCalculationType.value === 2)">
             <mat-label>{{"labels.inputs.Minimum Charge Cap" | translate}}</mat-label>
             <input matInput autofocus formControlName="minCap">
           </mat-form-field>
           <mat-form-field fxFlex="48%"
-            *ngIf="(chargeForm.controls.chargeAppliesTo.value === 1 && (chargeForm.controls.chargeCalculationType.value === 2 || chargeForm.controls.chargeCalculationType.value === 3 || chargeForm.controls.chargeCalculationType.value === 4 || chargeForm.controls.chargeCalculationType.value==5)) || (chargeForm.controls.chargeAppliesTo.value === 2 && (chargeForm.controls.chargeTimeType.value === 16 || chargeForm.controls.chargeTimeType.value === 5)&&(chargeForm.controls.chargeCalculationType.value === 2)) || (chargeForm.controls.chargeAppliesTo.value === 4 && (chargeForm.controls.chargeTimeType.value==14 || chargeForm.controls.chargeTimeType.value==15) && chargeForm.controls.chargeCalculationType.value === 2)">
+            *ngIf="(chargeForm.controls.chargeAppliesTo.value === 1 && (chargeForm.controls.chargeCalculationType.value === 2 || chargeForm.controls.chargeCalculationType.value === 3 || chargeForm.controls.chargeCalculationType.value === 4 || chargeForm.controls.chargeCalculationType.value===5)) || (chargeForm.controls.chargeAppliesTo.value === 2 && (chargeForm.controls.chargeTimeType.value === 16 || chargeForm.controls.chargeTimeType.value === 5)&&(chargeForm.controls.chargeCalculationType.value === 2)) || (chargeForm.controls.chargeAppliesTo.value === 4 && (chargeForm.controls.chargeTimeType.value===14 || chargeForm.controls.chargeTimeType.value===15) && chargeForm.controls.chargeCalculationType.value === 2)">
             <mat-label>{{"labels.inputs.Maximum Charge Cap" | translate}}</mat-label>
             <input matInput autofocus formControlName="maxCap">
           </mat-form-field>

src/app/products/charges/view-charge/view-charge.component.html

@@ -105,20 +105,20 @@
           {{ chargeData.active === true | yesNo }}
         </div>
 
-        <div fxFlex="50%" class="mat-body-strong" *ngIf="chargeData.chargeTimeType.id == 9 && chargeData.feeFrequency">
+        <div fxFlex="50%" class="mat-body-strong" *ngIf="chargeData.chargeTimeType.id === 9 && chargeData.feeFrequency">
           {{"labels.inputs.Add Fee Frequency" | translate}}
         </div>
 
         <div fxFlex="50%"
-          *ngIf="chargeData.chargeTimeType.id == 9 && chargeData.feeFrequency && chargeData.feeFrequency">
+          *ngIf="chargeData.chargeTimeType.id === 9 && chargeData.feeFrequency && chargeData.feeFrequency">
           {{ chargeData.feeFrequency.value | translateKey:'catalogs' }}
         </div>
 
-        <div fxFlex="50%" class="mat-body-strong" *ngIf="chargeData.chargeTimeType.id == 9 && chargeData.feeInterval">
+        <div fxFlex="50%" class="mat-body-strong" *ngIf="chargeData.chargeTimeType.id === 9 && chargeData.feeInterval">
           {{"labels.inputs.Frequency Interval" | translate}}
         </div>
 
-        <div fxFlex="50%" *ngIf="chargeData.chargeTimeType.id == 9 && chargeData.feeInterval">
+        <div fxFlex="50%" *ngIf="chargeData.chargeTimeType.id === 9 && chargeData.feeInterval">
           {{ chargeData.feeInterval }}
         </div>
 

src/app/products/charges/view-charge/view-charge.component.ts

@@ -1,5 +1,5 @@
 /** Angular Imports */
-import { Component, OnInit } from '@angular/core';
+import { Component } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { ActivatedRoute, Router } from '@angular/router';
 
@@ -18,7 +18,7 @@ import { DeleteDialogComponent } from '../../../shared/delete-dialog/delete-dial
   templateUrl: './view-charge.component.html',
   styleUrls: ['./view-charge.component.scss']
 })
-export class ViewChargeComponent implements OnInit {
+export class ViewChargeComponent {
 
   /** Charge data. */
   chargeData: any;
@@ -49,9 +49,6 @@ export class ViewChargeComponent implements OnInit {
     });
   }
 
-  ngOnInit() {
-  }
-
   /**
    * Deletes the charge and redirects to charges.
    */

src/app/products/fixed-deposit-products/create-fixed-deposit-product/create-fixed-deposit-product.component.html

@@ -96,7 +96,7 @@
         [chartSlabsDisplayedColumns]="fixedDepositProductInterestRateChartStep.chartSlabsDisplayedColumns"
         [accountingRuleData]="accountingRuleData"
         [fixedDepositProduct]="fixedDepositProduct"
-        (submit)="submit()"
+        (submitEvent)="submit()"
       >
       </mifosx-fixed-deposit-product-preview-step>