From 98d17beb73bbdc1a8617d2e4b8943da1fd4fd49c Mon Sep 17 00:00:00 2001
From: Vikash Prem Sharma <vikashkumarukg977@gmail.com>
Date: Tue, 27 Feb 2024 01:30:09 +0530
Subject: [PATCH] feat: Enhance notification template for better UX

Improved notification display to address issue of a blank box when
clicking the icon. Now, a centered icon with No notification is shown
for a clearer user experience. This change enhances UI clarity and
user-friendliness.

Fix: #2005

Implemented the translation functionality
---
 .../notifications-tray/notifications-tray.component.html   | 7 +++++++
 src/assets/translations/cs-CS.json                         | 1 +
 src/assets/translations/de-DE.json                         | 1 +
 src/assets/translations/en-US.json                         | 1 +
 src/assets/translations/es-MX.json                         | 1 +
 src/assets/translations/fr-FR.json                         | 1 +
 src/assets/translations/it-IT.json                         | 1 +
 src/assets/translations/ko-KO.json                         | 1 +
 src/assets/translations/lt-LT.json                         | 1 +
 src/assets/translations/lv-LV.json                         | 1 +
 src/assets/translations/ne-NE.json                         | 1 +
 src/assets/translations/pt-PT.json                         | 1 +
 src/assets/translations/sw-SW.json                         | 1 +
 13 files changed, 19 insertions(+)

diff --git a/src/app/shared/notifications-tray/notifications-tray.component.html b/src/app/shared/notifications-tray/notifications-tray.component.html
index d263fcd8b..7e12ec19b 100644
--- a/src/app/shared/notifications-tray/notifications-tray.component.html
+++ b/src/app/shared/notifications-tray/notifications-tray.component.html
@@ -8,6 +8,13 @@
 
 <mat-menu class="mifosx-notifications-menu" #notificationsMenu="matMenu" [overlapTrigger]="false">
 
+  <div *ngIf="unreadNotifications.length === 0" fxLayout="column" fxLayoutAlign="center center" style="padding: 16px;">
+    <mat-icon style="font-size: 24px; opacity: 0.8;">
+      <span class="material-icons">notifications</span>
+    </mat-icon>
+    <p>{{ 'labels.text.No notifications' | translate }}</p>
+  </div>
+
   <button mat-menu-item class="unread" *ngFor="let notification of unreadNotifications" [routerLink]="[routeMap[notification.objectType], notification.objectId]">
     {{ notification.content }}*<br> 
     <span class="time">[{{ notification.createdAt }}]</span>
diff --git a/src/assets/translations/cs-CS.json b/src/assets/translations/cs-CS.json
index d39f32862..ab0a13ac2 100644
--- a/src/assets/translations/cs-CS.json
+++ b/src/assets/translations/cs-CS.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Nebyl nalezen žádný klient",
       "No data found": "Nenalezena žádná data",
       "No loan locked available": "Žádná půjčka není k dispozici.",
+      "No notifications": "Žádné oznámení",
       "No pending loan available for disbursal": "Není k dispozici žádná nevyřízená půjčka k vyplacení.",
       "No pending loans for approval": "Žádné půjčky čekající na schválení.",
       "No pending rescheduled loan available for this account": "Pro tento účet není k dispozici žádná nevyřízená půjčka s novým termínem splatnosti.",
diff --git a/src/assets/translations/de-DE.json b/src/assets/translations/de-DE.json
index 8b6518a29..33de38b57 100644
--- a/src/assets/translations/de-DE.json
+++ b/src/assets/translations/de-DE.json
@@ -2556,6 +2556,7 @@
       "No client was found": "Es wurde kein Kunde gefunden",
       "No data found": "Keine Daten gefunden",
       "No loan locked available": "Kein gesperrter Kredit verfügbar.",
+      "No notifications": "Keine benachrichtigungen",
       "No pending loan available for disbursal": "Kein ausstehendes Darlehen zur Auszahlung verfügbar.",
       "No pending loans for approval": "Keine ausstehenden Kredite zur Genehmigung.",
       "No pending rescheduled loan available for this account": "Für dieses Konto ist kein ausstehendes Umschuldungsdarlehen verfügbar.",
diff --git a/src/assets/translations/en-US.json b/src/assets/translations/en-US.json
index 17a4f0ee4..ded9ae1ab 100644
--- a/src/assets/translations/en-US.json
+++ b/src/assets/translations/en-US.json
@@ -2556,6 +2556,7 @@
             "No client was found": "No client was found",
             "No data found": "No data found",
             "No loan locked available": "No loan locked available.",
+            "No notifications": "No notifications",
             "No pending loan available for disbursal": "No pending loan available for disbursal.",
             "No pending loans for approval": "No pending loans for approval.",
             "No pending rescheduled loan available for this account": "No pending rescheduled loan available for this account.",
diff --git a/src/assets/translations/es-MX.json b/src/assets/translations/es-MX.json
index 081880edb..f6a691cf8 100644
--- a/src/assets/translations/es-MX.json
+++ b/src/assets/translations/es-MX.json
@@ -2557,6 +2557,7 @@
             "No client was found": "No se encontró ningún cliente",
             "No data found": "Datos no encontrados",
             "No loan locked available": "No hay Crédito bloqueado disponible.",
+            "No notifications": "Sin notificaciones",
             "No pending loan available for disbursal": "No hay Crédito pendiente disponible para desembolso.",
             "No pending loans for approval": "No hay Créditos pendientes de aprobación.",
             "No pending rescheduled loan available for this account": "No hay ningún Crédito reprogramado pendiente disponible para esta cuenta.",
diff --git a/src/assets/translations/fr-FR.json b/src/assets/translations/fr-FR.json
index 4f576c573..ab9847f07 100644
--- a/src/assets/translations/fr-FR.json
+++ b/src/assets/translations/fr-FR.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Aucun client n'a été trouvé",
       "No data found": "Aucune donnée disponible",
       "No loan locked available": "Aucun prêt bloqué disponible.",
+      "No notifications": "Pas de notifications",
       "No pending loan available for disbursal": "Aucun prêt en attente disponible pour décaissement.",
       "No pending loans for approval": "Aucun prêt en attente d'approbation.",
       "No pending rescheduled loan available for this account": "Aucun prêt rééchelonné en attente disponible pour ce compte.",
diff --git a/src/assets/translations/it-IT.json b/src/assets/translations/it-IT.json
index 8b174fafd..f0585cbcb 100644
--- a/src/assets/translations/it-IT.json
+++ b/src/assets/translations/it-IT.json
@@ -2558,6 +2558,7 @@
       "No data found": "Nessun dato trovato",
       "No loan locked available": "Nessun prestito bloccato disponibile.",
       "No pending loan available for disbursal": "Nessun prestito pendente disponibile per l'erogazione.",
+      "No notifications": "Nessuna notifica",
       "No pending loans for approval": "Nessun prestito in attesa di approvazione.",
       "No pending rescheduled loan available for this account": "Nessun prestito riprogrammato in sospeso disponibile per questo account.",
       "No repayments and disbursal": "Non sono disponibili rimborsi ed esborsi per il cliente selezionato e la data della riunione",
diff --git a/src/assets/translations/ko-KO.json b/src/assets/translations/ko-KO.json
index 8e89d633f..a24fe901d 100644
--- a/src/assets/translations/ko-KO.json
+++ b/src/assets/translations/ko-KO.json
@@ -2557,6 +2557,7 @@
       "No client was found": "클라이언트를 찾을 수 없습니다.",
       "No data found": "데이터가 없습니다",
       "No loan locked available": "잠긴 대출이 없습니다.",
+      "No notifications": "알림 없음",
       "No pending loan available for disbursal": "지급 가능한 보류 중인 대출이 없습니다.",
       "No pending loans for approval": "승인을 위해 보류 중인 대출이 없습니다.",
       "No pending rescheduled loan available for this account": "이 계좌에는 보류 중인 재예약 대출이 없습니다.",
diff --git a/src/assets/translations/lt-LT.json b/src/assets/translations/lt-LT.json
index 918bf88c2..214715ada 100644
--- a/src/assets/translations/lt-LT.json
+++ b/src/assets/translations/lt-LT.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Klientas nerastas",
       "No data found": "Duomenų nerasta",
       "No loan locked available": "Nėra užblokuotos paskolos.",
+      "No notifications": "Nėra pranešimų",
       "No pending loan available for disbursal": "Nėra laukiamos paskolos, kurią būtų galima išmokėti.",
       "No pending loans for approval": "Nėra laukiančių patvirtinti paskolų.",
       "No pending rescheduled loan available for this account": "Šioje paskyroje nėra laukiamos perkeltos paskolos.",
diff --git a/src/assets/translations/lv-LV.json b/src/assets/translations/lv-LV.json
index a9c4741aa..381cfdd82 100644
--- a/src/assets/translations/lv-LV.json
+++ b/src/assets/translations/lv-LV.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Klients netika atrasts",
       "No data found": "Dati nav atrasti",
       "No loan locked available": "Nav pieejams bloķēts aizdevums.",
+      "No notifications": "Nav paziņojumu",
       "No pending loan available for disbursal": "Nav pieejams neizmaksāts aizdevums.",
       "No pending loans for approval": "Nav vēl neapstiprinātu aizdevumu apstiprināšanai.",
       "No pending rescheduled loan available for this account": "Šim kontam nav pieejams neviens neapstiprināts pārplānots aizdevums.",
diff --git a/src/assets/translations/ne-NE.json b/src/assets/translations/ne-NE.json
index d0e7039d9..645285d13 100644
--- a/src/assets/translations/ne-NE.json
+++ b/src/assets/translations/ne-NE.json
@@ -2557,6 +2557,7 @@
       "No client was found": "कुनै ग्राहक भेटिएन",
       "No data found": "कुनै डाटा फेला परेन",
       "No loan locked available": "कुनै ऋण उपलब्ध छैन।",
+      "No notifications": "कुनै सूचना छैन",
       "No pending loan available for disbursal": "वितरणको लागि कुनै पेन्डिङ ऋण उपलब्ध छैन।",
       "No pending loans for approval": "स्वीकृतिको लागि कुनै पेन्डिङ ऋण छैन।",
       "No pending rescheduled loan available for this account": "यस खाताको लागि कुनै पेन्डिङ पुन: निर्धारित ऋण उपलब्ध छैन।",
diff --git a/src/assets/translations/pt-PT.json b/src/assets/translations/pt-PT.json
index f2284e67a..ad24e51bd 100644
--- a/src/assets/translations/pt-PT.json
+++ b/src/assets/translations/pt-PT.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Nenhum cliente foi encontrado",
       "No data found": "Nenhum dado encontrado",
       "No loan locked available": "Nenhum empréstimo bloqueado disponível.",
+      "No notifications": "Sem notificações",
       "No pending loan available for disbursal": "Nenhum empréstimo pendente disponível para desembolso.",
       "No pending loans for approval": "Não há empréstimos pendentes para aprovação.",
       "No pending rescheduled loan available for this account": "Nenhum empréstimo reescalonado pendente disponível para esta conta.",
diff --git a/src/assets/translations/sw-SW.json b/src/assets/translations/sw-SW.json
index 6c8c197f1..94b2ff2e1 100644
--- a/src/assets/translations/sw-SW.json
+++ b/src/assets/translations/sw-SW.json
@@ -2557,6 +2557,7 @@
       "No client was found": "Hakuna mteja aliyepatikana",
       "No data found": "Hakuna data iliyopatikana",
       "No loan locked available": "Hakuna mkopo uliofungwa unaopatikana.",
+      "No notifications": "Hakuna arifa",
       "No pending loan available for disbursal": "Hakuna mkopo unaosubiri kulipwa.",
       "No pending loans for approval": "Hakuna mikopo inayosubiri kupitishwa.",
       "No pending rescheduled loan available for this account": "Hakuna mkopo unaosubiri kuratibiwa tena unaopatikana kwa akaunti hii.",