From ae38f2f5ee01e74d628dbb625d3396d76de4ac0e Mon Sep 17 00:00:00 2001 From: Jose Alberto Hernandez Date: Wed, 3 Sep 2025 05:53:36 -0500 Subject: [PATCH] WEB-290: Introduce classification field on loan BuyDown Fee transaction (#2618) Co-authored-by: Jose Alberto Hernandez Merging based on review from Adam and Rustam. --- .../make-repayment/make-repayment.component.html | 2 +- .../make-repayment/make-repayment.component.ts | 4 +++- .../transactions-tab/transactions-tab.component.ts | 1 + .../view-transaction/view-transaction.component.html | 2 +- .../external-identifier/external-identifier.component.html | 2 +- src/assets/styles/_text.scss | 5 +++++ 6 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.html b/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.html index a7332a91a..50f521bae 100644 --- a/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.html +++ b/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.html @@ -68,7 +68,7 @@ - + {{ 'labels.inputs.Classification' | translate }} diff --git a/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts b/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts index 8cbd1541d..d19035350 100644 --- a/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts +++ b/src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts @@ -104,7 +104,6 @@ export class MakeRepaymentComponent implements OnInit { Validators.min(0.001), Validators.max(this.dataObject.amount)]) ); - this.repaymentLoanForm.addControl('classificationId', new UntypedFormControl('')); } else { this.repaymentLoanForm.addControl( 'transactionAmount', @@ -113,6 +112,9 @@ export class MakeRepaymentComponent implements OnInit { Validators.min(0.001)]) ); } + if (this.isCapitalizedIncome() || this.isBuyDownFee()) { + this.repaymentLoanForm.addControl('classificationId', new UntypedFormControl('')); + } } setRepaymentLoanDetails() { diff --git a/src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts b/src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts index e5e61c846..aabcbf988 100644 --- a/src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts +++ b/src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts @@ -263,6 +263,7 @@ export class TransactionsTabComponent implements OnInit { 29, 30, 31, + 32, 33, 35, 37, diff --git a/src/app/loans/loans-view/transactions/view-transaction/view-transaction.component.html b/src/app/loans/loans-view/transactions/view-transaction/view-transaction.component.html index f1d50ce24..e0e80ef22 100644 --- a/src/app/loans/loans-view/transactions/view-transaction/view-transaction.component.html +++ b/src/app/loans/loans-view/transactions/view-transaction/view-transaction.component.html @@ -86,7 +86,7 @@ {{ 'Classification' | translateKey: 'catalogs' }} -
+
{{ transactionData.classification.name }}
diff --git a/src/app/shared/external-identifier/external-identifier.component.html b/src/app/shared/external-identifier/external-identifier.component.html index 8eb86eced..55899e321 100644 --- a/src/app/shared/external-identifier/external-identifier.component.html +++ b/src/app/shared/external-identifier/external-identifier.component.html @@ -6,7 +6,7 @@ > {{ externalId | externalIdentifier }} - {{ externalId }} + {{ externalId }} diff --git a/src/assets/styles/_text.scss b/src/assets/styles/_text.scss index 70360c479..c9dc45fa1 100644 --- a/src/assets/styles/_text.scss +++ b/src/assets/styles/_text.scss @@ -250,3 +250,8 @@ body { .label-field { margin-top: 32px; } + +.wrap-content { + overflow-wrap: break-word; + word-wrap: break-word; +}