feat: non-individual entity UI improvements — hide individual-only sections, fix legal form display, send extended fields to API

- Hide Family Members tab/section for non-individual entities in client view, create flow, and preview
- Hide Financial & Classification section for non-individual entities in personal data and preview
- Fix legal form column in clients list — fetch legalForm from client API for correct display
- Add person/business icon before client name in list rows
- Remove unsupportedNpd filter — send authorizedSignatory, additionalInfo, dateOfRegistration to API
- Add registration number format hint (mat-hint) based on constitution type
- Add spacing between verification row and constitution type dropdowns
- Reduce table cell padding and prevent action buttons from being clipped
- Add missing MPL-2.0 license headers

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Aditya
2026-04-04 15:10:51 +05:30
co-authored by Claude Opus 4.6
parent ab01111424
commit b890d24bb7
522 changed files with 51991 additions and 21885 deletions
@@ -6,134 +6,100 @@
file, You can obtain one at http://mozilla.org/MPL/2.0/.
-->
<div class="tab-container mat-typography">
<div class="layout-row align-start">
<div class="m-b-10">
<h3>{{ 'labels.heading.Identities' | translate }}</h3>
</div>
<div class="action-button m-b-10 gap-25px">
<button
mat-raised-button
color="primary"
(click)="addIdentifier()"
*mifosxHasPermission="'CREATE_CLIENTIDENTIFIER'"
>
<fa-icon icon="plus" class="m-r-10"></fa-icon>
{{ 'labels.buttons.Add' | translate }}
</button>
<div class="idt-container">
<!-- Header -->
<div class="idt-header">
<div class="idt-header__left">
<i class="fa fa-id-card idt-header__icon"></i>
<h3 class="idt-header__title">{{ 'labels.heading.Identities' | translate }}</h3>
<span class="idt-header__badge">{{ clientIdentities?.length || 0 }}</span>
</div>
<button mat-flat-button color="primary" class="idt-header__btn" (click)="addIdentifier()" *mifosxHasPermission="'CREATE_CLIENTIDENTIFIER'">
<fa-icon icon="plus" class="m-r-10"></fa-icon>{{ 'labels.buttons.Add' | translate }}
</button>
</div>
<table mat-table #identifiersTable [dataSource]="clientIdentities" [ngStyle]="{ 'margin-top': '3%' }">
<ng-container matColumnDef="id">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Id' | translate }}</th>
<td mat-cell *matCellDef="let identity">{{ identity.id }}</td>
</ng-container>
<!-- Empty State -->
@if (!clientIdentities || clientIdentities.length === 0) {
<div class="idt-empty">
<i class="fa fa-id-badge idt-empty__icon"></i>
<p class="idt-empty__text">{{ 'labels.messages.No Identities Available' | translate }}</p>
</div>
}
<ng-container matColumnDef="type">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Type' | translate }}</th>
<td mat-cell *matCellDef="let identity">{{ identity.documentType.name }}</td>
</ng-container>
<ng-container matColumnDef="documentKey">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Document Key' | translate }}</th>
<td mat-cell *matCellDef="let identity">{{ identity.documentKey }}</td>
</ng-container>
<ng-container matColumnDef="description">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Description' | translate }}</th>
<td mat-cell *matCellDef="let identity">{{ identity.description }}</td>
</ng-container>
<ng-container matColumnDef="documents">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Identity Documents' | translate }}</th>
<td mat-cell *matCellDef="let identity">
@if (identity.documents?.length) {
<div class="document-grid">
@for (document of identity.documents; track trackByDocumentId($index, document)) {
<div class="document-card">
<div
class="thumb"
[class.clickable]="isPreviewable(document)"
role="button"
tabindex="0"
[attr.aria-label]="('labels.buttons.Preview' | translate) + ': ' + document.name"
(keydown.enter)="isPreviewable(document) && openDocumentPreview(identity, document)"
(keydown.space)="isPreviewable(document) && openDocumentPreview(identity, document)"
(click)="isPreviewable(document) && openDocumentPreview(identity, document)"
>
@if (previewThumbnails[document.id]) {
<img
[src]="previewThumbnails[document.id]"
[alt]="document.name"
[title]="document.name"
loading="lazy"
/>
} @else {
<div class="placeholder">
<fa-icon icon="file"></fa-icon>
<span>{{ document.fileName || document.name }}</span>
</div>
}
@if (isPreviewable(document)) {
<div class="preview-overlay">
<fa-icon icon="eye"></fa-icon>
</div>
}
</div>
<div class="card-body">
<div class="title">{{ document.name }}</div>
@if (document.fileName) {
<div class="meta">{{ document.fileName }}</div>
}
</div>
</div>
}
</div>
} @else {
<span class="muted">{{ 'labels.text.NoDocuments' | translate }}</span>
}
</td>
</ng-container>
<ng-container matColumnDef="status">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Status' | translate }}</th>
<td mat-cell *matCellDef="let identity">
{{ identity.status === 'clientIdentifierStatusType.active' ? 'active' : 'inactive' }}
</td>
</ng-container>
<ng-container matColumnDef="actions">
<th mat-header-cell *matHeaderCellDef>{{ 'labels.inputs.Actions' | translate }}</th>
<td mat-cell *matCellDef="let identity; let i = index">
<button
class="identity-action-button"
mat-raised-button
color="warn"
[title]="'labels.buttons.Delete' | translate"
[attr.aria-label]="'labels.buttons.Delete' | translate"
(click)="deleteIdentifier(identity.clientId, identity.id, i)"
*mifosxHasPermission="'DELETE_CLIENTIDENTIFIER'"
>
<fa-icon icon="times"></fa-icon>
</button>
</td>
</ng-container>
<ng-container matColumnDef="no-data">
<td mat-footer-cell *matFooterCellDef [attr.colspan]="identitiesColumns.length">
<div class="table-empty-state">
<p>{{ 'labels.messages.No Identities Available' | translate }}</p>
<!-- Identity Cards -->
@for (identity of clientIdentities; track identity.id; let i = $index) {
<div class="idt-card">
<!-- Card Header -->
<div class="idt-card__header">
<div class="idt-card__title">
<i class="fa fa-file-text idt-card__type-icon"></i>
<span class="idt-card__type">{{ identity.documentType?.name }}</span>
<span class="idt-card__status" [class.idt-card__status--active]="identity.status === 'clientIdentifierStatusType.active'" [class.idt-card__status--inactive]="identity.status !== 'clientIdentifierStatusType.active'">
{{ identity.status === 'clientIdentifierStatusType.active' ? 'Active' : 'Inactive' }}
</span>
</div>
</td>
</ng-container>
<button mat-stroked-button color="warn" class="idt-card__delete" (click)="deleteIdentifier(identity.clientId, identity.id, i)" *mifosxHasPermission="'DELETE_CLIENTIDENTIFIER'">
<i class="fa fa-trash"></i>
</button>
</div>
<tr mat-header-row *matHeaderRowDef="identitiesColumns"></tr>
<tr mat-row *matRowDef="let row; columns: identitiesColumns"></tr>
@if (clientIdentities?.length === 0) {
<tr mat-footer-row *matFooterRowDef="['no-data']"></tr>
}
</table>
<!-- Card Body -->
<div class="idt-card__body">
<div class="idt-grid">
<div class="idt-field">
<div class="idt-field__label">{{ 'labels.inputs.Id' | translate }}</div>
<div class="idt-field__value idt-field__value--mono">{{ identity.id }}</div>
</div>
<div class="idt-field">
<div class="idt-field__label">{{ 'labels.inputs.Document Key' | translate }}</div>
<div class="idt-field__value idt-field__value--mono">{{ identity.documentKey }}</div>
</div>
@if (identity.description) {
<div class="idt-field">
<div class="idt-field__label">{{ 'labels.inputs.Description' | translate }}</div>
<div class="idt-field__value">{{ identity.description }}</div>
</div>
}
</div>
<!-- Documents -->
@if (identity.documents?.length) {
<div class="idt-docs">
<div class="idt-docs__title">
<i class="fa fa-paperclip"></i> {{ 'labels.inputs.Identity Documents' | translate }}
</div>
<div class="idt-docs__grid">
@for (document of identity.documents; track trackByDocumentId($index, document)) {
<div class="idt-doc" [class.idt-doc--clickable]="isPreviewable(document)"
(click)="isPreviewable(document) && openDocumentPreview(identity, document)"
(keydown.enter)="isPreviewable(document) && openDocumentPreview(identity, document)"
tabindex="0" role="button"
[attr.aria-label]="('labels.buttons.Preview' | translate) + ': ' + document.name">
@if (previewThumbnails[document.id]) {
<img [src]="previewThumbnails[document.id]" [alt]="document.name" class="idt-doc__thumb" loading="lazy" />
} @else {
<div class="idt-doc__placeholder">
<i class="fa fa-file-o"></i>
</div>
}
<div class="idt-doc__info">
<span class="idt-doc__name">{{ document.name }}</span>
@if (document.fileName) {
<span class="idt-doc__file">{{ document.fileName }}</span>
}
</div>
@if (isPreviewable(document)) {
<i class="fa fa-eye idt-doc__preview"></i>
}
</div>
}
</div>
</div>
}
</div>
</div>
}
</div>
<div #identityLightbox class="document-lightbox-host"></div>
@@ -6,142 +6,283 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
@use '../../../../assets/styles/colours' as *;
$primary: #1a73e8;
$primary-light: #e8f0fe;
$gray-50: #f8f9fa;
$gray-100: #f1f3f4;
$gray-200: #e8eaed;
$gray-500: #9aa0a6;
$gray-700: #5f6368;
$gray-900: #202124;
$white: #fff;
$green: #34a853;
$green-light: #e6f4ea;
$red: #ea4335;
$red-light: #fce8e6;
.tab-container {
padding: 1rem;
margin: 1rem 0;
.idt-container {
padding: 20px 24px;
}
.action-button {
margin-left: auto;
// Header
.idt-header {
display: flex;
align-items: center;
justify-content: space-between;
margin-bottom: 16px;
&__left {
display: flex;
align-items: center;
gap: 10px;
}
h3 {
&__icon { font-size: 16px; color: $primary; }
&__title {
margin: 0;
font-size: 16px;
font-weight: 600;
color: $gray-900;
}
table {
width: 100%;
&__badge {
background: $primary-light;
color: $primary;
font-size: 11px;
font-weight: 700;
padding: 2px 8px;
border-radius: 10px;
}
.identity-action-button {
min-width: 26px;
padding: 0 6px;
margin: 4px;
line-height: 25px;
&__btn {
border-radius: 8px !important;
font-size: 13px !important;
font-weight: 600 !important;
height: 36px !important;
}
}
// Empty
.idt-empty {
text-align: center;
padding: 40px 20px;
background: $gray-50;
border-radius: 10px;
border: 1px dashed $gray-200;
&__icon { font-size: 32px; color: $gray-500; margin-bottom: 8px; }
&__text { color: $gray-500; font-size: 13px; margin: 0; }
}
// Identity Card
.idt-card {
background: $white;
border: 1px solid $gray-200;
border-radius: 8px;
overflow: hidden;
margin-bottom: 12px;
&__header {
display: flex;
align-items: center;
justify-content: space-between;
padding: 12px 18px;
background: $gray-50;
border-bottom: 1px solid $gray-200;
}
&__title {
display: flex;
align-items: center;
gap: 10px;
}
&__type-icon {
font-size: 14px;
color: $primary;
width: 28px;
height: 28px;
display: flex;
align-items: center;
justify-content: center;
background: $primary-light;
border-radius: 6px;
}
&__type {
font-size: 14px;
font-weight: 600;
color: $gray-900;
}
&__status {
font-size: 10px;
font-weight: 600;
padding: 2px 9px;
border-radius: 10px;
&--active { background: $green-light; color: $green; }
&--inactive { background: $red-light; color: $red; }
}
&__delete {
width: 30px !important;
height: 30px !important;
min-width: 30px !important;
padding: 0 !important;
border-radius: 6px !important;
border-color: $gray-200 !important;
color: $gray-500 !important;
&:hover { color: $red !important; border-color: $red !important; background: $red-light !important; }
i { font-size: 12px; }
}
&__body {
padding: 14px 18px;
}
}
// Details grid
.idt-grid {
display: grid;
grid-template-columns: repeat(3, 1fr);
gap: 0;
border: 1px solid $gray-100;
border-radius: 6px;
overflow: hidden;
@media (max-width: 600px) { grid-template-columns: 1fr; }
}
.idt-field {
padding: 8px 12px;
border-bottom: 1px solid $gray-100;
border-right: 1px solid $gray-100;
&:nth-child(3n) { border-right: none; }
&:hover { background: $gray-50; }
&__label {
font-size: 9px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.5px;
color: $gray-500;
margin-bottom: 2px;
}
&__value {
font-size: 13px;
font-weight: 500;
color: $gray-900;
&--mono {
font-family: 'SF Mono', 'Cascadia Code', 'Consolas', monospace;
font-size: 12px;
letter-spacing: 0.3px;
}
}
}
.document-grid {
display: flex;
flex-wrap: wrap;
gap: 0.75rem;
}
// Documents section
.idt-docs {
margin-top: 12px;
.document-card {
width: 200px;
background: $white;
border: 1px solid $silver;
border-radius: 4px;
overflow: hidden;
box-shadow: 0 1px 4px rgba($dark-grey, 0.12);
display: flex;
flex-direction: column;
&__title {
font-size: 10px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.5px;
color: $gray-500;
margin-bottom: 8px;
&:hover {
box-shadow: 0 4px 12px rgba($dark-grey, 0.14);
i { color: $primary; margin-right: 4px; }
}
&__grid {
display: flex;
gap: 8px;
flex-wrap: wrap;
}
}
.thumb {
position: relative;
background: $clouds;
min-height: 7.5rem;
.idt-doc {
display: flex;
align-items: center;
justify-content: center;
cursor: default;
gap: 10px;
padding: 8px 12px;
background: $gray-50;
border: 1px solid $gray-100;
border-radius: 6px;
transition: all 0.12s;
min-width: 180px;
&.clickable {
&--clickable {
cursor: pointer;
&:hover {
border-color: $primary;
background: $primary-light;
}
}
img {
width: 100%;
height: 100%;
&__thumb {
width: 36px;
height: 36px;
border-radius: 4px;
object-fit: cover;
}
}
.preview-overlay {
position: absolute;
bottom: 0.5rem;
right: 0.5rem;
background: rgba($white, 0.9);
border-radius: 50%;
padding: 0.4rem;
color: $peter-river;
display: flex;
align-items: center;
justify-content: center;
opacity: 0;
transition: opacity 0.2s ease;
.thumb:hover &,
.thumb:focus & {
opacity: 1;
}
}
.placeholder {
color: $light-grey;
text-align: center;
padding: 0.75rem;
display: flex;
flex-direction: column;
gap: 0.4rem;
align-items: center;
justify-content: center;
fa-icon {
font-size: 1.125rem;
border: 1px solid $gray-200;
}
span {
font-size: 0.75rem;
line-height: 1.2;
&__placeholder {
width: 36px;
height: 36px;
display: flex;
align-items: center;
justify-content: center;
background: $gray-200;
border-radius: 4px;
color: $gray-500;
font-size: 14px;
}
&__info {
display: flex;
flex-direction: column;
min-width: 0;
}
&__name {
font-size: 12px;
font-weight: 600;
color: $gray-900;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 150px;
}
&__file {
font-size: 10px;
color: $gray-500;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 150px;
}
&__preview {
font-size: 12px;
color: $primary;
margin-left: auto;
opacity: 0;
transition: opacity 0.15s;
}
&:hover .idt-doc__preview { opacity: 1; }
}
.preview-btn {
position: absolute;
right: 0.5rem;
bottom: 0.5rem;
background: rgba($black, 0.65);
color: $white;
}
.card-body {
padding: 0.625rem 0.75rem 0.75rem;
display: flex;
flex-direction: column;
gap: 0.25rem;
}
.title {
font-weight: 700;
color: $dark-grey;
}
.meta {
font-size: 0.75rem;
color: $asbestos;
}
.muted {
color: $concrete;
}
.document-lightbox-host {
display: none;
}
.document-lightbox-host { display: none; }
@@ -97,8 +97,7 @@ export class IdentitiesTabComponent implements OnDestroy {
'actions'
];
/** Identifiers Table */
@ViewChild('identifiersTable', { static: true }) identifiersTable: MatTable<Element>;
/** (table removed — card layout now) */
/** LightGallery host */
@ViewChild('identityLightbox', { static: true }) identityLightbox: ElementRef<HTMLElement>;
@@ -215,20 +214,20 @@ export class IdentitiesTabComponent implements OnDestroy {
};
newIdentity.documents.push(newDoc);
this.clientIdentities.push(newIdentity);
this.identifiersTable.renderRows();
// Array mutation triggers @for re-render
this.setThumbnail(newDoc);
},
error: (err: any) => {
console.error('Failed to upload document', err);
// Still add the identifier even if document upload fails
this.clientIdentities.push(newIdentity);
this.identifiersTable.renderRows();
// Array mutation triggers @for re-render
}
});
} else {
// No file, just add the identifier
this.clientIdentities.push(newIdentity);
this.identifiersTable.renderRows();
// Array mutation triggers @for re-render
}
},
error: (err: any) => {
@@ -253,7 +252,7 @@ export class IdentitiesTabComponent implements OnDestroy {
if (response.delete) {
this.clientService.deleteClientIdentifier(clientId, identifierId).subscribe((res) => {
this.clientIdentities.splice(index, 1);
this.identifiersTable.renderRows();
// Array mutation triggers @for re-render
});
}
});