From bb26080c072f1b42b9cd9747f3251dacfa0ea934 Mon Sep 17 00:00:00 2001
From: Soni Jay <jaygsoni14@gmail.com>
Date: Mon, 12 Jan 2026 00:06:01 +0530
Subject: [PATCH] WEB-568 Negative Values Allowed for Arrears Ageing, Overdue
 Days for NPA, and Principal Threshold Fields in Loan Product Settings (#2983)

---
 .../loan-product-settings-step.component.html     |  6 +++---
 .../loan-product-settings-step.component.ts       | 15 ++++++++++++---
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
index 306b926f2..963a99f8c 100644
--- a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
+++ b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
@@ -384,7 +384,7 @@
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.On arrears ageing' | translate }}</mat-label>
-      <input type="number" matInput formControlName="graceOnArrearsAgeing" />
+      <input type="number" min="0" matInput formControlName="graceOnArrearsAgeing" />
     </mat-form-field>
 
     <h4 class="flex-48">
@@ -400,7 +400,7 @@
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Overdue days for NPA' | translate }}</mat-label>
-      <input type="number" matInput formControlName="overdueDaysForNPA" />
+      <input type="number" min="0" matInput formControlName="overdueDaysForNPA" />
     </mat-form-field>
 
     <mat-checkbox
@@ -413,7 +413,7 @@
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Principal Threshold (%) for Last Instalment' | translate }}</mat-label>
-      <input type="number" matInput formControlName="principalThresholdForLastInstallment" />
+      <input type="number" min="0" matInput formControlName="principalThresholdForLastInstallment" />
     </mat-form-field>
 
     <mat-checkbox
diff --git a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
index cd112d3b8..b784d5a32 100644
--- a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
+++ b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
@@ -325,10 +325,19 @@ export class LoanProductSettingsStepComponent implements OnInit {
         Validators.required
       ],
       canDefineInstallmentAmount: [false],
-      graceOnArrearsAgeing: [''],
-      overdueDaysForNPA: [''],
+      graceOnArrearsAgeing: [
+        '',
+        [Validators.min(0)]
+      ],
+      overdueDaysForNPA: [
+        '',
+        [Validators.min(0)]
+      ],
       accountMovesOutOfNPAOnlyOnArrearsCompletion: [false],
-      principalThresholdForLastInstallment: [''],
+      principalThresholdForLastInstallment: [
+        '',
+        [Validators.min(0)]
+      ],
       allowVariableInstallments: [false],
       disallowExpectedDisbursements: [false],
       canUseForTopup: [false],