CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

WEB-466 Number of Repayments Field Allows Zero and Negative Values in Loan Product Creation Form (#2889)

Browse Source
This commit is contained in:
Soni Jay
2025-12-12 16:03:51 -06:00
committed by GitHub
parent da291c4ef9
commit c64f8c5546
2 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/products/loan-products/loan-product-stepper/loan-product-terms-step/loan-product-terms-step.component.html
+5 -5
View File
@@ -96,13 +96,13 @@
<input type="number" matInput formControlName="minNumberOfRepayments" [min]="1" /> <input type="number" matInput formControlName="minNumberOfRepayments" [min]="1" />
<mat-error> <mat-error>
{{ 'labels.commons.Minimum Value must be' | translate }} {{ 'labels.commons.Minimum Value must be' | translate }}
<strong>{{ 'labels.commons.greater equal to than 0' | translate }}</strong> <strong>1</strong>
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
<mat-form-field class="flex-31"> <mat-form-field class="flex-31">
<mat-label>{{ 'labels.inputs.Default' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Default' | translate }}</mat-label>
<input type="number" matInput formControlName="numberOfRepayments" required /> <input type="number" matInput formControlName="numberOfRepayments" required [min]="1" />
<mat-error> <mat-error>
{{ 'labels.catalogs.Default' | translate }} {{ 'labels.inputs.Number of repayments' | translate }} {{ 'labels.catalogs.Default' | translate }} {{ 'labels.inputs.Number of repayments' | translate }}
{{ 'labels.commons.is' | translate }} {{ 'labels.commons.is' | translate }}
@@ -112,12 +112,12 @@
<mat-form-field class="flex-31"> <mat-form-field class="flex-31">
<mat-label>{{ 'labels.inputs.Maximum' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Maximum' | translate }}</mat-label>
<input type="number" matInput formControlName="maxNumberOfRepayments" [min]="0" /> <input type="number" matInput formControlName="maxNumberOfRepayments" [min]="1" />
<mat-error> <mat-error>
{{ 'labels.commons.Maximum Value must be' | translate }} {{ 'labels.commons.Maximum Value must be' | translate }}
<strong>{{ 'labels.commons.greater equal to than 0' | translate }}</strong> <strong>1</strong>
{{ 'labels.commons.and must be greater than' | translate }} {{ 'labels.commons.and must be greater than' | translate }}
<strong>{{ 'labels.commons.Minimum Principal' | translate }}</strong> <strong>{{ 'labels.inputs.Minimum' | translate }}</strong>
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
src/app/products/loan-products/loan-product-stepper/loan-product-terms-step/loan-product-terms-step.component.ts
+16 -3
View File
@@ -194,12 +194,25 @@ export class LoanProductTermsStepComponent implements OnInit, OnChanges {
Validators.required Validators.required
], ],
maxPrincipal: [''], maxPrincipal: [''],
minNumberOfRepayments: [''], minNumberOfRepayments: [
'',
[
Validators.pattern('^[1-9]\\d*$')
]
],
numberOfRepayments: [ numberOfRepayments: [
'', '',
Validators.required [
Validators.required,
Validators.pattern('^[1-9]\\d*$')
]
],
maxNumberOfRepayments: [
'',
[
Validators.pattern('^[1-9]\\d*$')
]
], ],
maxNumberOfRepayments: [''],
isLinkedToFloatingInterestRates: [false], isLinkedToFloatingInterestRates: [false],
allowApprovedDisbursedAmountsOverApplied: [false], allowApprovedDisbursedAmountsOverApplied: [false],
overAppliedCalculationType: [{ value: null, disabled: true }], overAppliedCalculationType: [{ value: null, disabled: true }],