From a4f11554049f934197dba5fb75ada5c6f3bad1aa Mon Sep 17 00:00:00 2001 From: Jose Alberto Hernandez Date: Mon, 16 Jun 2025 13:15:46 -0500 Subject: [PATCH] fix: Display issues --- .../identities-tab.component.html | 6 +- ...ct-interest-rate-chart-step.component.html | 22 +- ...ct-interest-rate-chart-step.component.html | 35 +-- ...saving-product-preview-step.component.html | 111 ++++---- .../saving-product-preview-step.component.ts | 5 +- .../saving-product-general-tab.component.html | 8 +- ...-savings-accounting-details.component.html | 236 ++++++++++-------- .../input-password.component.html | 2 +- 8 files changed, 223 insertions(+), 202 deletions(-) diff --git a/src/app/clients/clients-view/identities-tab/identities-tab.component.html b/src/app/clients/clients-view/identities-tab/identities-tab.component.html index 52e9bea67..46c3e5b4a 100644 --- a/src/app/clients/clients-view/identities-tab/identities-tab.component.html +++ b/src/app/clients/clients-view/identities-tab/identities-tab.component.html @@ -1,9 +1,7 @@
-
-

- {{ 'labels.heading.Identities' | translate }} -

+

{{ 'labels.heading.Identities' | translate }}

+
- + {{ 'labels.inputs.Name' | translate }} - + + {{ 'labels.inputs.Description' | translate }} + + + + {{ 'labels.inputs.From Date' | translate }} - + {{ 'labels.inputs.End Date' | translate }} - - {{ 'labels.inputs.Description' | translate }} - - - -
+
{{ 'labels.inputs.Is primary grouping by amount?' | translate }} diff --git a/src/app/products/recurring-deposit-products/recurring-deposit-product-stepper/recurring-deposit-product-interest-rate-chart-step/recurring-deposit-product-interest-rate-chart-step.component.html b/src/app/products/recurring-deposit-products/recurring-deposit-product-stepper/recurring-deposit-product-interest-rate-chart-step/recurring-deposit-product-interest-rate-chart-step.component.html index 746539e11..d8b41391c 100644 --- a/src/app/products/recurring-deposit-products/recurring-deposit-product-stepper/recurring-deposit-product-interest-rate-chart-step/recurring-deposit-product-interest-rate-chart-step.component.html +++ b/src/app/products/recurring-deposit-products/recurring-deposit-product-stepper/recurring-deposit-product-interest-rate-chart-step/recurring-deposit-product-interest-rate-chart-step.component.html @@ -16,8 +16,8 @@ > -
-
+
+
- + {{ 'labels.inputs.Name' | translate }} - + - - {{ 'labels.inputs.Start Date' | translate }} + + {{ 'labels.inputs.Description' | translate }} + + + + + {{ 'labels.inputs.From Date' | translate }} - {{ 'labels.inputs.Start Date' | translate }} {{ 'labels.commons.is' | translate }} + {{ 'labels.inputs.From Date' | translate }} {{ 'labels.commons.is' | translate }} {{ 'labels.commons.required' | translate }} - + {{ 'labels.inputs.End Date' | translate }} - - {{ 'labels.inputs.Description' | translate }} - - -
{{ 'labels.inputs.Is primary grouping by amount?' | translate }} diff --git a/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.html b/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.html index 754c7e4db..4f5f93e8a 100644 --- a/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.html +++ b/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.html @@ -1,49 +1,49 @@
-

{{ savingProduct.name }}

+

{{ savingProduct.name }}

- -

{{ 'labels.inputs.Details' | translate }}

+ +

{{ 'labels.inputs.Details' | translate }}

- -
+ +
{{ 'labels.inputs.Short Name' | translate }}: {{ savingProduct.shortName }}
-
+
{{ 'labels.inputs.Description' | translate }}: {{ savingProduct.description }}
-

{{ 'labels.inputs.Currency' | translate }}

+

{{ 'labels.inputs.Currency' | translate }}

- -
+ +
{{ 'labels.inputs.Currency' | translate }}: {{ savingProduct.currencyCode | find: savingProductsTemplate.currencyOptions : 'code' : 'name' }}
-
+
{{ 'labels.inputs.Decimal Places' | translate }}: {{ savingProduct.digitsAfterDecimal }}
-
+
{{ 'labels.inputs.Currency in multiples of' | translate }}: {{ savingProduct.inMultiplesOf }}
-

{{ 'labels.inputs.Terms' | translate }}

+

{{ 'labels.inputs.Terms' | translate }}

- -
+ +
{{ 'labels.inputs.Nominal Annual Interest' | translate }}: {{ savingProduct.nominalAnnualInterestRate | formatNumber }} %
-
+
{{ 'labels.inputs.Interest Compounding Period' | translate }}: {{ savingProduct.interestCompoundingPeriodType @@ -52,7 +52,7 @@ }}
-
+
{{ 'labels.inputs.Interest Posting Period' | translate }}: {{ savingProduct.interestPostingPeriodType @@ -61,7 +61,7 @@ }}
-
+
{{ 'labels.inputs.Interest Calculated using' | translate }}: {{ savingProduct.interestCalculationType @@ -70,7 +70,7 @@ }}
-
+
{{ 'labels.inputs.Days in Year' | translate }}: {{ savingProduct.interestCalculationDaysInYearType @@ -79,15 +79,15 @@ }}
-

{{ 'labels.inputs.Settings' | translate }}

+

{{ 'labels.inputs.Settings' | translate }}

- -
+ +
{{ 'labels.inputs.Minimum Opening Balance' | translate }}: {{ savingProduct.minRequiredOpeningBalance | formatNumber }}
-
+
{{ 'labels.inputs.Lock-in Period' | translate }}: {{ savingProduct.lockinPeriodFrequency + @@ -97,64 +97,64 @@ }}
-
+
{{ 'labels.inputs.Apply Withdrawal Fee for Transfers' | translate }}: {{ savingProduct.withdrawalFeeForTransfers | yesNo }}
-
+
{{ 'labels.inputs.Balance Required for Interest Calculation' | translate }}: {{ savingProduct.minBalanceForInterestCalculation | formatNumber }}
-
+
{{ 'labels.inputs.Enforce Minimum Balance' | translate }}: {{ savingProduct.enforceMinRequiredBalance | yesNo }}
-
+
{{ 'labels.inputs.Minimum Balance' | translate }}: {{ savingProduct.minRequiredBalance | formatNumber }}
-
+
{{ 'labels.inputs.Withhold Tax is Applicable' | translate }}: {{ savingProduct.withHoldTax | yesNo }}
-
+
{{ 'labels.inputs.Tax Group' | translate }}: {{ savingProduct.taxGroupId | find: savingProductsTemplate.taxGroupOptions : 'id' : 'name' }}
-
+
{{ 'labels.inputs.Is Overdraft Allowed' | translate }}: {{ savingProduct.allowOverdraft | yesNo }}
-
+
{{ 'labels.inputs.Minimum Overdraft Required for Interest Calculation' | translate }}: {{ savingProduct.minOverdraftForInterestCalculation | formatNumber }}
-
+
{{ 'labels.inputs.Nominal Annual Interest for Overdraft' | translate }}: {{ savingProduct.nominalAnnualInterestRateOverdraft | formatNumber }} %
-
+
{{ 'labels.inputs.Maximum Overdraft Amount Limit' | translate }}: {{ savingProduct.overdraftLimit | formatNumber }}
-
+
{{ 'labels.inputs.Enable Dormancy Tracking' | translate }}: {{ savingProduct.isDormancyTrackingActive | yesNo }}
-
+
{{ 'labels.inputs.Number of Days to Inactive sub-status' | translate }}: {{ savingProduct.daysToInactive }} {{ 'labels.inputs.Number of Days to Dormant sub-status' | translate }}: @@ -163,11 +163,11 @@ {{ savingProduct.daysToEscheat }}
-
-

{{ 'labels.inputs.Charges' | translate }}

+
+

{{ 'labels.inputs.Charges' | translate }}

- - + +
{{ 'labels.inputs.Name' | translate }} @@ -201,14 +201,11 @@
-

{{ 'labels.heading.Accounting' | translate }}

+

{{ 'labels.heading.Accounting' | translate }}

- - + + +
-

{{ 'labels.heading.Advanced Accounting Rules' | translate }}

+

{{ 'labels.heading.Advanced Accounting Rules' | translate }}

- +
-

{{ 'labels.heading.Fund Sources for Payment Channels' | translate }}

+

{{ 'labels.heading.Fund Sources for Payment Channels' | translate }}

@@ -256,10 +253,10 @@
-
-

{{ 'labels.heading.Fees to Specific Income Accounts' | translate }}

+
+

{{ 'labels.heading.Fees to Specific Income Accounts' | translate }}

- +
{{ 'labels.inputs.Fees' | translate }} @@ -284,11 +281,11 @@
-

{{ 'labels.heading.Penalties to Specific Income Accounts' | translate }}

+

{{ 'labels.heading.Penalties to Specific Income Accounts' | translate }}

- +
{{ 'labels.inputs.Penalty' | translate }} diff --git a/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.ts b/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.ts index 8279456ae..bc69b43ce 100644 --- a/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.ts +++ b/src/app/products/saving-products/saving-product-stepper/saving-product-preview-step/saving-product-preview-step.component.ts @@ -44,6 +44,7 @@ export class SavingProductPreviewStepComponent implements OnInit, OnChanges { setCurrentValues(): void { this.accountingRule = this.accounting.getAccountingRuleFrom(this.savingProduct.accountingRule); + if (this.isCashOrAccrualAccounting()) { const assetAccountData = this.savingProductsTemplate.accountingMappingOptions.assetAccountOptions || []; const incomeAccountData = this.savingProductsTemplate.accountingMappingOptions.incomeAccountOptions || []; @@ -102,10 +103,10 @@ export class SavingProductPreviewStepComponent implements OnInit, OnChanges { } isCashOrAccrualAccounting(): boolean { - return this.accounting.isAccrualAccountingRuleId(this.savingProduct.accountingRule); + return this.accounting.isCashOrAccrualAccounting(this.accountingRule); } isAccrualAccounting(): boolean { - return this.accounting.isAccrualAccounting(this.savingProduct.accountingRule); + return this.accounting.isAccrualAccounting(this.accountingRule); } } diff --git a/src/app/products/saving-products/view-saving-product/saving-product-general-tab/saving-product-general-tab.component.html b/src/app/products/saving-products/view-saving-product/saving-product-general-tab/saving-product-general-tab.component.html index de03f445a..944718df9 100644 --- a/src/app/products/saving-products/view-saving-product/saving-product-general-tab/saving-product-general-tab.component.html +++ b/src/app/products/saving-products/view-saving-product/saving-product-general-tab/saving-product-general-tab.component.html @@ -1,5 +1,11 @@
-
diff --git a/src/app/shared/accounting/view-savings-accounting-details/view-savings-accounting-details.component.html b/src/app/shared/accounting/view-savings-accounting-details/view-savings-accounting-details.component.html index 4c4d42449..2ff910bf4 100644 --- a/src/app/shared/accounting/view-savings-accounting-details/view-savings-accounting-details.component.html +++ b/src/app/shared/accounting/view-savings-accounting-details/view-savings-accounting-details.component.html @@ -1,114 +1,142 @@
-
+
{{ 'labels.inputs.Type' | translate }}: {{ 'labels.accounting.' + getAccountingRuleName(accountingRule.value) | translate }}
-
-

{{ 'labels.heading.Assets' | translate }}

- - - - - - - - +
+
+

{{ 'labels.heading.Assets' | translate }}

+
+ + +
+
+ + +
+
+ + +
+
+ + +
-

{{ 'labels.heading.Liabilities' | translate }}

- - - - - - - - +

{{ 'labels.heading.Liabilities' | translate }}

+
+ + +
+
+ + +
+
+ + +
+
+ + +
-

{{ 'labels.heading.Income' | translate }}

- - - - - - +

{{ 'labels.heading.Income' | translate }}

+
+ + +
+
+ + +
+
+ + +
-

{{ 'labels.heading.Expenses' | translate }}

- - - - +

{{ 'labels.heading.Expenses' | translate }}

+
+ + +
+
+ + +
+
diff --git a/src/app/shared/input-password/input-password.component.html b/src/app/shared/input-password/input-password.component.html index eb26b78ee..9a5061c27 100644 --- a/src/app/shared/input-password/input-password.component.html +++ b/src/app/shared/input-password/input-password.component.html @@ -1,4 +1,4 @@ - + {{ label }}