update loan product code and rd,fd,saving,current account validation add

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

src/app/savings/create-savings-account/create-savings-account.component.ts

@@ -21,6 +21,7 @@ import { SavingsAccountSettingsStepComponent } from '../savings-account-stepper/
 import { SavingsService } from '../savings.service';
 import { SettingsService } from 'app/settings/settings.service';
 import { Dates } from 'app/core/utils/dates';
+import { AlertService } from 'app/core/alert/alert.service';
 import {
   MatStepper,
   MatStepperIcon,
@@ -61,6 +62,7 @@ export class CreateSavingsAccountComponent {
   private dateUtils = inject(Dates);
   private savingsService = inject(SavingsService);
   private settingsService = inject(SettingsService);
+  private alertService = inject(AlertService);
 
   /** Savings Account Template */
   savingsAccountTemplate: any;
@@ -110,6 +112,14 @@ export class CreateSavingsAccountComponent {
   }
 
   submit() {
+    const detailsStep = this.savingsAccountDetailsStep;
+    if (detailsStep.selectedAccountStatus === 'JOINT' && detailsStep.totalJointSharePercentage !== 100) {
+      this.alertService.alert({
+        type: 'Error',
+        message: `Total ownership is ${detailsStep.totalJointSharePercentage}%. It must equal 100% before submitting.`
+      });
+      return;
+    }
     const locale = this.settingsService.language.code;
     const dateFormat = this.settingsService.dateFormat;
     const monthDayFormat = 'dd MMMM';

src/app/savings/savings-account-stepper/savings-account-details-step/savings-account-details-step.component.ts

@@ -22,6 +22,7 @@ import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
 import { IntroducerSearchComponent } from 'app/shared/introducer-search/introducer-search.component';
 import { MatIcon } from '@angular/material/icon';
 import { AddRelatedClientDialogComponent } from 'app/current-accounts/current-account-stepper/current-account-details-step/add-related-client-dialog/add-related-client-dialog.component';
+import { AlertService } from 'app/core/alert/alert.service';
 
 /**
  * Savings Account Details Step
@@ -48,6 +49,7 @@ export class SavingsAccountDetailsStepComponent implements OnInit {
   private dateUtils = inject(Dates);
   private cdr = inject(ChangeDetectorRef);
   private dialog = inject(MatDialog);
+  private alertService = inject(AlertService);
 
   /** Savings Account Template */
   @Input() savingsAccountTemplate: any;
@@ -335,9 +337,13 @@ export class SavingsAccountDetailsStepComponent implements OnInit {
     });
     ref.afterClosed().subscribe((result) => {
       if (result) {
-        const duplicate = this.jointHolders.some((h) => h.clientCif && h.clientCif === result.clientCif);
+        const isPrimary = this.primaryClientCif && this.primaryClientCif === result.clientCif;
+        const duplicate = isPrimary || this.jointHolders.some((h) => h.clientCif && h.clientCif === result.clientCif);
         if (duplicate) {
-          alert(`Account holder with CIF ${result.clientCif} is already added.`);
+          this.alertService.alert({
+            type: 'Error',
+            message: `Account holder with CIF ${result.clientCif} is already added.`
+          });
           return;
         }
         this.jointHolders = [
@@ -446,7 +452,7 @@ export class SavingsAccountDetailsStepComponent implements OnInit {
       value.guardianName = this.guardianName;
       value.guardianCifNumber = this.guardianCif;
       value.guardianRelationship = this.guardianRelationship;
-      value.minorDateOfBirth = this.minorDob ? this.dateUtils.formatDate(this.minorDob, 'yyyy-MM-dd') : null;
+      value.minorDateOfBirth = this.minorDob ? this.dateUtils.formatDate(this.minorDob, 'dd MMMM yyyy') : null;
     }
 
     return value;