CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #2751 from JaySoni1/WEB-362-correct-position-and-trailing-comma-in-provisioning-criteria-loan-product

Browse Source 
WEB-362-correct-position-and-trailing-comma-in-provisioning-criteria-loan-product
This commit is contained in:
Jose Alberto Hernandez
2025-11-04 15:32:50 -05:00
committed by GitHub
parent 1fbd90a756 dd8650a7df
commit de480e0017
3 changed files with 31 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/organization/loan-provisioning-criteria/view-loan-provisioning-criteria/view-loan-provisioning-criteria.component.html
+9 -8
View File
@@ -12,15 +12,16 @@
<div class="container"> <div class="container">
<mat-card> <mat-card>
<mat-card-content> <mat-card-content>
<div class="layout-row-wrap"> <div class="layout-row-wrap align-center">
<h2 class="mat-h2 flex-fill">{{ provisioningData.criteriaName }}</h2> <h2 class="mat-h2 criteria-title">
<mat-divider [inset]="true"></mat-divider> {{ provisioningData.criteriaName }}
</h2>
<div class="loanProduct flex-fill"> <span class="loan-product-label">
<span class="flex-40">{{ 'labels.inputs.Loan Product' | translate }}:</span> <strong>{{ 'labels.inputs.Loan Product' | translate }}:</strong>
<span class="flex-60">{{ loanProducts }}</span> <span>{{ loanProducts }}</span>
</div> </span>
</div> </div>
<mat-divider [inset]="true"></mat-divider>
<div> <div>
<table mat-table class="mat-elevation-z1" [dataSource]="dataSource"> <table mat-table class="mat-elevation-z1" [dataSource]="dataSource">
src/app/organization/loan-provisioning-criteria/view-loan-provisioning-criteria/view-loan-provisioning-criteria.component.scss
+12
View File
@@ -1,3 +1,15 @@
.criteria-title {
margin-bottom: 0;
display: inline;
vertical-align: middle;
}
.loan-product-label {
margin-left: 24px;
font-size: 1.1em;
vertical-align: middle;
}
table { table {
width: 100%; width: 100%;
} }
src/app/organization/loan-provisioning-criteria/view-loan-provisioning-criteria/view-loan-provisioning-criteria.component.ts
+10 -3
View File
@@ -25,6 +25,8 @@ import { FaIconComponent } from '@fortawesome/angular-fontawesome';
import { MatDivider } from '@angular/material/divider'; import { MatDivider } from '@angular/material/divider';
import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module'; import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
import { LoanProduct } from 'app/products/loan-products/models/loan-product.model';
/** /**
* View Loan Provisioning * View Loan Provisioning
*/ */
@@ -93,9 +95,14 @@ export class ViewLoanProvisioningCriteriaComponent implements OnInit {
setLoanProvisioningSelectedCriteria() { setLoanProvisioningSelectedCriteria() {
this.dataSource = new MatTableDataSource(this.provisioningData.definitions); this.dataSource = new MatTableDataSource(this.provisioningData.definitions);
/** Get load products as a string. */ // Get loan products as a comma-separated string, no trailing comma, with type safety
for (let _id = 0; _id < this.provisioningData.loanProducts.length; _id++) { if (this.provisioningData.loanProducts && this.provisioningData.loanProducts.length > 0) {
this.loanProducts += this.provisioningData.loanProducts[_id].name + ','; this.loanProducts = (this.provisioningData.loanProducts as LoanProduct[])
.filter((p) => p && p.name)
.map((p) => p.name)
.join(', ');
} else {
this.loanProducts = '';
} }
} }