CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)

Browse Source 
This is just a first step - we should aim for -Xlint:all! ;)
This commit is contained in:
Michael Vorburger ⛑️
2020-05-15 21:31:16 +01:00
committed by GitHub
parent 39675c9a23
commit 0eee0ff775
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/build.gradle
+1 -1
View File
@@ -284,7 +284,7 @@ configurations {
} }
tasks.withType(JavaCompile) { tasks.withType(JavaCompile) {
options.compilerArgs << '-Xlint:unchecked' options.compilerArgs += ["-Xlint:unchecked", "-Werror"] // TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X")
options.deprecation = true options.deprecation = true
} }
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/SchedulerJobsTest.java
+2 -1
View File
@@ -108,7 +108,7 @@ public class SchedulerJobsTest {
Map<String, Object> schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId); Map<String, Object> schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId);
// Executing Scheduler Job // Executing Scheduler Job
schedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString()); SchedulerJobHelper.runSchedulerJob(requestSpec, jobId.toString());
// Retrieving Scheduler Job by ID // Retrieving Scheduler Job by ID
schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId); schedulerJob = schedulerJobHelper.getSchedulerJobById(jobId);
@@ -121,6 +121,7 @@ public class SchedulerJobsTest {
assertNotNull(schedulerJob); assertNotNull(schedulerJob);
System.out.println("Job " + jobId +" is Still Running"); System.out.println("Job " + jobId +" is Still Running");
} }
@SuppressWarnings({ "unchecked", "rawtypes" })
List<Map> jobHistoryData = schedulerJobHelper.getSchedulerJobHistory(jobId); List<Map> jobHistoryData = schedulerJobHelper.getSchedulerJobHistory(jobId);
// Verifying the Status of the Recently executed Scheduler Job // Verifying the Status of the Recently executed Scheduler Job