CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity

FINERACT-2078: Remove hardcoded use of RoundingMode outside of MoneyHelper

Browse Source
This commit is contained in:
Boris Litvin
2024-05-17 17:03:01 +02:00
committed by Adam Saghy
parent abc7cec2ec
commit 1679ea9237
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java
+2 -2
View File
@@ -19,7 +19,7 @@
package org.apache.fineract.portfolio.loanaccount.loanschedule.domain;
import java.math.BigDecimal;
import java.math.RoundingMode;
import org.apache.fineract.organisation.monetary.domain.MoneyHelper;
import org.apache.fineract.portfolio.common.domain.PeriodFrequencyType;
import org.springframework.stereotype.Component;
@@ -44,7 +44,7 @@ public class AprCalculator {
break;
case WHOLE_TERM:
final BigDecimal ratePerPeriod = interestRatePerPeriod.divide(BigDecimal.valueOf(numberOfRepayments * repaymentEvery), 8,
RoundingMode.HALF_UP);
MoneyHelper.getRoundingMode());
switch (repaymentPeriodFrequencyType) {
case DAYS:
fineract-provider/src/main/java/org/apache/fineract/portfolio/search/service/SearchReadPlatformServiceImpl.java
+4 -4
View File
@@ -19,7 +19,6 @@
package org.apache.fineract.portfolio.search.service;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Collection;
@@ -29,6 +28,7 @@ import org.apache.fineract.infrastructure.core.data.EnumOptionData;
import org.apache.fineract.infrastructure.core.domain.JdbcSupport;
import org.apache.fineract.infrastructure.core.service.database.DatabaseSpecificSQLGenerator;
import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
import org.apache.fineract.organisation.monetary.domain.MoneyHelper;
import org.apache.fineract.organisation.office.data.OfficeData;
import org.apache.fineract.organisation.office.service.OfficeReadPlatformService;
import org.apache.fineract.portfolio.client.domain.ClientEnumerations;
@@ -314,9 +314,9 @@ public class SearchReadPlatformServiceImpl implements SearchReadPlatformService
final String loanProductName = rs.getString("productName");
final Integer count = JdbcSupport.getInteger(rs, "count");
final BigDecimal loanOutStanding = JdbcSupport.getBigDecimalDefaultToZeroIfNull(rs, "outstanding").setScale(2,
RoundingMode.HALF_UP);
final Double percentage = JdbcSupport.getBigDecimalDefaultToZeroIfNull(rs, "percentOut").setScale(2, RoundingMode.HALF_UP)
.doubleValue();
MoneyHelper.getRoundingMode());
final Double percentage = JdbcSupport.getBigDecimalDefaultToZeroIfNull(rs, "percentOut")
.setScale(2, MoneyHelper.getRoundingMode()).doubleValue();
return AdHocSearchQueryData.matchedResult(officeName, loanProductName, count, loanOutStanding, percentage);
}