Merge pull request #1140 from Musoni/MIFOSX-1655

fixed MIFOSX-1655 issue with updating a loan with a charge

mifosng-provider/src/main/java/org/mifosplatform/portfolio/common/domain/DayOfWeekType.java

@@ -1,3 +1,8 @@
+/**
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
 package org.mifosplatform.portfolio.common.domain;
 
 import org.joda.time.DateTimeConstants;

mifosng-provider/src/main/java/org/mifosplatform/portfolio/common/domain/DaysInMonthType.java

@@ -4,7 +4,11 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 package org.mifosplatform.portfolio.common.domain;
-
+/**
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
 import java.util.ArrayList;
 import java.util.List;
 

mifosng-provider/src/main/java/org/mifosplatform/portfolio/common/domain/NthDayType.java

@@ -1,3 +1,8 @@
+/**
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
 package org.mifosplatform.portfolio.common.domain;
 
 public enum NthDayType {

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java

@@ -389,10 +389,13 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
              * If there are any charges already present, which are now not
              * passed in as a part of the request, deem the charges as modified
              **/
-            if (!possiblyModifedLoanCharges.containsAll(existingCharges)) {
-                isChargeModified = true;
+            if(!possiblyModifedLoanCharges.isEmpty()){
+                if (!possiblyModifedLoanCharges.containsAll(existingCharges)) {
+                    isChargeModified = true;
+                }
             }
 
+
             /**
              * If any new charges are added or values of existing charges are
              * modified