some supressing of warnings and retaining loanAccountData as immutable (of sorts).

mifosng-provider/src/main/java/org/mifosng/platform/api/data/LoanAccountData.java

@@ -20,8 +20,8 @@ public class LoanAccountData {
 	private final EnumOptionData status;
 	private final Long fundId;
 	private final String fundName;
-	private Long loanOfficerId;
-	private String loanOfficerName;
+	private final Long loanOfficerId;
+	private final String loanOfficerName;
 	private final CurrencyData currency;
 	private final BigDecimal principal;
 	private final BigDecimal inArrearsTolerance;
@@ -58,6 +58,8 @@ public class LoanAccountData {
 	private final LoanConvenienceData convenienceData;
 	
 	// template
+	@SuppressWarnings("unused")
+	private final Collection<StaffData> loanOfficerOptions;
 	private final Collection<LoanProductLookup> productOptions;
 	private final Collection<EnumOptionData> termFrequencyTypeOptions;
 	private final Collection<EnumOptionData> repaymentFrequencyTypeOptions;
@@ -68,8 +70,8 @@ public class LoanAccountData {
 	private final Collection<EnumOptionData> interestCalculationPeriodTypeOptions;
 	private final Collection<FundData> fundOptions;
 	private final Collection<ChargeData> chargeOptions;
-    private final ChargeData chargeTemplate;
-	private final Collection<StaffData> loanOfficerOptions;
+    @SuppressWarnings("unused")
+	private final ChargeData chargeTemplate;
 	
 	public LoanAccountData(
 			final LoanBasicDetailsData basicDetails,
@@ -380,15 +382,7 @@ public class LoanAccountData {
 		return loanOfficerId;
 	}
 
-	public void setLoanOfficerId(Long loanOfficerId) {
-		this.loanOfficerId = loanOfficerId;
-	}
-
 	public String getLoanOfficerName() {
 		return loanOfficerName;
 	}
-
-	public void setLoanOfficerName(String loanOfficerName) {
-		this.loanOfficerName = loanOfficerName;
-	}
 }

mifosng-provider/src/main/java/org/mifosng/platform/api/data/LoanBasicDetailsData.java

@@ -13,10 +13,6 @@ import org.joda.time.Months;
  */
 public class LoanBasicDetailsData {
 
-	public Long getClientOfficeId() {
-		return clientOfficeId;
-	}
-
 	private final Long id;
 	private final String externalId;
 	private final Long clientId;
@@ -28,8 +24,8 @@ public class LoanBasicDetailsData {
 	private final EnumOptionData status;
 	private final Long fundId;
 	private final String fundName;
-	private Long loanOfficerId;
-	private String loanOfficerName;
+	private final Long loanOfficerId;
+	private final String loanOfficerName;
 	private final CurrencyData currency;
 	private final BigDecimal principal;
 	private final BigDecimal inArrearsTolerance;
@@ -105,6 +101,8 @@ public class LoanBasicDetailsData {
 		this.status = null;
 		this.fundId = fundId;
 		this.fundName = fundName;
+		this.loanOfficerId = null;
+		this.loanOfficerName = null;
 		this.currency = currency;
 		this.principal = principal;
 		this.inArrearsTolerance = inArrearsTolerance;
@@ -367,6 +365,10 @@ public class LoanBasicDetailsData {
 	public String getClientName() {
 		return clientName;
 	}
+	
+	public Long getClientOfficeId() {
+		return clientOfficeId;
+	}
 
 	public Long getFundId() {
 		return fundId;
@@ -496,15 +498,7 @@ public class LoanBasicDetailsData {
 		return loanOfficerId;
 	}
 
-	public void setLoanOfficerId(Long loanOfficerId) {
-		this.loanOfficerId = loanOfficerId;
-	}
-
 	public String getLoanOfficerName() {
 		return loanOfficerName;
 	}
-
-	public void setLoanOfficerName(String loanOfficerName) {
-		this.loanOfficerName = loanOfficerName;
-	}
 }

mifosng-provider/src/main/java/org/mifosng/platform/client/domain/Note.java

@@ -38,7 +38,8 @@ public class Note extends AbstractAuditableCustom<AppUser, Long> {
 	@Column(name = "note_type_enum")
     private Integer       noteTypeId;
     
-    @ManyToOne
+    @SuppressWarnings("unused")
+	@ManyToOne
     @JoinColumn(name = "deposit_account_id", nullable = true)
     private DepositAccount depositAccount;
     

mifosng-provider/src/main/java/org/mifosng/platform/saving/domain/DepositAccount.java

@@ -36,7 +36,6 @@ import org.mifosng.platform.user.domain.AppUser;
 @Table(name = "m_deposit_account", uniqueConstraints = @UniqueConstraint(name="deposit_acc_external_id", columnNames = { "external_id" }))
 public class DepositAccount extends AbstractAuditableCustom<AppUser, Long>  {
 	
-	@SuppressWarnings("unused")
 	@ManyToOne
 	@JoinColumn(name = "client_id", nullable = false)
 	private Client client;