fix issues where get null pointer if no locale passed along with digitsAfterDecimal or any integer value in general. existed pre madhukars commit.

mifosng-provider/src/main/java/org/mifosng/platform/api/data/SavingProductData.java

@@ -10,15 +10,14 @@ public class SavingProductData implements Serializable {
 	private Long id;
 	private String name;
 	private String description;
-	
-	private DateTime createdOn;
-	private DateTime lastModifedOn;
-	
 	private String currencyCode;
 	private Integer digitsAfterDecimal;
 	
 	private BigDecimal interestRate = BigDecimal.ZERO;
 	
+	private DateTime createdOn;
+	private DateTime lastModifedOn;
+	
 	public SavingProductData(){
 		//
 	}

mifosng-provider/src/main/java/org/mifosng/platform/api/infrastructure/ApiDataConversionServiceImpl.java

@@ -1232,7 +1232,20 @@ public class ApiDataConversionServiceImpl implements ApiDataConversionService {
 		return eventLocalDate;
 	}
 	
-	private Integer convertToInteger(String numericalValueFormatted, String parameterName, Locale clientApplicationLocale) {
+	private Integer convertToInteger(final String numericalValueFormatted, final String parameterName, final Locale clientApplicationLocale) {
+		
+		if (clientApplicationLocale == null) {
+			
+			List<ApiParameterError> dataValidationErrors = new ArrayList<ApiParameterError>();
+			String defaultMessage = new StringBuilder("The parameter '" + parameterName + "' requires a 'locale' parameter to be passed with it.").toString();
+			ApiParameterError error = ApiParameterError.parameterError("validation.msg.missing.locale.parameter", defaultMessage, parameterName);
+			dataValidationErrors.add(error);
+			
+			throw new PlatformApiDataValidationException(
+					"validation.msg.validation.errors.exist",
+					"Validation errors exist.", dataValidationErrors);
+		}
+		
 		try {
 			Integer number = null;
 

mifosng-provider/src/test/resources/META-INF/context.xml

@@ -5,7 +5,7 @@
             driverClassName="com.mysql.jdbc.Driver"
             url="jdbc:mysql://localhost:3306/mifosplatform-tenants"
             username="root"
-            password="mifos"
+            password="mysql"
             validationQuery="select 1"
             maxActive="10"
             maxIdle="4"