FINERACT-821 Added and Enforced LocalVariableName Checkstyle

This commit is contained in:
Manthan Surkar
2020-07-16 18:41:39 +02:00
committed by Michael Vorburger ⛑️
parent 737d1f1911
commit 271401cd6b
2 changed files with 19 additions and 5 deletions
@@ -23,6 +23,7 @@ import io.restassured.builder.ResponseSpecBuilder;
import io.restassured.http.ContentType;
import io.restassured.specification.RequestSpecification;
import io.restassured.specification.ResponseSpecification;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Random;
@@ -103,12 +104,8 @@ public class AuditIntegrationTest {
auditHelper.verifyOneAuditOnly(auditsRecieved, officeId, "CREATE", "OFFICE");
}
/**
*
* Here we test that audit request with limit x only returns x entries
*/
@Test
public void checkAuditsWithLimit() {
public void checkAuditsWithLimitParam() {
// Create client
final Integer clientId = ClientHelper.createClient(this.requestSpec, this.responseSpec);
@@ -128,4 +125,16 @@ public class AuditIntegrationTest {
}
}
@Test
public void checkIfOrderBySupported() {
final List<String> shouldBeSupportedFor = Arrays.asList("checkedOnDate", "officeName", "resourceId", "clientId", "processingResult",
"clientName", "maker", "subresourceId", "checker", "savingsAccountNo", "loanAccountNo", "groupName", "entityName",
"madeOnDate", "id", "loanId", "actionName");
for (int i = 0; i < shouldBeSupportedFor.size(); i++) {
auditHelper.verifyOrderBysupported(shouldBeSupportedFor.get(i));
}
}
}
@@ -100,4 +100,9 @@ public class AuditHelper {
assertEquals(limit, getAuditDetails(limit).size(), "Incorrect number of audits recieved for limit: " + Integer.toString(limit));
}
public void verifyOrderBysupported(final String orderByValue) {
final String AUDIT_URL = "/fineract-provider/api/v1/audits/?paged=true&orderBy=" + orderByValue + "&" + Utils.TENANT_IDENTIFIER;
Utils.performServerGet(requestSpec, responseSpec, AUDIT_URL, "");
}
}