fixing null pointer exception during client creation

This commit is contained in:
Vishwas Babu A J
2014-11-04 12:18:20 +05:30
parent 702ecd480f
commit 34fb6acc44
@@ -581,15 +581,16 @@ public class ClientWritePlatformServiceJpaRepositoryImpl implements ClientWriteP
private void validateParentGroupRulesBeforeClientActivation(Client client) {
Integer minNumberOfClients = configurationDomainService.retrieveMinAllowedClientsInGroup();
Integer maxNumberOfClients = configurationDomainService.retrieveMaxAllowedClientsInGroup();
for (Group group : client.getGroups()) {
/**
* Since this Client has not yet been associated with the group,
* reduce maxNumberOfClients by 1
**/
final boolean validationsuccess = group.isGroupsClientCountWithinMaxRange(maxNumberOfClients - 1);
if (!validationsuccess) { throw new GroupMemberCountNotInPermissibleRangeException(group.getId(), minNumberOfClients,
maxNumberOfClients); }
if (client.getGroups() != null) {
for (Group group : client.getGroups()) {
/**
* Since this Client has not yet been associated with the group,
* reduce maxNumberOfClients by 1
**/
final boolean validationsuccess = group.isGroupsClientCountWithinMaxRange(maxNumberOfClients - 1);
if (!validationsuccess) { throw new GroupMemberCountNotInPermissibleRangeException(group.getId(), minNumberOfClients,
maxNumberOfClients); }
}
}
}
}