CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

fixing null pointer exception during client creation

Browse Source
This commit is contained in:
Vishwas Babu A J
2014-11-04 12:18:20 +05:30
parent 702ecd480f
commit 34fb6acc44
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mifosng-provider/src/main/java/org/mifosplatform/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java
+10 -9
View File
@@ -581,15 +581,16 @@ public class ClientWritePlatformServiceJpaRepositoryImpl implements ClientWriteP
private void validateParentGroupRulesBeforeClientActivation(Client client) { private void validateParentGroupRulesBeforeClientActivation(Client client) {
Integer minNumberOfClients = configurationDomainService.retrieveMinAllowedClientsInGroup(); Integer minNumberOfClients = configurationDomainService.retrieveMinAllowedClientsInGroup();
Integer maxNumberOfClients = configurationDomainService.retrieveMaxAllowedClientsInGroup(); Integer maxNumberOfClients = configurationDomainService.retrieveMaxAllowedClientsInGroup();
for (Group group : client.getGroups()) { if (client.getGroups() != null) {
/** for (Group group : client.getGroups()) {
* Since this Client has not yet been associated with the group, /**
* reduce maxNumberOfClients by 1 * Since this Client has not yet been associated with the group,
**/ * reduce maxNumberOfClients by 1
final boolean validationsuccess = group.isGroupsClientCountWithinMaxRange(maxNumberOfClients - 1); **/
if (!validationsuccess) { throw new GroupMemberCountNotInPermissibleRangeException(group.getId(), minNumberOfClients, final boolean validationsuccess = group.isGroupsClientCountWithinMaxRange(maxNumberOfClients - 1);
maxNumberOfClients); } if (!validationsuccess) { throw new GroupMemberCountNotInPermissibleRangeException(group.getId(), minNumberOfClients,
maxNumberOfClients); }
}
} }
} }
} }