CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 19 Packages Projects Releases Wiki Activity

Merge pull request #902 from vorburger/JobLogImprovementIllustratingBug

Browse Source 
JobRegisterServiceImpl error logging improvement
This commit is contained in:
Vishwas Babu A J
2014-05-11 03:39:01 +05:30
parent 9e8ead2045 b0132db815
commit 363ca7dc0e
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java
+9 -2
View File
@@ -108,8 +108,12 @@ public class JobRegisterServiceImpl implements JobRegisterService {
} }
} catch (final Exception e) { } catch (final Exception e) {
throw new PlatformInternalServerException("error.msg.sheduler.job.execution.failed", "Job execution failed for job with id:" final String msg = "Job execution failed for job with id:"
+ scheduledJobDetail.getId(), scheduledJobDetail.getId()); + scheduledJobDetail.getId();
logger.error(msg, e);
throw new PlatformInternalServerException(
"error.msg.sheduler.job.execution.failed", msg,
scheduledJobDetail.getId());
} }
} }
@@ -214,6 +218,9 @@ public class JobRegisterServiceImpl implements JobRegisterService {
scheduledJobDetails.updateNextRunTime(null); scheduledJobDetails.updateNextRunTime(null);
final String stackTrace = getStackTraceAsString(throwable); final String stackTrace = getStackTraceAsString(throwable);
scheduledJobDetails.updateErrorLog(stackTrace); scheduledJobDetails.updateErrorLog(stackTrace);
logger.error(
"Could not schedule job: "
+ scheduledJobDetails.getJobName(), throwable);
} }
scheduledJobDetails.updateCurrentlyRunningStatus(false); scheduledJobDetails.updateCurrentlyRunningStatus(false);
} }