FINERACT-822 Enable ProtectedMembersInFinalClass check

2020-07-03 16:25:03 +02:00
parent 3f1673ea97
commit 5a16d19564
13 changed files with 21 additions and 21 deletions
@@ -395,7 +395,6 @@ tasks.withType(JavaCompile) {
                "InvalidParam",
                "ReturnFromVoid",
                "AlmostJavadoc",
-                "ProtectedMembersInFinalClass",
                "InvalidBlockTag",
        )
        //TODO gradually enable these checks
@@ -458,6 +457,7 @@ tasks.withType(JavaCompile) {
                "InvalidInlineTag",
                "MutablePublicArray",
                "StaticAssignmentInConstructor",
+                "ProtectedMembersInFinalClass",
                "OperatorPrecedence",
                "EqualsGetClass",
                "EqualsUnsafeCast",
@@ -67,7 +67,7 @@ public class ProvisioningEntriesReadPlatformServiceImpl implements ProvisioningE

        private final StringBuilder sqlQuery;

-        protected LoanProductProvisioningEntryMapper(String formattedDate) {
+        private LoanProductProvisioningEntryMapper(String formattedDate) {
            sqlQuery = new StringBuilder().append(
                    "select if(loan.loan_type_enum=1, mclient.office_id, mgroup.office_id) as office_id, loan.loan_type_enum, pcd.criteria_id as criteriaid, loan.product_id,loan.currency_code,")
                    .append("GREATEST(datediff(").append(formattedDate)
@@ -111,7 +111,7 @@ public final class Report extends AbstractPersistableCustom {
        return new Report(reportName, reportType, reportSubType, reportCategory, description, useReport, reportSql, reportTypes);
    }

-    protected Report() {
+    Report() {
        //
    }

@@ -40,7 +40,7 @@ public final class ReportParameterUsage extends AbstractPersistableCustom {
    @Column(name = "report_parameter_name")
    private String reportParameterName;

-    protected ReportParameterUsage() {
+    ReportParameterUsage() {
        //
    }

@@ -38,7 +38,7 @@ public final class Image extends AbstractPersistableCustom {
        this.storageType = storageType.getValue();
    }

-    protected Image() {
+    Image() {

    }

@@ -279,7 +279,7 @@ public final class Client extends AbstractPersistableCustom {
                savingsAccountId, dataOfBirth, gender, clientType, clientClassification, legalForm, isStaff);
    }

-    protected Client() {
+    Client() {
        this.setLegalForm(null);
    }

@@ -148,7 +148,7 @@ public final class Group extends AbstractPersistableCustom {
    private List<GroupLoanIndividualMonitoringAccount> glimLoan;

    // JPA default constructor for entity
-    protected Group() {
+    Group() {
        this.name = null;
        this.externalId = null;
        this.clientMembers = new HashSet<>();
@@ -132,7 +132,7 @@ public final class LoanRepaymentScheduleInstallment extends AbstractAuditableCus
    @JoinColumn(name = "loan_repayment_schedule_id", referencedColumnName = "id", nullable = false)
    private Set<LoanInterestRecalcualtionAdditionalDetails> loanCompoundingDetails = new HashSet<>();

-    protected LoanRepaymentScheduleInstallment() {
+    LoanRepaymentScheduleInstallment() {
        this.installmentNumber = null;
        this.fromDate = null;
        this.dueDate = null;
@@ -121,7 +121,7 @@ public final class LoanSummary {
        return new LoanSummary(totalFeeChargesDueAtDisbursement);
    }

-    protected LoanSummary() {
+    LoanSummary() {
        //
    }

@@ -55,7 +55,7 @@ public final class PaymentDetail extends AbstractPersistableCustom {
    @Column(name = "bank_number", length = 50)
    private String bankNumber;

-    protected PaymentDetail() {
+    PaymentDetail() {

    }

@@ -39,17 +39,17 @@ public final class FixedDepositProductData extends DepositProductData {

    // additional fields
    private boolean preClosurePenalApplicable;
-    protected BigDecimal preClosurePenalInterest;
-    protected EnumOptionData preClosurePenalInterestOnType;
-    protected Integer minDepositTerm;
-    protected Integer maxDepositTerm;
+    private BigDecimal preClosurePenalInterest;
+    private EnumOptionData preClosurePenalInterestOnType;
+    private Integer minDepositTerm;
+    private Integer maxDepositTerm;
    private EnumOptionData minDepositTermType;
    private EnumOptionData maxDepositTermType;
-    protected Integer inMultiplesOfDepositTerm;
-    protected EnumOptionData inMultiplesOfDepositTermType;
-    protected BigDecimal minDepositAmount;
-    protected BigDecimal depositAmount;
-    protected BigDecimal maxDepositAmount;
+    private Integer inMultiplesOfDepositTerm;
+    private EnumOptionData inMultiplesOfDepositTermType;
+    private BigDecimal minDepositAmount;
+    private BigDecimal depositAmount;
+    private BigDecimal maxDepositAmount;

    private Collection<EnumOptionData> preClosurePenalInterestOnTypeOptions;
    private Collection<EnumOptionData> periodFrequencyTypeOptions;
@@ -82,7 +82,7 @@ public final class SavingsAccountSummary {
    @Column(name = "last_interest_calculation_date")
    private Date lastInterestCalculationDate;

-    protected SavingsAccountSummary() {
+    SavingsAccountSummary() {
        //
    }

@@ -130,7 +130,7 @@ public final class SavingsAccountTransaction extends AbstractPersistableCustom {
    @JoinColumn(name = "savings_account_transaction_id", referencedColumnName = "id")
    private List<Note> notes = new ArrayList<>();

-    protected SavingsAccountTransaction() {
+    SavingsAccountTransaction() {
        this.dateOf = null;
        this.typeOf = null;
        this.createdDate = null;