FINERACT-822 Enable ProtectedMembersInFinalClass check

fineract-provider/build.gradle

@@ -395,7 +395,6 @@ tasks.withType(JavaCompile) {
                 "InvalidParam",
                 "ReturnFromVoid",
                 "AlmostJavadoc",
-                "ProtectedMembersInFinalClass",
                 "InvalidBlockTag",
         )
         //TODO gradually enable these checks
@@ -458,6 +457,7 @@ tasks.withType(JavaCompile) {
                 "InvalidInlineTag",
                 "MutablePublicArray",
                 "StaticAssignmentInConstructor",
+                "ProtectedMembersInFinalClass",
                 "OperatorPrecedence",
                 "EqualsGetClass",
                 "EqualsUnsafeCast",

fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java

@@ -67,7 +67,7 @@ public class ProvisioningEntriesReadPlatformServiceImpl implements ProvisioningE
 
         private final StringBuilder sqlQuery;
 
-        protected LoanProductProvisioningEntryMapper(String formattedDate) {
+        private LoanProductProvisioningEntryMapper(String formattedDate) {
             sqlQuery = new StringBuilder().append(
                     "select if(loan.loan_type_enum=1, mclient.office_id, mgroup.office_id) as office_id, loan.loan_type_enum, pcd.criteria_id as criteriaid, loan.product_id,loan.currency_code,")
                     .append("GREATEST(datediff(").append(formattedDate)

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/Report.java

@@ -111,7 +111,7 @@ public final class Report extends AbstractPersistableCustom {
         return new Report(reportName, reportType, reportSubType, reportCategory, description, useReport, reportSql, reportTypes);
     }
 
-    protected Report() {
+    Report() {
         //
     }
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/domain/ReportParameterUsage.java

@@ -40,7 +40,7 @@ public final class ReportParameterUsage extends AbstractPersistableCustom {
     @Column(name = "report_parameter_name")
     private String reportParameterName;
 
-    protected ReportParameterUsage() {
+    ReportParameterUsage() {
         //
     }
 

fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/domain/Image.java

@@ -38,7 +38,7 @@ public final class Image extends AbstractPersistableCustom {
         this.storageType = storageType.getValue();
     }
 
-    protected Image() {
+    Image() {
 
     }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java

@@ -279,7 +279,7 @@ public final class Client extends AbstractPersistableCustom {
                 savingsAccountId, dataOfBirth, gender, clientType, clientClassification, legalForm, isStaff);
     }
 
-    protected Client() {
+    Client() {
         this.setLegalForm(null);
     }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/group/domain/Group.java

@@ -148,7 +148,7 @@ public final class Group extends AbstractPersistableCustom {
     private List<GroupLoanIndividualMonitoringAccount> glimLoan;
 
     // JPA default constructor for entity
-    protected Group() {
+    Group() {
         this.name = null;
         this.externalId = null;
         this.clientMembers = new HashSet<>();

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java

@@ -132,7 +132,7 @@ public final class LoanRepaymentScheduleInstallment extends AbstractAuditableCus
     @JoinColumn(name = "loan_repayment_schedule_id", referencedColumnName = "id", nullable = false)
     private Set<LoanInterestRecalcualtionAdditionalDetails> loanCompoundingDetails = new HashSet<>();
 
-    protected LoanRepaymentScheduleInstallment() {
+    LoanRepaymentScheduleInstallment() {
         this.installmentNumber = null;
         this.fromDate = null;
         this.dueDate = null;

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanSummary.java

@@ -121,7 +121,7 @@ public final class LoanSummary {
         return new LoanSummary(totalFeeChargesDueAtDisbursement);
     }
 
-    protected LoanSummary() {
+    LoanSummary() {
         //
     }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java

@@ -55,7 +55,7 @@ public final class PaymentDetail extends AbstractPersistableCustom {
     @Column(name = "bank_number", length = 50)
     private String bankNumber;
 
-    protected PaymentDetail() {
+    PaymentDetail() {
 
     }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/FixedDepositProductData.java

@@ -39,17 +39,17 @@ public final class FixedDepositProductData extends DepositProductData {
 
     // additional fields
     private boolean preClosurePenalApplicable;
-    protected BigDecimal preClosurePenalInterest;
+    private BigDecimal preClosurePenalInterest;
-    protected EnumOptionData preClosurePenalInterestOnType;
+    private EnumOptionData preClosurePenalInterestOnType;
-    protected Integer minDepositTerm;
+    private Integer minDepositTerm;
-    protected Integer maxDepositTerm;
+    private Integer maxDepositTerm;
     private EnumOptionData minDepositTermType;
     private EnumOptionData maxDepositTermType;
-    protected Integer inMultiplesOfDepositTerm;
+    private Integer inMultiplesOfDepositTerm;
-    protected EnumOptionData inMultiplesOfDepositTermType;
+    private EnumOptionData inMultiplesOfDepositTermType;
-    protected BigDecimal minDepositAmount;
+    private BigDecimal minDepositAmount;
-    protected BigDecimal depositAmount;
+    private BigDecimal depositAmount;
-    protected BigDecimal maxDepositAmount;
+    private BigDecimal maxDepositAmount;
 
     private Collection<EnumOptionData> preClosurePenalInterestOnTypeOptions;
     private Collection<EnumOptionData> periodFrequencyTypeOptions;

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountSummary.java

@@ -82,7 +82,7 @@ public final class SavingsAccountSummary {
     @Column(name = "last_interest_calculation_date")
     private Date lastInterestCalculationDate;
 
-    protected SavingsAccountSummary() {
+    SavingsAccountSummary() {
         //
     }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java

@@ -130,7 +130,7 @@ public final class SavingsAccountTransaction extends AbstractPersistableCustom {
     @JoinColumn(name = "savings_account_transaction_id", referencedColumnName = "id")
     private List<Note> notes = new ArrayList<>();
 
-    protected SavingsAccountTransaction() {
+    SavingsAccountTransaction() {
         this.dateOf = null;
         this.typeOf = null;
         this.createdDate = null;