CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity

minor clean-up to eliminate 'dead code' in CodeValue

Browse Source 
This fixes one of too many ;) warnings Eclipse shows.

It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
This commit is contained in:
Michael Vorburger
2020-06-02 15:36:09 +01:00
committed by Yemdjih Kaze Nasser
parent 956a84114f
commit 6f128bf508
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/domain/CodeValue.java
+4 -9
View File
@@ -93,18 +93,13 @@ public class CodeValue extends AbstractPersistableCustom {
isActive = isActiveObj;
}
if (position == null) {
position = Integer.valueOf(0);
position = 0;
}
Boolean mandatory = command.booleanPrimitiveValueOfParameterNamed(
CodevalueJSONinputParams.IS_MANDATORY.getValue());
// if the "mandatory" Boolean object is null, then set it to false by default
if (mandatory == null) {
mandatory = false;
}
return new CodeValue(code, label, position.intValue(), description, isActive, mandatory);
return new CodeValue(code, label, position, description, isActive, mandatory);
}
public Map<String, Object> update(final JsonCommand command) {
@@ -129,14 +124,14 @@ public class CodeValue extends AbstractPersistableCustom {
if (command.isChangeInIntegerSansLocaleParameterNamed(positionParamName, this.position)) {
final Integer newValue = command.integerValueSansLocaleOfParameterNamed(positionParamName);
actualChanges.put(positionParamName, newValue);
this.position = newValue.intValue();
this.position = newValue;
}
final String isActiveParamName = CodevalueJSONinputParams.IS_ACTIVE.getValue();
if (command.isChangeInBooleanParameterNamed(isActiveParamName, this.isActive)) {
final Boolean newValue = command.booleanPrimitiveValueOfParameterNamed(isActiveParamName);
actualChanges.put(isActiveParamName, newValue);
this.isActive = newValue.booleanValue();
this.isActive = newValue;
}
return actualChanges;