FINERACT-822 Enforce SameNameButDifferent check (#1083)

fineract-provider/build.gradle

@@ -383,7 +383,6 @@ tasks.withType(JavaCompile) {
         //Todo Remove necessary checks from this list
         disable(
                 "UnusedVariable",
-                "SameNameButDifferent",
                 "TypeParameterUnusedInFormals",
                 "JdkObsolete",
                 "EmptyBlockTag",
@@ -425,6 +424,7 @@ tasks.withType(JavaCompile) {
                 "StreamResourceLeak",
                 "TruthIncompatibleType",
                 "ByteBufferBackingArray",
+                "SameNameButDifferent",
                 "OrphanedFormatString",
                 "CatchAndPrintStackTrace",
                 "ObjectToString",

fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/api/DocumentManagementApiResourceSwagger.java

@@ -90,7 +90,7 @@ final class DocumentManagementApiResourceSwagger {
 
         @ApiModelProperty(example = "3")
         public Long resourceId;
-        public PutEntityTypeEntityIdDocumentsResponseChangesSwagger changes;
+        public PutEntityTypeEntityIdDocumentsResponse.PutEntityTypeEntityIdDocumentsResponseChangesSwagger changes;
         @ApiModelProperty(example = "3")
         public String resourceIdentifier;
     }
@@ -112,7 +112,7 @@ final class DocumentManagementApiResourceSwagger {
 
         @ApiModelProperty(example = "3")
         public Long resourceId;
-        public PutEntityTypeEntityIdDocumentsResponseChangesSwagger changes;
+        public DeleteEntityTypeEntityIdDocumentsResponse.PutEntityTypeEntityIdDocumentsResponseChangesSwagger changes;
         @ApiModelProperty(example = "3")
         public String resourceIdentifier;
     }

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java

@@ -272,9 +272,9 @@ final class LoanProductsApiResourceSwagger {
             public Integer id;
             @ApiModelProperty(example = "1")
             public Integer productId;
-            public GetLoanProductsInterestRecalculationCompoundingType interestRecalculationCompoundingType;
+            public GetLoanProductsInterestRecalculationData.GetLoanProductsInterestRecalculationCompoundingType interestRecalculationCompoundingType;
             public GetLoanProductsInterestRecalculationCompoundingFrequencyType interestRecalculationCompoundingFrequencyType;
-            public GetLoanProductsRescheduleStrategyType rescheduleStrategyType;
+            public GetLoanProductsInterestRecalculationData.GetLoanProductsRescheduleStrategyType rescheduleStrategyType;
             public GetLoanProductsInterestRecalculationCompoundingFrequencyType recalculationRestFrequencyType;
             public GetLoanProductsPreClosureInterestCalculationStrategy preClosureInterestCalculationStrategy;
             @ApiModelProperty(example = "true")
@@ -327,7 +327,7 @@ final class LoanProductsApiResourceSwagger {
         public GetLoanProductsRepaymentFrequencyType repaymentFrequencyType;
         @ApiModelProperty(example = "15.000000")
         public Float interestRatePerPeriod;
-        public GetLoanProductsInterestRateFrequencyType interestRateFrequencyType;
+        public GetLoanProductsResponse.GetLoanProductsInterestRateFrequencyType interestRateFrequencyType;
         @ApiModelProperty(example = "15.000000")
         public Float annualInterestRate;
         public GetLoanProductsAmortizationType amortizationType;
@@ -348,7 +348,7 @@ final class LoanProductsApiResourceSwagger {
         @ApiModelProperty(example = "true")
         public Boolean isInterestRecalculationEnabled;
         public GetLoanProductsInterestRecalculationData interestRecalculationData;
-        public GetLoanProductsAccountingRule accountingRule;
+        public GetLoanProductsResponse.GetLoanProductsAccountingRule accountingRule;
         @ApiModelProperty(example = "0")
         public Integer principalThresholdForLastInstalment;
     }
@@ -478,8 +478,8 @@ final class LoanProductsApiResourceSwagger {
                 public String value;
             }
 
-            public GetLoanProductsInterestRecalculationCompoundingType interestRecalculationCompoundingType;
-            public GetLoanProductsRescheduleStrategyType rescheduleStrategyType;
+            public GetLoanProductsInterestRecalculationTemplateData.GetLoanProductsInterestRecalculationCompoundingType interestRecalculationCompoundingType;
+            public GetLoanProductsInterestRecalculationTemplateData.GetLoanProductsRescheduleStrategyType rescheduleStrategyType;
             public GetLoanProductsResponse.GetLoanProductsInterestRecalculationData.GetLoanProductsPreClosureInterestCalculationStrategy preClosureInterestCalculationStrategy;
         }
 
@@ -780,7 +780,7 @@ final class LoanProductsApiResourceSwagger {
         public List<Integer> interestRateVariationsForBorrowerCycle;
         @ApiModelProperty(example = "[]")
         public List<Integer> numberOfRepaymentVariationsForBorrowerCycle;
-        public GetLoanProductsAccountingRule accountingRule;
+        public GetLoanProductsTemplateResponse.GetLoanProductsAccountingRule accountingRule;
         public GetLoansProductsDaysInMonthTemplateType daysInMonthType;
         public GetLoanProductsDaysInYearTemplateType daysInYearType;
         @ApiModelProperty(example = "false")
@@ -1041,7 +1041,7 @@ final class LoanProductsApiResourceSwagger {
         public GetLoanProductsResponse.GetLoanProductsRepaymentFrequencyType repaymentFrequencyType;
         @ApiModelProperty(example = "5.000000")
         public Float interestRatePerPeriod;
-        public GetLoanProductsInterestRateFrequencyType interestRateFrequencyType;
+        public GetLoanProductsProductIdResponse.GetLoanProductsInterestRateFrequencyType interestRateFrequencyType;
         @ApiModelProperty(example = "60.000000")
         public Float annualInterestRate;
         public GetLoanProductsResponse.GetLoanProductsAmortizationType amortizationType;

fineract-provider/src/main/java/org/apache/fineract/useradministration/api/RolesApiResourceSwagger.java

@@ -186,7 +186,7 @@ final class RolesApiResourceSwagger {
             public String ALL_FUNCTIONS_READ;
         }
 
-        public PostRolesRoleIdPermissionsResponsePermissions permissions;
+        public PutRolesRoleIdPermissionsRequest.PostRolesRoleIdPermissionsResponsePermissions permissions;
 
     }
 
@@ -209,7 +209,7 @@ final class RolesApiResourceSwagger {
 
         @ApiModelProperty(example = "8")
         public Long resourceId;
-        public PostRolesRoleIdPermissionsResponsePermissions permissions;
+        public PutRolesRoleIdPermissionsRequest.PostRolesRoleIdPermissionsResponsePermissions permissions;
 
     }