FINERACT-822 enable MissingCasesInEnumSwitch error (#989)

fineract-provider/build.gradle

@@ -307,7 +307,6 @@ tasks.withType(JavaCompile) {
                 "UnusedVariable",
                 "InconsistentCapitalization",
                 "ClassCanBeStatic",
-                "MissingCasesInEnumSwitch",
                 "OperatorPrecedence",
                 "MixedMutabilityReturnType",
                 "SameNameButDifferent",
@@ -368,6 +367,7 @@ tasks.withType(JavaCompile) {
                 "ArgumentSelectionDefectChecker",
                 "CompareToZero",
                 "NarrowingCompoundAssignment",
+                "MissingCasesInEnumSwitch",
 //                "ReturnMissingNullable",
 //                "InconsistentOverloads",
 //                "MethodCanBeStatic",

fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/data/AccountNumberFormatDataValidator.java

@@ -127,6 +127,7 @@ public class AccountNumberFormatDataValidator {
         case GROUP:
             validAccountNumberPrefixes = AccountNumberFormatEnumerations.accountNumberPrefixesForGroups;
             break;
+        default:
         }
 
         Set<Integer> validAccountNumberPrefixValues = new HashSet<>();

fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/service/AccountNumberFormatReadPlatformServiceImpl.java

@@ -145,6 +145,7 @@ public class AccountNumberFormatReadPlatformServiceImpl implements AccountNumber
             case GROUP :
                 accountNumberPrefixTypesSet = AccountNumberFormatEnumerations.accountNumberPrefixesForGroups;
             break;
+            default:
         }
 
         Object[] array = accountNumberPrefixTypesSet.toArray();

fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDaysEnumerations.java

@@ -53,6 +53,7 @@ public class WorkingDaysEnumerations {
                 optionData = new EnumOptionData(RepaymentRescheduleType.MOVE_TO_PREVIOUS_WORKING_DAY.getValue().longValue(),RepaymentRescheduleType.MOVE_TO_PREVIOUS_WORKING_DAY.getCode(),
                         "move to previous working day");
                 break;
+            default:
         }
 
         return optionData;

fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountEnumerations.java

@@ -50,6 +50,7 @@ public class AccountEnumerations {
             case GLIM:
                 optionData = new EnumOptionData(AccountType.GLIM.getValue().longValue(), AccountType.GLIM.getCode(), "GLIM");
             break;
+            default:
         }
 
         return optionData;

fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/service/InterestRateChartEnumerations.java

@@ -52,6 +52,7 @@ public class InterestRateChartEnumerations {
                 optionData = new EnumOptionData(PeriodFrequencyType.YEARS.getValue().longValue(),
                         PeriodFrequencyType.YEARS.getCode(), "Years");
             break;
+            default:
         }
 
         return optionData;
@@ -66,4 +67,4 @@ public class InterestRateChartEnumerations {
         }
         return optionDatas;
     }
-}
+}

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java

@@ -4501,6 +4501,7 @@ public class Loan extends AbstractPersistableCustom {
             break;
             case INVALID:
             break;
+            default:
         }
         return dueRepaymentPeriodDate.minusDays(1);// get 2n-1 range date from
                                                    // startDate

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AprCalculator.java

@@ -57,6 +57,7 @@ public class AprCalculator {
                              case YEARS:
                                  defaultAnnualNominalInterestRate = ratePerPeriod.multiply(BigDecimal.valueOf(1));
                              break;
+                             default:
                          }
              break;
             case INVALID:

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultPaymentPeriodsInOneYearCalculator.java

@@ -45,6 +45,7 @@ public class DefaultPaymentPeriodsInOneYearCalculator implements PaymentPeriodsI
             case INVALID:
                 paymentPeriodsInOneYear = Integer.valueOf(0);
             break;
+            default:
         }
         return paymentPeriodsInOneYear;
     }
@@ -91,7 +92,8 @@ public class DefaultPaymentPeriodsInOneYearCalculator implements PaymentPeriodsI
             case INVALID:
                 fraction = Double.valueOf("0");
             break;
+            default:
         }
         return fraction;
     }
-}
+}

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java

@@ -227,6 +227,7 @@ public class DefaultScheduledDateGenerator implements ScheduledDateGenerator {
             break;
             case INVALID:
             break;
+            default:
         }
         return dueRepaymentPeriodDate;
     }
@@ -281,6 +282,7 @@ public class DefaultScheduledDateGenerator implements ScheduledDateGenerator {
             break;
             case INVALID:
             break;
+            default:
         }
         return isScheduledDate;
     }
@@ -315,6 +317,7 @@ public class DefaultScheduledDateGenerator implements ScheduledDateGenerator {
             break;
             case INVALID:
             break;
+            default:
         }
 
         return idealDisbursementDate;
@@ -333,4 +336,4 @@ public class DefaultScheduledDateGenerator implements ScheduledDateGenerator {
         generatedDate = adjustRepaymentDate(generatedDate, loanApplicationTerms, holidayDetailDTO).getChangedScheduleDate();
         return generatedDate;
     }
-}
+}

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java

@@ -658,6 +658,7 @@ public final class LoanApplicationTerms {
             break;
             case INVALID:
             break;
+            default:
         }
         return dueRepaymentPeriodDate;
     }
@@ -1050,6 +1051,7 @@ public final class LoanApplicationTerms {
                         }
                         periodicInterestRate = oneDayOfYearInterestRate.multiply(numberOfDaysInPeriod, mc);
                     break;
+                    default:
                 }
             break;
             case SAME_AS_REPAYMENT_PERIOD:

fineract-provider/src/main/java/org/apache/fineract/portfolio/note/api/NotesApiResource.java

@@ -228,10 +228,11 @@ public class NotesApiResource {
                 resourceNameForPermissions = "GROUPNOTE";
                 resourceDetails.withGroupId(resourceId);
             break;
+            default:
 
         }
 
         return resourceDetails.withEntityName(resourceNameForPermissions).build();
     }
 
-}
+}

fineract-provider/src/main/java/org/apache/fineract/portfolio/note/service/NoteWritePlatformServiceJpaRepositoryImpl.java

@@ -437,6 +437,7 @@ public class NoteWritePlatformServiceJpaRepositoryImpl implements NoteWritePlatf
             // break;
             case SAVING_ACCOUNT:
             break;
+            default:
         }
         if (noteForUpdate == null) { throw new NoteNotFoundException(noteId, resourceId, type.name().toLowerCase()); }
         return noteForUpdate;

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/DepositAccountUtils.java

@@ -46,6 +46,7 @@ public class DepositAccountUtils {
             break;
             case INVALID:
             break;
+            default:
         }
         return nextDepositDate;
     }

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java

@@ -2337,6 +2337,7 @@ public class SavingsAccount extends AbstractPersistableCustom {
             case YEARS:
                 lockedInUntilLocalDate = activationLocalDate.plusYears(this.lockinPeriodFrequency).toDate();
             break;
+            default:
         }
 
         return lockedInUntilLocalDate;

fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java

@@ -292,6 +292,7 @@ public class SavingsAccountCharge extends AbstractPersistableCustom {
                 this.amountWaived = null;
                 this.amountWrittenOff = null;
             break;
+            default:
         }
     }
 
@@ -420,6 +421,7 @@ public class SavingsAccountCharge extends AbstractPersistableCustom {
                     this.amountPercentageAppliedTo = null;
                     this.amountOutstanding = null;
                 break;
+                default:
             }
         }
     }
@@ -494,6 +496,7 @@ public class SavingsAccountCharge extends AbstractPersistableCustom {
                     this.amountPercentageAppliedTo = null;
                     this.amountOutstanding = null;
                 break;
+                default:
             }
         }
 

fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/serialization/ShareAccountDataSerializer.java

@@ -927,6 +927,7 @@ public class ShareAccountDataSerializer {
                 case YEARS:
                     lockinDate = purchaseDate.plusYears(lockinPeriod) ;
                     break ;
+                default:
             }
         }
         return lockinDate ;