add check to ensure from and to office are not the same.

mifosng-provider/src/main/java/org/mifosng/platform/DataValidatorBuilder.java

@@ -72,6 +72,20 @@ public class DataValidatorBuilder {
 		return this;
 	}
 	
+	public DataValidatorBuilder notSameAsParameter(String linkedParameterName, Object linkedValue) {
+		if (value == null && linkedValue == null && ignoreNullValue) {
+			return this;
+		}
+		
+		if (value != null && value.equals(linkedValue)) {
+			StringBuilder validationErrorCode = new StringBuilder("validation.msg.").append(resource).append(".").append(linkedParameterName).append(".same.as.").append(parameter);
+			StringBuilder defaultEnglishMessage = new StringBuilder("The parameter ").append(linkedParameterName).append(" is same as ").append(parameter).append(".");
+			ApiParameterError error = ApiParameterError.parameterError(validationErrorCode.toString(), defaultEnglishMessage.toString(), linkedParameterName, linkedValue, value);
+			dataValidationErrors.add(error);
+		}
+		return this;
+	}
+	
 	public DataValidatorBuilder notNull() {
 		if (value == null && !ignoreNullValue) {
 			StringBuilder validationErrorCode = new StringBuilder("validation.msg.").append(resource).append(".").append(parameter).append(".cannot.be.blank");

mifosng-provider/src/main/java/org/mifosng/platform/organisation/service/BranchMoneyTransferCommandValidator.java

@@ -33,6 +33,10 @@ public class BranchMoneyTransferCommandValidator {
 			baseDataValidator.reset().parameter("fromOfficeId").value(command.getFromOfficeId()).notNull();
 		}
 		
+		if (command.getFromOfficeId() != null && command.getToOfficeId() != null) {
+			baseDataValidator.reset().parameter("fromOfficeId").value(command.getFromOfficeId()).notSameAsParameter("toOfficeId", command.getToOfficeId());
+		}
+		
 		baseDataValidator.reset().parameter("transactionDate").value(command.getTransactionLocalDate()).notNull();
 		baseDataValidator.reset().parameter("currencyCode").value(command.getCurrencyCode()).notBlank();
 		baseDataValidator.reset().parameter("transactionAmount").value(command.getTransactionAmountValue()).notNull();