FINERACT-724 fixes after review (part2)

fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/PaginationHelper.java

@@ -32,7 +32,6 @@ public class PaginationHelper<E> {
         final List<E> items = jt.query(sqlFetchRows, args, rowMapper);
 
         // determine how many rows are available
-//        final int totalFilteredRecords = jt.queryForInt(sqlCountRows);
         final int totalFilteredRecords = jt.queryForObject(sqlCountRows, Integer.class);
 
         return new Page<>(items, totalFilteredRecords);

fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaDialect.java

@@ -38,6 +38,14 @@ import org.springframework.transaction.SavepointManager;
 import org.springframework.transaction.TransactionDefinition;
 import org.springframework.transaction.TransactionException;
 
+/**
+ * {@link org.springframework.orm.jpa.JpaDialect} implementation for Apache OpenJPA.
+ * Developed and tested against OpenJPA 2.2.
+ *
+ * @author Costin Leau
+ * @author Juergen Hoeller
+ * @since 2.0
+ */
 public class OpenJpaDialect extends DefaultJpaDialect {
 
 	@Override

fineract-provider/src/main/java/org/apache/fineract/infrastructure/openjpa/OpenJpaVendorAdapter.java

@@ -30,7 +30,19 @@ import org.apache.openjpa.persistence.PersistenceProviderImpl;
 import org.springframework.orm.jpa.vendor.AbstractJpaVendorAdapter;
 import org.springframework.orm.jpa.vendor.Database;
 
-
+/**
+ * {@link org.springframework.orm.jpa.JpaVendorAdapter} implementation for Apache OpenJPA.
+ * Developed and tested against OpenJPA 2.2.
+ *
+ * <p>Exposes OpenJPA's persistence provider and EntityManager extension interface,
+ * and supports {@link AbstractJpaVendorAdapter}'s common configuration settings.
+ *
+ * @author Costin Leau
+ * @author Juergen Hoeller
+ * @since 2.0
+ * @see org.apache.openjpa.persistence.PersistenceProviderImpl
+ * @see org.apache.openjpa.persistence.OpenJPAEntityManager
+ */
 public class OpenJpaVendorAdapter extends AbstractJpaVendorAdapter {
 
 	private final PersistenceProvider persistenceProvider = new PersistenceProviderImpl();

fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java

@@ -147,7 +147,6 @@ public class TenantAwareBasicAuthenticationFilter extends BasicAuthenticationFil
                 }
             }
 
-//            filterChain.doFilter(request, response);
             super.doFilterInternal(request, response, filterChain);
         } catch (final InvalidTenantIdentiferException e) {
             // deal with exception at low level

fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/scheduler/SmsMessageScheduledJobServiceImpl.java

@@ -286,8 +286,7 @@ public class SmsMessageScheduledJobServiceImpl implements SmsMessageScheduledJob
                         if (!smsMessageDeliveryReportData.getHasError()
                                 && (deliveryStatus != 100)) {
                             SmsMessage smsMessage = this.smsMessageRepository.findById(smsMessageDeliveryReportData.getId()).orElse(null);
-                            Integer statusType;
-                            boolean statusChanged;
+                            Integer statusType = smsMessage.getStatusType();
 
                             switch (deliveryStatus) {
                                 case 0:
@@ -312,7 +311,7 @@ public class SmsMessageScheduledJobServiceImpl implements SmsMessageScheduledJob
                                 break;
                             }
 
-                            statusChanged = !statusType.equals(smsMessage.getStatusType());
+                            boolean statusChanged = !statusType.equals(smsMessage.getStatusType());
 
                             // update the status Type enum
                             smsMessage.setStatusType(statusType);

fineract-provider/src/main/resources/META-INF/spring/appContext.xml

@@ -34,8 +34,6 @@
 	<sec:global-method-security
 		pre-post-annotations="enabled" />
 
-<!--	<tx:annotation-driven />-->
-
 	<context:component-scan
 		base-package="org.apache.fineract.accounting.*,
 									      org.apache.fineract.commands.provider.*,

fineract-provider/src/test/java/org/apache/fineract/notification/StorageTest.java

@@ -19,7 +19,7 @@
 
 package org.apache.fineract.notification;
 
-import edu.emory.mathcs.backport.java.util.Collections;
+import java.util.Collections;
 import org.apache.fineract.notification.domain.Notification;
 import org.apache.fineract.notification.domain.NotificationMapper;
 import org.apache.fineract.notification.service.NotificationGeneratorReadRepositoryWrapper;