Michael Vorburger
9da5932307
bulk auto reformat ca. 2900 files using ./gradlew :spotlessApply [FINERACT-1006]
2020-06-14 18:31:47 +02:00
Michael Vorburger
64628345a0
remove (old, bad) SchedulerJobHelper.executeJob() [FINERACT-922]
2020-06-14 17:51:57 +02:00
Michael Vorburger
67e6e27b54
fix broken tests under JUnit 5 [FINERACT-1021]
2020-06-14 17:21:07 +02:00
rrpawar96 and Michael Vorburger ⛑️
3f04247ceb
gsim_glim_documentation
2020-06-14 16:02:42 +02:00
e8ecd79b9d
FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob ( #1049 )
...
Co-authored-by: Michael Vorburger ⛑️ <mike@vorburger.ch >
2020-06-14 14:09:41 +02:00
percyashu and Michael Vorburger ⛑️
3564f98689
FINERACT-822 enable MissingOverride error
2020-06-14 14:04:17 +02:00
percyashu and Michael Vorburger ⛑️
de20a987ae
FINERACT-822 enable EqualsUnsafeCast error check
2020-06-14 14:03:55 +02:00
percyashu and Michael Vorburger ⛑️
4b46f27253
FINERACT-822 enable JodaPlusMinusLong error
2020-06-14 13:59:05 +02:00
percyashu and Michael Vorburger ⛑️
7c6b15e3bc
FINERACT-822 enable ImmutableEnumChecker error
2020-06-14 13:51:50 +02:00
Manthan Surkar and Michael Vorburger ⛑️
bc7d75d7b2
FINERACT-942 Added and Enforced EmptyCatchBlock checkstyle
2020-06-14 13:37:08 +02:00
xurror and Michael Vorburger ⛑️
f2624b584c
FINERACT-1021 - Update to JUnit 5
2020-06-14 12:52:18 +02:00
xurror and Michael Vorburger ⛑️
ca97a37544
FINERACT-1022 - Update to org.ehcache
2020-06-13 14:21:45 +02:00
percyashu and Yemdjih Kaze Nasser
17cb620ec0
FINERACT-822 enable BigDecimalEquals error
2020-06-13 11:34:49 +01:00
percyashu and Yemdjih Kaze Nasser
73a8816f13
FINERACT-822 enable MixedMutabilityReturnType error
...
FINERACT-822 enable MixedMutabilityReturnType error
2020-06-13 11:29:25 +01:00
Manthan Surkar and Michael Vorburger ⛑️
885a501c64
INERACT-821 Added and Enforced EmptyBlock Checkstyle
2020-06-11 23:50:04 +02:00
thesmallstar and Michael Vorburger ⛑️
99c667ab1a
FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle
2020-06-11 23:38:15 +02:00
percyashu and Michael Vorburger ⛑️
cd5fed5eda
FINERACT-822 enable ReferenceEquality error
2020-06-11 22:32:37 +02:00
Manthan Surkar and Michael Vorburger ⛑️
dae424da1a
FINERACT-821 Made changes to enforce ConstantName Checkstyle (3)
2020-06-11 22:23:26 +02:00
percyashu and Michael Vorburger ⛑️
15f244c09f
FINERACT-822 enable InconsistentCapitalization error
2020-06-11 21:55:11 +02:00
thesmallstar and Michael Vorburger ⛑️
f88c244053
FINERACT-821 Added and Enforced AnnotationLocation(2) Checkstyle
2020-06-11 21:50:49 +02:00
thesmallstar and Michael Vorburger ⛑️
a582ec63ee
FINERACT-942 Added and Enforced IllegalThrows checkstyle
2020-06-11 21:36:42 +02:00
percyashu and Michael Vorburger ⛑️
23ffe45ceb
minor JavaDoc fix in SearchParameters
2020-06-09 20:42:55 +02:00
percyashu and Michael Vorburger ⛑️
4c004f0a87
FINERACT-822 enable DoubleBraceInitialization error
2020-06-09 20:42:08 +02:00
Josue Araujo and Michael Vorburger ⛑️
4e9914ae6f
* Added missing quotes in query. (FINERACT-897 https://github.com/apache/fineract/pull/757 )
2020-06-09 07:56:34 +02:00
percyashu and Yemdjih Kaze Nasser
731079ede7
FINERACT-822 enable JdkObsolete error
2020-06-08 13:07:10 +01:00
percyashu and Michael Vorburger ⛑️
829cfb1911
FINERACT-822 enable EqualsGetClass error
2020-06-08 07:11:44 +02:00
percyashu and Michael Vorburger ⛑️
f226bbae6e
FINERACT-822 enable EqualsGetClass error
2020-06-08 07:11:44 +02:00
Petri Tuomola and Michael Vorburger ⛑️
a54c124449
FINERACT-899: Fixing AccountingScenarioIntegrationTests
2020-06-08 07:04:28 +02:00
Petri Tuomola and Michael Vorburger ⛑️
b31e6c2881
FINERACT-1019: Fix failing import integration tests
2020-06-08 07:00:15 +02:00
Petri Tuomola and Michael Vorburger ⛑️
6eb3873a5b
Fixed OfficeImportTest
2020-06-08 07:00:15 +02:00
percyashu and Yemdjih Kaze Nasser
cfe5848a02
FINERACT-822 enable OperatorPrecedence error
2020-06-08 02:32:30 +01:00
percyashu and Yemdjih Kaze Nasser
d5af661231
FINERACT-822 enable OperatorPrecedence error
2020-06-08 02:32:30 +01:00
Michael Vorburger
4528231fd1
remove bad 'default:' in SavingsEnumerations switch
...
This default: is "wrong", because it's not required - the switch,
in this particular case, *IS* actually already handling all cases.
But if in the future someone were to add an additional new
SavingsAccountTransactionType, then we would want Error Prone to
fail to signal that it needs to be handled here - but the "default:"
would "hide" that.
This is a follow-up to https://github.com/apache/fineract/pull/983/
for FINERACT-822, and also related to the discussion started on
https://github.com/apache/fineract/pull/989 .
There originally used to be a "default:" in the middle of the switch,
that obviously WAS completely wrong and an old copy-paste bug.
2020-06-07 18:40:08 +02:00
Michael Vorburger and Yemdjih Kaze Nasser
0e6a0e3ee3
remove old constructor from SchedulerJobHelper (related to FINERACT-922)
2020-06-07 13:08:08 +01:00
Manthan Surkar and Michael Vorburger ⛑️
b0ff8dbb60
FINERACT-821 Added and Enforced MethodName Checkstyle
2020-06-07 02:05:40 +02:00
Manthan Surkar and Michael Vorburger ⛑️
73e1fe77e9
FINERACT-821 Made changes to enforce ConstantName Checkstyle (2)
2020-06-07 02:03:16 +02:00
Percy Ayuk Ashu and GitHub
910eb1f7a8
FINERACT-822 enable MissingCasesInEnumSwitch error ( #989 )
2020-06-06 22:05:43 +01:00
Percy Ayuk Ashu and GitHub
cd3621cb60
FINERACT-822 Enabling ErrorProne error checks ( #983 )
2020-06-05 16:42:01 +01:00
Percy Ayuk Ashu and GitHub
78857bcf81
FINERACT-822 Enabling MultiVariableDeclaration check ( #981 )
2020-06-05 10:28:00 +01:00
Percy Ayuk Ashu and GitHub
99b0136f40
FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check ( #982 )
2020-06-05 09:10:18 +01:00
percyashu and Yemdjih Kaze Nasser
960e81af1c
FINERACT-822 Enabling UnnecessaryParentheses check
2020-06-04 02:14:25 +01:00
Petri Tuomola and Michael Vorburger ⛑️
14b14aecac
FINERACT-1017: Fixing LoanImport integration tests
2020-06-03 22:25:36 +02:00
Michael Vorburger ⛑️ and GitHub
7a2d459af3
Merge pull request #972 from percyashu/errorprone_variableNameSameAsType
...
FINERACT-822 enable variableNameSameAsType warning
2020-06-03 22:13:56 +02:00
Manthan Surkar and Michael Vorburger ⛑️
9cda5f984a
FINERACT-821 Made changes to enforce ConstantName Checkstyle (1)
2020-06-03 22:13:19 +02:00
nnatarajan and Michael Vorburger ⛑️
3521b0ed33
FINERACT-933 Fixed ArrayIndexOutOfBoundsException at ClientPersonImportHandler
2020-06-03 10:50:48 +02:00
nnatarajan and Michael Vorburger ⛑️
8d7fa73b46
FINERACT-933 Suggestion to fix ArrayIndexOutOfBoundsException
2020-06-03 10:50:48 +02:00
nnatarajan and Michael Vorburger ⛑️
97cbb13c9c
FINERACT-1004 Resolved NPE in AddressWritePlatformServiceImpl.updateClientAddress()
2020-06-03 09:55:24 +02:00
Michael Vorburger and Yemdjih Kaze Nasser
0c6903fc36
executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest
...
re. FINERACT-950 and FINERACT-922
2020-06-03 01:59:14 +01:00
percyashu
f685eb7a68
FINERACT-822 enable VariableNameSameAsType warning
2020-06-02 21:34:12 +01:00
Michael Vorburger
c95fb17f6e
minor: simplify hashCode() in CenterDomain
2020-06-02 21:15:36 +02:00
