Commit Graph
1706 Commits
Author SHA1 Message Date
nnatarajanandMichael Vorburger ⛑️ 97cbb13c9c FINERACT-1004 Resolved NPE in AddressWritePlatformServiceImpl.updateClientAddress() 2020-06-03 09:55:24 +02:00
percyashu f685eb7a68 FINERACT-822 enable VariableNameSameAsType warning 2020-06-02 21:34:12 +01:00
Michael Vorburger fd3b75711c remove line in AbstractLoanScheduleGenerator [FINERACT-977]
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
2020-06-02 19:52:30 +02:00
Percy Ayuk AshuandGitHub 16a69e7a4c FINERACT-822 enable ArgumentSelectionDefectChecker warning (#961) 2020-06-02 17:32:52 +01:00
Michael VorburgerandYemdjih Kaze Nasser 6f128bf508 minor clean-up to eliminate 'dead code' in CodeValue
This fixes one of too many ;) warnings Eclipse shows.

It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
2020-06-02 15:36:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser 619fe44d0e bump OpenPDF from 1.1.0 to 1.3.17 + swap Base64 [FINERACT-965]
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
2020-06-02 15:29:45 +01:00
Michael Vorburger d439aa9545 replace api-docs links to mifos.io with fineract.dev [FINERACT-840] 2020-06-02 13:20:17 +02:00
Saransh SharmaandMichael Vorburger ⛑️ b6e6eba56f fix possible NPE in AbstractLoanScheduleGenerator 2020-06-01 21:53:02 +02:00
percyashuandMichael Vorburger ⛑️ aed3e41ca4 FINERACT-822 Enable CompareToZero check 2020-06-01 12:43:49 +02:00
Petri TuomolaandMichael Vorburger ⛑️ e295bef743 FINERACT-918: Changes to running and debugging in Eclipse 2020-06-01 11:45:15 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 1a397c5663 FINERACT-1005: Fixing staff validations and tests 2020-06-01 10:59:22 +02:00
Vishwas Babu A JandGitHub 096d842c38 Merge pull request #924 from percyashu/FINERACT-609
FINERACT-609 TopUp
2020-05-29 22:38:42 -07:00
ManojandMichael Vorburger ⛑️ 561ea0a95e FINERACT-1008-flyway-migration-fix 2020-05-29 08:39:18 +02:00
Michael Vorburger 4b108f02ec fix broken build due to @Deprecated error [FINERACT-1012] 2020-05-28 22:36:03 +02:00
percyashuandMichael Vorburger ⛑️ e10a78b2bd FINERACT-822 Integrating Error Prone 2020-05-28 20:40:35 +02:00
percyashu c1ca960ace FINERACT-609 TopUp 2020-05-28 19:16:47 +01:00
Manthan SurkarandMichael Vorburger ⛑️ ef538e5c75 FINERACT-821 Added and Enforced ArrayTypeStyle checkstyle 2020-05-27 11:27:32 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 3e95c32e18 FINERACT-821 Added and enforced NeedBraces Checkstyle 2020-05-27 00:13:22 +02:00
Avik GangulyandGitHub 50d5d08378 Merge pull request #769 from fynmanoj/findevfdrollover
FINERACT-893-fixed-deposit-rollover
2020-05-26 21:07:42 +05:30
Manthan SurkarandMichael Vorburger ⛑️ 01e8014ea2 FINERACT-821 Added and Enforced upperEll checkstyle 2020-05-26 09:30:59 +02:00
Petri TuomolaandGitHub 562b2a1d97 FINERACT-874: Removing files related to old release process (#890) 2020-05-25 08:50:24 +01:00
Michael Vorburger ⛑️andGitHub 4cb9f9d3e0 improve logging in SchedulerTriggerListener (re. FINERACT-922) (#812) 2020-05-24 20:18:36 +01:00
Saransh SharmaandMichael Vorburger ⛑️ ce570b4b33 Fixed Accounting findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId 2020-05-24 10:43:29 +02:00
xurrorandMichael Vorburger ⛑️ 81fc89c58c Create no-args constructors for PU 2020-05-24 10:12:38 +02:00
Manoj bd99138aad FINERACT-893-fixed-deposit-rollover 2020-05-23 22:52:39 +05:30
Michael VorburgerandYemdjih Kaze Nasser 5b1c46c821 remove logback.xml (see FINERACT-888)
Read e.g. https://12factor.net/logs for why we don't want to log
to a fineract-platform.log file anymore by default.  Of course, anyone
could still customize logging as they see fit for their own deployments.
2020-05-23 12:38:20 +01:00
thesmallstarandMichael Vorburger ⛑️ baa1177854 FINERACT-821 Added and Enforced Typename checkstyle 2020-05-22 15:23:23 +02:00
nnatarajanandMichael Vorburger ⛑️ 96452f3ff4 Fineract-955 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18 2020-05-22 00:07:37 +02:00
thesmallstarandMichael Vorburger ⛑️ 16fb971f45 FINERACT-942 Remove use of printStackTrace and added checkstyle 2020-05-21 21:48:11 +02:00
xurrorandMichael Vorburger ⛑️ 3bc7914068 Update spotbugs to v4.2.0(FINERACT-986) 2020-05-21 10:52:42 +02:00
xurrorandMichael Vorburger ⛑️ dc3af0c867 FINERACT-964
bump json-path from 0.9.1 to 2.4.0
2020-05-20 00:56:20 +02:00
percyashuandMichael Vorburger ⛑️ 610375753c FINERACT-959 make javac fail for Xlint:cast 2020-05-20 00:42:20 +02:00
Michael Vorburger 5557b8be4a fix moar flaky StorageTest.testNotificationStorage() [FINERACT-828]
similar fix to earlier Pull Request for the same

also added some more toString()
2020-05-17 21:29:20 +02:00
Michael Vorburger 904da67bbd Remove un-used "Send messages to Email gateway" Job (FINERACT-952) 2020-05-17 10:56:59 +02:00
Michael Vorburger cbc274f603 remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938) 2020-05-17 10:53:42 +02:00
Michael Vorburger ⛑️andGitHub ddaffd13c0 Merge pull request #857 from xurror/FINERACT-897
[WIP] MySQL v8(FINERACT-897)
2020-05-17 02:13:49 +02:00
Michael Vorburger c764d32d5e fix Flyway table name problem (FINERACT-979) 2020-05-16 18:34:19 +02:00
thesmallstarandMichael Vorburger ⛑️ 20e8a02294 FINERACT-942 Remove bad logging pattern(Use of system.out) and added checkstyle 2020-05-16 18:13:43 +02:00
xurror 4360260ac6 FINERACT-897
make fineract compatible with both mysql5.5 and  mysql v8
2020-05-16 07:36:28 +01:00
Michael Vorburger 9ce72fe67b fix broken build
Combination of recently separately merged PRs #865 and #859 broke it.
2020-05-15 22:56:13 +02:00
Michael Vorburger ⛑️andGitHub 39675c9a23 rewrite MultiException to actually contain all causes (FINERACT-858) (#855) 2020-05-15 21:30:33 +01:00
thesmallstarandMichael Vorburger ⛑️ 9eccd61333 Added Empty Statement Check and enforced checkstyle 2020-05-15 19:43:16 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b58404be41 FINERACT-910: Serving apiDocs as part of the fineract-provider 2020-05-11 19:59:15 +02:00
xurrorandMichael Vorburger ⛑️ 2285797eff bump flyway from 2.1.1 to 6.4.1 2020-05-11 12:21:40 +02:00
Michael Vorburger 47549ae438 add toString() to Notification (to help debug FINERACT-828 next time) 2020-05-10 16:19:09 +02:00
Michael Vorburger 0cc18d7b8c fix obvious bug in Notification setActor()
This method doesn't seem to be used anywhere, so it never mattered.

Eclipse pointed out "The assignment to variable actorId has no effect".

We should not ignore javac/Eclipse compiler warnings! => FINERACT-959
2020-05-10 16:19:09 +02:00
Michael Vorburger e122f1ffd3 fix bug causing NullPointerException in SavingsAccount (FINERACT-957) 2020-05-09 13:31:39 +02:00
Michael Vorburger 27d754529e bulk replace org.apache.commons.lang with lang3 imports (FINERACT-954)
We apparently currently have both on the classpath, but really nowadays
should have, and can, only use lang3 with this minor clean up.
2020-05-09 05:48:31 +02:00
Michael Vorburger ff1c15d263 rm application.properties from Git, and .gitignore it (because we copy it during build) 2020-05-09 00:03:57 +02:00
Michael Vorburger ⛑️andGitHub bee3fb7ce5 add java.util.Date ISO-8601 GSON type adapter (FINERACT-926) (#816)
* minor clean-up in existing JsonSerializer implementations (FINERACT-926)

* centralize registration of GSON type adapters (FINERACT-926)

* add java.util.Date ISO-8601 GSON type adapter (FINERACT-926)
2020-05-08 19:56:19 +01:00