Commit Graph
26 Commits
Author SHA1 Message Date
Michael Vorburger dd7503f296 remove all trailing spaces in Java files (FINERACT-821)
find . -type f -name "*.java" -exec sed -i 's/ *$//' '{}' ';'
2020-01-19 19:58:21 +01:00
Michael Vorburger b0196049f1 replace 51013 Tabs with 4 Spaces in 3122 Java files (FINERACT-821)
rpl -eRxjava "\t" "    " .
2020-01-19 19:58:21 +01:00
Michael Vorburger 6ca1a678cb more SpotBugs related / inspired code clean up (see FINERACT-702)
based upon code review of changes made by @awasum in previous commit:

 - fix clear contains() GC_UNRELATED_TYPES bug in Loan

 - fix clear equals() EC_UNRELATED_TYPES bug in Loan

 - fix more equals() & hashCode() in...
    * Charge
    * TrialBalance
    * LoanProductBorrowerCycleVariations
    * LoanProductProvisioningEntry

 - fix AccountingConstants to avoid using @FindBugsSuppressWarnings

 - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings

 - minor clean up in build.gradle (spotbugs has replaced findbugs)

PS: This change originally included also fixing the missing hashCode()
    and equals() in ShareAccountCharge, but that turned out to be non
    trivial, see FINERACT-827, and is thus not yet fixed by this.
2020-01-13 08:41:16 +01:00
Awasum YannickandMichael Vorburger ⛑️ af0dd7e5f3 use SpotBugs & fix over 300 high priority rule violations (FINERACT-702)
This PR also serves as a base solution for upcoming FINERACT-712 and
FINERACT-696.  It includes using Objects.equals() to prevent NPEs, and
adding gradle check to run SpotBugs on Travis CI.

PS: SpotBugs is the successor to (and same code as) FindBugs.
2020-01-12 13:16:42 +01:00
xurrorandMichael Vorburger ⛑️ 0440a36317 remove todos from XBRLBuiderTest 2019-12-01 17:12:25 -08:00
ibondarenko de77996e66 FINERACT-724 fixes after review (part2) 2019-11-12 10:36:27 +02:00
ibondarenko 43fd8618ad implementation of FINERACT-724 (Upgrade Spring Boot, Spring and Spring Security to their latest stable version) 2019-11-12 10:36:27 +02:00
Vishwas Babu A JandGitHub cd839953e1 Merge pull request #596 from vorburger/enable-TemplateMergeServiceTest-compileHelloTemplate
re-enable commented out TemplateMergeServiceTest.compileHelloTemplate (which actually passes)
2019-07-08 09:28:27 +05:30
Michael Vorburger.ch 7030f1fa4c re-activate unit tests (see FINERACT-776) 2019-07-03 23:23:12 +02:00
Michael Vorburger ⛑️ 702e15e0f4 re-enable commented out test (which actually passes) 2019-07-01 21:23:26 +02:00
Anh3handAvik Ganguly 0b0212966c Add Spring Events to be used when activemq is not available 2017-12-13 18:04:36 +05:30
Anh3handAvik Ganguly 7395d6c543 Notification sub-system 2017-12-13 18:04:36 +05:30
Nazeer Hussain Shaik 84927eb5b6 TemplateMergeServiceTest.compileLoanSummary always fails on windows environment 2017-12-05 11:56:49 +05:30
nazeer shaik 2e00bff557 FINERACT-467 : equal amortization 2017-10-31 19:10:14 +05:30
Adhyan c60c6601c0 Added Notification Module
Added Notification Module

Added Notification Module

Added Notification Module

Added license file for jar analyzer

Added entry into LICENSE_RELEASE file

Added gradle wrapper
2017-08-20 21:21:24 +05:30
nikpawar89 34de03e045 formatted creditbureau configuration 2017-06-09 14:36:53 +05:30
Nazeer Hussain Shaik 9e5e7329ad Removing Hibernate annotations 2016-06-28 11:09:42 +05:30
Vishwa 763cf18b90 FINERACT-60 : Interest compounding, nth day rest frequency and meeting calendar date changes 2016-05-04 17:27:00 +05:30
Nazeer Hussain Shaik 93e615badd Merge branch 'PULLREQUEST68' into develop 2016-04-26 11:34:44 +05:30
guptas9 abc5290563 added licence headers 2016-04-11 04:12:52 -04:00
binnygopinath 437de26c33 FINERACT-94: Flexible morotorium(only principal portion) 2016-04-07 10:44:02 +05:30
unknown 2a45fe1390 Connector changes from mysql to drizzle 2016-02-08 11:27:46 +05:30
Adi Narayana Raju ee2819b793 License text spill overs 2016-02-01 16:48:06 +05:30
Adi Narayana Raju 7098d7f83d Modify file contents 2016-02-01 12:05:28 +05:30
Adi Narayana Raju 494ba87c4c Rename java root packages 2016-02-01 11:34:52 +05:30
Adi Narayana Raju 139e066d3d Rename root folders 2016-02-01 11:00:15 +05:30