Commit Graph
100 Commits
Author SHA1 Message Date
Michael Vorburger.ch b059afda32 remove clean in .travis.yml 2019-09-17 20:18:22 +02:00
Michael Vorburger.ch 06ed8468b8 fix .travis.yml so that integrationTest does not run if test already failed 2019-09-04 22:26:53 +02:00
Michael Vorburger.ch 8a40c6f40f bump Gradle version from 5.2.1 to 5.6.1
all changed/new files have been created by:

./gradlew wrapper --gradle-version=5.6.1 --distribution-type=bin
2019-09-04 22:22:48 +02:00
Michael Vorburger.ch c90888f1bb tweak .gitpod.yml and add https://gitpod.io badge to README
- add ASL header (required by ASF RAT)
- change port to 8080 (TODO what was 8005 ?)
- add commands to create DBs
- fix .gitpod.yml database creation
- refine ports in .gitpod.yml
- add port 8081 to ignore in .gitpod.yml
- use test instead of (too slow) integrationTest in .gitpod.yml
- fix .gitpod.yml
  by using https://yaml-multiline.info to fix start-up problem
  due to comment inside tasks / command; ACK Tx to @meysholdt
  for pointing out the right trick here.

see https://github.com/apache/fineract/pull/598/
2019-09-04 22:09:41 +02:00
Michael Vorburger.ch 89334bdb95 make integrationTest await application health readyness
This was an idea I had when wondering if the problem we hit
during the Gradle upgrade was just that Tomcat took longer to
boot Fineract (it turned out that that wasn't the cause).

I'm not sure if gradle-tomcat-plugin already does the equivalent
(but suspect it does not), but given that integrationTests work,
not entirely clear how much value this really adds.

Given that it doesn't really hurt either, perhaps we can add it anyway.
2019-09-04 19:18:03 +02:00
Michael Vorburger.ch ea076cd5c6 put back the TZ (re. FINERACT-788)
always best to make only mininmal required change
2019-08-23 17:36:57 +02:00
Michael Vorburger ⛑️ 2fdd9d14b6 rm hardcoded system time from .travis.yml (fixes FINERACT-788) 2019-08-23 17:36:57 +02:00
Michael Vorburger ⛑️andGitHub c4301843bd link to FAQ from README 2019-08-22 09:25:29 +02:00
Michael Vorburger.ch f13c076862 rm git & JDK from Dockerfile
Now that we separated the build and runtime containers,
we can have only a JRE but not a JDK in the runtime container
(whereas the builder container will still have a JRE).

This makes for a smaller, and more importantly,
more secure, runtime container image.

Also removing git from runtime container, as it's not used.
2019-07-23 10:17:56 +02:00
Michael Vorburger.ch 81c1468fa4 use multi-stage build in Dockerfile (fixes FINERACT-771) 2019-07-23 10:12:25 +02:00
Michael Vorburger ⛑️andGitHub c5e7ae274a add links to Docker Hub to README (badges & text)
see https://issues.apache.org/jira/browse/INFRA-18673
2019-07-11 10:14:21 +02:00
Michael Vorburger.ch 8be550d077 switch bval dependency from compile to implementation (see FINERACT-777) 2019-07-11 08:46:35 +02:00
Michael Vorburger.ch bcef09d7be upgrade OpenJPA 2.4.1 to 2.4.3
because 2.4.1 was not yet Java 11 compatible (due to an old ASM)

I'd like to upgrade to Java 11 soon-ish, and am starting to experiment with it.
2019-07-11 08:41:36 +02:00
Michael Vorburger ⛑️andGitHub 04efaca1ca Merge pull request #525 from vorburger/bump-gradle-wrapper
FINERACT-700: upgrade Gradle from 2.10 to 5.2.1
2019-07-11 08:28:54 +02:00
Michael Vorburger.ch 2fc98df21c fix ClassCircularityError: java/util/logging/LogRecord (see FINERACT-700 for details) 2019-07-10 23:47:51 +02:00
Michael Vorburger ⛑️andGitHub 9f0147d7d0 Merge branch 'develop' into bump-gradle-wrapper 2019-07-10 18:45:21 +02:00
Michael Vorburger.ch 46a9da6c9b silence Spring Boot Actuator Audit INFO logging (fixes FINERACT-779) 2019-07-10 10:28:21 +02:00
Michael Vorburger.ch e2b2e66610 fix integrationTest (=> runWar) which broke in Gradle upgrade
inspired by (but not exactly like) the respective section on
https://github.com/bmuschko/gradle-tomcat-plugin#faq
2019-07-09 22:09:11 +02:00
Michael Vorburger.ch 6eae392805 add spring-boot-starter-actuator dependency
see https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-endpoints.html
2019-07-09 21:05:53 +02:00
Michael Vorburger.ch 9a4cb83bd5 upgrade gradle-tomcat-plugin from 1.0 to 2.5 (NOK) 2019-07-09 18:18:13 +02:00
Michael Vorburger.ch b54a11da9b fix gradle createDB/dropDB/setBlankPassword
which broke during the Gradle upgrade in FINERACT-700

do not fix Flyway related migrateTenantDB & Co, as those
are proposed to be removed in FINERACT-765 anyway.  (If really
needed, some of my other WIP branches have the required changes
to make the Flyway related tasks work.)
2019-07-09 10:04:03 +02:00
Michael Vorburger.ch 6f58b30fd8 gradle.properties with -Xmx4g and disabling daemon
because the (new, upgraded) Tomcat Gradle plugin needs more memory
(and this seems to make the build a bit faster, may be less is fine),
and it does not work with the Gradle daemon; this fixes:

> Task :tomcatRunWar
Failed to initialize end point associated with ProtocolHandler ["http-bio-8080"]
Failed to initialize connector [Connector[HTTP/1.1-8080]]
Failed to initialize end point associated with ProtocolHandler ["ajp-bio-8009"]
Failed to initialize connector [Connector[AJP/1.3-8009]]
Failed to initialize end point associated with ProtocolHandler ["http-bio-8443"]
Failed to initialize connector [Connector[HTTP/1.1-8443]]

which appears on the 2nd (only!) run of `./gradlew tomcatRunWAR`
(because the Tomcat embedded in the previous daemon-ized Gradle did not stop).
2019-07-09 10:04:03 +02:00
Michael Vorburger fd74931390 upgrade (switch) OpenJPA Gradle plugin (FINERACT-700)
from at.schmutterer.oss.gradle:gradle-openjpa
to com.radcortez.gradle:openjpa-gradle-plugin

due to https://github.com/schmutterer/gradle-openjpa/issues/8
2019-07-09 10:04:03 +02:00
Michael Vorburger 1ee141bb87 upgrade spring-boot-gradle-plugin, and deal with impacts (FINERACT-700)
because the old one previously used caused an UnsupportedOperationException
with the new Gradle, see https://issues.apache.org/jira/browse/FINERACT-700

The spring-jms and activemq-broker versions are set to what they were on before.
2019-07-09 10:02:13 +02:00
Michael Vorburger 84d57dbe5b upgrade Gradle version, and deal with impacts (FINERACT-700)
https://discuss.gradle.org/t/could-not-get-unknown-property-classesdir-for-main-classes-of-type-org-gradle-api-internal-tasks-defaultsourcesetoutput/30570

https://discuss.gradle.org/t/gradle-4-replacing-deprecated-test-testclassesdir/22822/2

https://discuss.gradle.org/t/could-not-find-method-leftshift-for-arguments-on-task-of-type-org-gradle-api-defaulttask/30614
2019-07-09 09:52:37 +02:00
Michael Vorburger.ch a87b3a0a4d use openjpa (with real dependencies) instead of shaded openjpa-all 2019-07-09 09:48:18 +02:00
Michael Vorburger.ch 8bdc134a8e replace Apache BVal @NotEmpty annotation by javax.validation (re. FINERACT-777) 2019-07-08 09:48:01 +02:00
Michael Vorburger.ch dd4923888b upgrade Drizzle JDBC from 1.3 to 1.4 2019-07-04 10:43:05 +02:00
Michael Vorburger.ch 0c2b1dc6dc remove Flyway completely from Gradle build (fixes FINERACT-765)
we (of course), still, but only, run it in-App at runtime boot

This is a clean-up which removes something we don't actually need.

Most importantly, it unblocks the Gradle upgrade in FINERACT-700,
where this doesn't work anymore anyway (and while there's a fix
making it work on one of my branches, it seems simpler to just
remove it).
2019-07-04 10:39:55 +02:00
Michael Vorburger.ch db67fec6b9 add "Instructions how to run for local development" to README
hoping to change "tomcatRunWAR" to "bootRun", later (FINERACT-730/FINERACT-764)
2019-07-04 10:20:58 +02:00
Michael Vorburger.ch e960d40906 comment out PMD & FindBugs
Too slow, and nobody looked at it in years anyway.
The idea is to later re-activate, with enforcement.

see also https://issues.apache.org/jira/browse/FINERACT-712
2019-07-04 09:32:48 +02:00
Michael Vorburger.ch b0a4069da6 upgrade Apache Tomcat from 7.0.54 to 7.0.94
This fixes the following weird problem I ran into
during the Gradle & Spring Boot / OpenJPA Gradle plugins upgrades;
it's likely some Tomcat bug that got fixed between .54 and .94:

Unable to process resource element [jndi:/localhost/fineract-provider/WEB-INF/classes/org/apache/fineract/.../*.class] for annotations
2019-07-04 09:26:39 +02:00
Michael Vorburger.ch d3e977cc99 use slf4j instead Apache Commons Logging in CustomAuthenticationFailureHandler 2019-07-04 08:44:30 +02:00
Michael Vorburger.ch e478b02931 ditch un-used import of (very old) serp.util.Strings 2019-07-04 08:43:02 +02:00
Michael Vorburger.ch e97b12a3f9 make OpenJPA version, used twice, a variable, instead of repeating it 2019-07-03 23:40:17 +02:00
Michael Vorburger.ch c296c314b3 move versions in build.gradle
so that the buildscript block can already use them
2019-07-03 23:40:17 +02:00
Michael Vorburger.ch 7030f1fa4c re-activate unit tests (see FINERACT-776) 2019-07-03 23:23:12 +02:00
Michael Vorburger.ch 629cd4da12 add missing license header to .dockerignore 2019-07-03 21:57:28 +02:00
Michael Vorburger.ch dd438f9b36 add suitable .dockerignore
This reduces the `docker build` time spent in
`STEP 6: COPY . fineract` from about 6m to 3m,
because it avoids copying locally built artifacts
into the container (which we don't need there, we're
just about to re-build them in the container anyway).

This also provides better isolation from the local dev
environment and the should lead to more reproducible
container builds.
2019-07-02 08:46:13 +02:00
Michael Vorburger ⛑️ 913f018f0f clean-up rm WebContent/META-INF/MANIFEST.MF
This is ancient, and should normally not be required anymore, now.

Gradle would add it, if required.
2019-07-01 21:29:08 +02:00
Michael Vorburger ⛑️ 702e15e0f4 re-enable commented out test (which actually passes) 2019-07-01 21:23:26 +02:00
Michael Vorburger.ch fc01dd25b7 fix minor SQL syntax problem in V271__accounting_for_client_charges.sql 2019-06-20 21:06:48 +02:00
Michael Vorburger.ch 720a39d9d2 rename SQL Query Parameters (fixes FINERACT-766) 2019-06-16 23:47:15 +02:00
Michael Vorburger.ch 4bd29f9b4d Clarify instructions to download gradle wrapper (see #587) 2019-06-14 14:45:06 +02:00
Michael Vorburger.ch 4a94b8b6b8 Revert "remove Instructions to download gradle wrapper from README" (see #587)
This reverts commit 92bdd539e5.
2019-06-14 14:45:06 +02:00
Michael Vorburger.ch 0d246d44a1 run integrationTest on Travis without gradlew migrateTenantDB/migrateTenantListDB (re. FINERACT-765) 2019-06-14 14:11:20 +02:00
Michael Vorburger.ch 34e6a4f81e fix ./gradlew createDB / dropDB / setBlankPassword 2019-06-14 01:29:10 +02:00
Michael Vorburger ⛑️andGitHub fc7a5dd5fc add link to .travis.yaml and fix typo in README 2019-06-13 23:55:56 +02:00
Michael Vorburger ⛑️andGitHub 878cade280 minor README clean up to remove more left over Gradle wrapper mentions 2019-06-13 23:45:04 +02:00
Michael Vorburger ⛑️andGitHub 3cf395da72 document how to run mysql in docker container in README 2019-06-13 23:41:21 +02:00
Michael Vorburger.ch b8397a4304 add blurb re. LGPL JDBC Driver to README (fixes LEGAL-462) 2019-06-12 21:17:29 +02:00
Michael Vorburger.ch 82d79b91fe use MariaDB ConnectorJ instead of Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761) 2019-06-12 21:17:29 +02:00
Michael Vorburger.ch 02d51b115a use Ubuntu Trusty instead of Xenial on Travis CI (fixes FINERACT-763)
see https://issues.apache.org/jira/browse/FINERACT-763

re. https://changelog.travis-ci.com/xenial-as-the-default-build-environment-99476
2019-06-12 21:15:49 +02:00
Michael Vorburger ⛑️andGitHub 92bdd539e5 remove Instructions to download gradle wrapper from README
as already removed from Requirements in previous commit 2f80674a2c

because the Gradle Wrapper is available in fineract-provider/gradle/wrapper and therefore not a pre-requisite to contribute
2019-06-12 09:28:36 +02:00
Michael Vorburger ⛑️andGitHub 2f80674a2c remove gradle-wrapper.jar requirement from README
because it is available in fineract-provider/gradle/wrapper and therefore not a pre-requisite to contribute
2019-06-12 09:24:09 +02:00
Michael Vorburger ⛑️andGitHub 2cb760f5e8 Use gradlew --console=plain, hoping to reduce output (FINERACT-732) (#548) 2019-03-12 13:58:40 +01:00
Michael Vorburger 977b74d6d1 remove gradle --info in .travis.yml (FINERACT-732) 2019-03-11 15:38:50 +01:00
Michael Vorburger 85de3db37d link to (new) "Pull Request Size Limit" page on Wiki
from the new Governance and Policies section in the README
2019-03-08 11:44:12 +01:00
Michael Vorburger ea49d9d17b link to (existing) Committer page on Wiki
from the new Governance and Policies section in the README
2019-03-08 11:25:44 +01:00
Michael Vorburger 002f969eef Revert "add new Governance and Policies section to Readme"
This reverts commit 20402e6d27.

I meant to raise that as Pull Request for discussion, not
force push it directly (just pressed the wrong button).
2019-03-08 03:33:01 +01:00
Michael Vorburger ⛑️andGitHub 20402e6d27 add new Governance and Policies section to Readme
With wording prohibiting PRs of thousands of lines.
2019-03-08 03:31:03 +01:00
Michael Vorburger fa41f0cc7a Merge branch 'naman-kapoor-patch-1' into develop
* naman-kapoor-patch-1:
  Update README.md
2019-02-16 00:21:05 +01:00
Michael Vorburger ⛑️andGitHub e340e34f60 Merge branch 'develop' into patch-1 2019-02-16 00:20:20 +01:00
Michael Vorburger e55b093cab remove 'clean' from .travis.yml 2019-02-14 00:11:37 +01:00
Michael Vorburger 42aaf54945 FINERACT-697: add Travis CI 'badge' to README 2019-02-13 23:52:14 +01:00
Michael Vorburger ⛑️andGitHub 20e4c8e527 FINERACT-697: add .travis.yml (and rm old un-used *build.sh) (#518) 2019-02-13 23:24:48 +01:00
Michael Vorburger 35a9b7b47e fix missing & bad license headers and config (req. for TravisCI FINERACT-697) 2019-02-13 22:36:17 +01:00
Michael Vorburger da59a50299 MIFOS-2144 TemplateMergeService expandMapArrays + @Test arrayUsingIndex
TemplateMergeService clean up, incl. proper logging
TemplateMergeServiceTest fixed up, incl. fix compileLoanSummary() now()
TemplateMergeServiceTest arrayUsingLoop
TemplateMergeServiceTest simplified
Gradle License check exclude **/*.html for src/test/resources/template-expected.html
2015-08-08 10:52:44 +05:30
Michael Vorburger 48ee0c9739 Merge pull request #1291 from vorburger/MIFOSX-1758_apps_git_submodule
MIFOSX-1758 Make dist ZIP include community-app in apps/ via Git submodule
2015-03-17 23:31:25 +01:00
Michael Vorburger ac75cc9ba6 MIFOSX-1758 Make the dist ZIP include the community-app in apps/ via Git submodule
Root build.sh, for both back-end and front-end
Added -Penv=dev to incl. MariaDBj4
Include apps/**/* in ZIP, fixed UI URL in launcher, some doc
Set submodule Git rev to one that actually exists on remote
Don't use 'git submodule update --remote' but foreach ..
build-cloudbees.sh makes npm available
Better logging, and trying dev and prod dist UI
2015-03-17 23:22:43 +01:00
Michael Vorburger 2a800bf367 Merge pull request #1295 from channagayan/licenceError
ConcurrencyIntegrationTest licenceIssue fixed
2015-03-13 09:04:40 +01:00
Michael Vorburger f440f294ad Merge pull request #1226 from vorburger/MIFOSX-1756_UseAppsInsteadWebAndDocUpdate
MIFOSX-1756 Follow-up, switched to using (existing) /apps/ instead /web/...
2015-03-10 12:20:23 +01:00
Michael Vorburger 4ad30d91d9 MIFOSX-1756 Follow-up, switched to using (existing) /apps/ instead /web/, and slightly updated the doc 2014-12-30 01:57:41 +01:00
Michael Vorburger 74242ed036 Merge pull request #1201 from binaryking/MIFOSX-1756
MIFOSX-1756 Make it easy for Static Web Content such as the community-app to be served by the new standalone end-user server (not development)
2014-12-29 18:30:16 +01:00
Michael Vorburger 37333266aa Merge pull request #1220 from vorburger/UpgradeMariaDB4jFromv211To213ToFixWindows
MIFOSX-1552 Upgraded MariaDB4j dependency from v2.1.1 to v2.1.3, to fix Windows problem
2014-12-29 17:13:47 +01:00
Michael Vorburger 8971723d96 Upgraded MariaDB4j dependency from v2.1.1 to v2.1.3, to fix Windows problem 2014-12-27 01:41:06 +01:00
Michael Vorburger 9ec0d7acd5 .travis.yml config to cache Gradle/Maven repos (~/.m2 & .gradle)
This will lead to faster PR builds, and more importantly more reliable ones, as we should have
less bad PRs due to spurious build failures due to unreachable http://repository.pentaho.org.
With Doc + cache APT too (just as an example for later NPM builds)
2014-12-16 19:34:33 +01:00
Michael Vorburger 45790c3a60 Merge pull request #1189 from MegaAlex/MIFOSX-1701
MIFOSX-1701 Add option to display only active group members
2014-12-16 19:18:32 +01:00
Michael Vorburger ba52924e2f Added missing license headers which made all the PRs fail on Travis. 2014-12-16 19:02:53 +01:00
Michael Vorburger 2c511e8e28 Merge pull request #1187 from binaryking/MIFOSX-969
MIFOSX-969 Missing API Documentation for Collection Sheets
2014-12-13 19:01:11 +01:00
Michael Vorburger 77dbe27281 Un-@Igore SpringBootServerLoginTest 2014-12-04 00:15:57 +01:00
Michael Vorburger 91fc23e92a Upgraded MariaDB4j from v2.1.0 to v2.1.1, see https://github.com/vorburger/MariaDB4j/blob/master/CHANGES.md 2014-12-04 00:13:46 +01:00
Michael Vorburger 0b501d1dcd MIFOSX-1552 war { ... war.finalizedBy(bootRepackage) } makes gradlew war
produce an executable WAR, just like standard gradlew build does (this
resolves the problem mentioned in the PS on
http://blog2.vorburger.ch/2014/09/mifos-executable-war-with-mariadb4j.html)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-09-30 01:01:17 +02:00
Michael Vorburger 00309de7e0 MIFOSX-1552 Upgrading rest-assured from v1.7.2 to v2.3.3 (incl.
reverting httpcomponents change from
848797985a +
b9cfcce1f9 as that wasn't the cause), as
that fixes the "java.lang.IllegalStateException: Unsupported cookie
spec: default at
org.apache.http.cookie.CookieSpecRegistry.getCookieSpec(CookieSpecRegistry.java:110)"

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-09-29 23:55:44 +02:00
Michael Vorburger 4b0658a685 MIFOSX-1552 Spring Boot + MariaDB4j, read
http://blog2.vorburger.ch/2014/09/mifos-executable-war-with-mariadb4j.html

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-09-22 04:04:15 +02:00
Michael Vorburger 0e2f0eb85c Fix for start-up problem if WAR is NOT unpacked (relevant e.g. for upcoming Spring Boot + MariaDB4j java -jar mifos.war 2014-09-22 01:03:36 +02:00
Michael Vorburger 4eb2cf6e21 Fix Flyway Core vs. Maven plug-in mess
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-09-19 00:32:42 +02:00
Michael Vorburger d55c3d4521 Merge pull request #1053 from vorburger/TravisLicenseTest
Travis will now test presence of MPL license headers for each pull request it builds
2014-08-31 15:27:24 +02:00
Michael Vorburger 8aceac3860 Updated Contributing.md with clarification that license header presence is verified on pull requests 2014-08-31 15:22:15 +02:00
Michael Vorburger e644d6f53d license-gradle-plugin updated + license header presence verified for each pull request via travis_build.sh now 2014-08-31 14:10:34 +02:00
Michael Vorburger 9730f9cc65 added correct / missing license MPL headers
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-08-31 14:05:34 +02:00
Michael Vorburger 76f064503b Merge pull request #1026 from vorburger/RemoveTestContextXML
removing (now?) apparently un-used testContext.xml
2014-08-26 23:23:55 +02:00
Michael Vorburger 8a9a57a0f4 Removed apparently not (no longer?) used old testContext.xml
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-08-26 23:11:33 +02:00
Michael Vorburger e68cba5929 Merge pull request #1024 from vorburger/SpringConfigurationTest
New SpringConfigurationTest; the first @RunWith(SpringJUnit4ClassRunner)
@vishwasbabu and @mgeiss I'm assuming you have no objection to this one, so I've merged it.
2014-08-26 22:52:43 +02:00
Michael Vorburger df4a070123 Better error handling in case a scheduler job name listed in database
cannot be found in the code (instead of the NPE currently happenig in
such cases)
 
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-08-14 23:05:10 +02:00
Michael Vorburger cd3e26f817 Fixed 'Not an managed type:' for JPA @Entity on CLI Gradle tests (PLEASE REVIEW - ok?) 2014-07-22 01:22:06 +02:00
Michael Vorburger f4483ab240 Merge branch 'ImprovedTravisGradleConsoleLog' into SpringConfigurationTest 2014-07-22 00:49:10 +02:00
Michael Vorburger 5db84b4470 Improved the logging of test failures on TravisCI 2014-07-22 00:36:55 +02:00
Michael Vorburger c30398d84a New SpringConfigurationTest; the first @RunWith(SpringJUnit4ClassRunner)
@ContextConfiguration in Mifos X. More of it to come - stay tuned.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
2014-07-21 23:28:08 +02:00
Michael Vorburger ece576e275 Fixed startup error following upgrade (spring-security-3.2.xsd) 2014-05-12 03:17:36 +02:00