Commit Graph
752 Commits
Author SHA1 Message Date
thesmallstarandMichael Vorburger ⛑️ 74b04cd4d3 FINERACT-821 Added and Enforced FinalClass checkstyle 2020-06-18 09:31:16 +02:00
kiran-vsmandMichael Vorburger ⛑️ 520ee5b82d FINERACT-976 : Client date of birth can not be greater than the client submitted on date 2020-06-16 21:28:01 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 8443f2edad FINERACT-689 Making interest rate slabs mandatory when creating 2020-06-16 21:04:34 +02:00
thesmallstarandMichael Vorburger ⛑️ c78ff0b12b FINERACT-821 Added and Enforced ParenPad Checkstyle 2020-06-16 20:58:28 +02:00
thesmallstarandMichael Vorburger ⛑️ dedd3be1dc FINERACT-821 Added and Enforced LeftCurly Checkstyle 2020-06-15 10:53:47 +02:00
thesmallstarandMichael Vorburger ⛑️ c97f0f9935 FINERACT-821 Added and Enforced OperatorWrap Checkstyle 2020-06-15 10:03:13 +02:00
thesmallstarandMichael Vorburger ⛑️ 31c69cff39 FINERACT-821 Added and Enforced GenericWhitespace Checkstyle 2020-06-15 09:53:07 +02:00
thesmallstarandYemdjih Kaze Nasser 8aab991194 FINERACT-821 Added and Enforced EmptyLineSeparator Checkstyle 2020-06-15 04:07:42 +01:00
thesmallstarandMichael Vorburger ⛑️ f6f1af9e95 FINERACT-821 Added and Enforced WhitespaceAround Checkstyle 2020-06-14 23:01:10 +02:00
Michael Vorburger 9da5932307 bulk auto reformat ca. 2900 files using ./gradlew :spotlessApply [FINERACT-1006] 2020-06-14 18:31:47 +02:00
rrpawar96andMichael Vorburger ⛑️ 3f04247ceb gsim_glim_documentation 2020-06-14 16:02:42 +02:00
e8ecd79b9d FINERACT-857: Fixing scheduler integration tests and migrating to executeAndAwaitJob (#1049)
Co-authored-by: Michael Vorburger ⛑️ <mike@vorburger.ch>
2020-06-14 14:09:41 +02:00
percyashuandMichael Vorburger ⛑️ 3564f98689 FINERACT-822 enable MissingOverride error 2020-06-14 14:04:17 +02:00
percyashuandMichael Vorburger ⛑️ de20a987ae FINERACT-822 enable EqualsUnsafeCast error check 2020-06-14 14:03:55 +02:00
percyashuandMichael Vorburger ⛑️ 4b46f27253 FINERACT-822 enable JodaPlusMinusLong error 2020-06-14 13:59:05 +02:00
percyashuandMichael Vorburger ⛑️ 7c6b15e3bc FINERACT-822 enable ImmutableEnumChecker error 2020-06-14 13:51:50 +02:00
Manthan SurkarandMichael Vorburger ⛑️ bc7d75d7b2 FINERACT-942 Added and Enforced EmptyCatchBlock checkstyle 2020-06-14 13:37:08 +02:00
xurrorandMichael Vorburger ⛑️ ca97a37544 FINERACT-1022 - Update to org.ehcache 2020-06-13 14:21:45 +02:00
percyashuandYemdjih Kaze Nasser 17cb620ec0 FINERACT-822 enable BigDecimalEquals error 2020-06-13 11:34:49 +01:00
percyashuandYemdjih Kaze Nasser 73a8816f13 FINERACT-822 enable MixedMutabilityReturnType error
FINERACT-822 enable MixedMutabilityReturnType error
2020-06-13 11:29:25 +01:00
Manthan SurkarandMichael Vorburger ⛑️ 885a501c64 INERACT-821 Added and Enforced EmptyBlock Checkstyle 2020-06-11 23:50:04 +02:00
thesmallstarandMichael Vorburger ⛑️ 99c667ab1a FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle 2020-06-11 23:38:15 +02:00
percyashuandMichael Vorburger ⛑️ cd5fed5eda FINERACT-822 enable ReferenceEquality error 2020-06-11 22:32:37 +02:00
Manthan SurkarandMichael Vorburger ⛑️ dae424da1a FINERACT-821 Made changes to enforce ConstantName Checkstyle (3) 2020-06-11 22:23:26 +02:00
percyashuandMichael Vorburger ⛑️ 15f244c09f FINERACT-822 enable InconsistentCapitalization error 2020-06-11 21:55:11 +02:00
thesmallstarandMichael Vorburger ⛑️ f88c244053 FINERACT-821 Added and Enforced AnnotationLocation(2) Checkstyle 2020-06-11 21:50:49 +02:00
thesmallstarandMichael Vorburger ⛑️ a582ec63ee FINERACT-942 Added and Enforced IllegalThrows checkstyle 2020-06-11 21:36:42 +02:00
percyashuandMichael Vorburger ⛑️ 23ffe45ceb minor JavaDoc fix in SearchParameters 2020-06-09 20:42:55 +02:00
percyashuandMichael Vorburger ⛑️ 4c004f0a87 FINERACT-822 enable DoubleBraceInitialization error 2020-06-09 20:42:08 +02:00
Josue AraujoandMichael Vorburger ⛑️ 4e9914ae6f * Added missing quotes in query. (FINERACT-897 https://github.com/apache/fineract/pull/757) 2020-06-09 07:56:34 +02:00
percyashuandYemdjih Kaze Nasser 731079ede7 FINERACT-822 enable JdkObsolete error 2020-06-08 13:07:10 +01:00
percyashuandMichael Vorburger ⛑️ 829cfb1911 FINERACT-822 enable EqualsGetClass error 2020-06-08 07:11:44 +02:00
percyashuandMichael Vorburger ⛑️ f226bbae6e FINERACT-822 enable EqualsGetClass error 2020-06-08 07:11:44 +02:00
percyashuandYemdjih Kaze Nasser cfe5848a02 FINERACT-822 enable OperatorPrecedence error 2020-06-08 02:32:30 +01:00
percyashuandYemdjih Kaze Nasser d5af661231 FINERACT-822 enable OperatorPrecedence error 2020-06-08 02:32:30 +01:00
Michael Vorburger 4528231fd1 remove bad 'default:' in SavingsEnumerations switch
This default: is "wrong", because it's not required - the switch,
in this particular case, *IS* actually already handling all cases.

But if in the future someone were to add an additional new
SavingsAccountTransactionType, then we would want Error Prone to
fail to signal that it needs to be handled here - but the "default:"
would "hide" that.

This is a follow-up to https://github.com/apache/fineract/pull/983/
for FINERACT-822, and also related to the discussion started on
https://github.com/apache/fineract/pull/989.

There originally used to be a "default:" in the middle of the switch,
that obviously WAS completely wrong and an old copy-paste bug.
2020-06-07 18:40:08 +02:00
Manthan SurkarandMichael Vorburger ⛑️ b0ff8dbb60 FINERACT-821 Added and Enforced MethodName Checkstyle 2020-06-07 02:05:40 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 73e1fe77e9 FINERACT-821 Made changes to enforce ConstantName Checkstyle (2) 2020-06-07 02:03:16 +02:00
Percy Ayuk AshuandGitHub 910eb1f7a8 FINERACT-822 enable MissingCasesInEnumSwitch error (#989) 2020-06-06 22:05:43 +01:00
Percy Ayuk AshuandGitHub cd3621cb60 FINERACT-822 Enabling ErrorProne error checks (#983) 2020-06-05 16:42:01 +01:00
Percy Ayuk AshuandGitHub 78857bcf81 FINERACT-822 Enabling MultiVariableDeclaration check (#981) 2020-06-05 10:28:00 +01:00
percyashuandYemdjih Kaze Nasser 960e81af1c FINERACT-822 Enabling UnnecessaryParentheses check 2020-06-04 02:14:25 +01:00
Petri TuomolaandMichael Vorburger ⛑️ 14b14aecac FINERACT-1017: Fixing LoanImport integration tests 2020-06-03 22:25:36 +02:00
Michael Vorburger ⛑️andGitHub 7a2d459af3 Merge pull request #972 from percyashu/errorprone_variableNameSameAsType
FINERACT-822 enable variableNameSameAsType warning
2020-06-03 22:13:56 +02:00
nnatarajanandMichael Vorburger ⛑️ 3521b0ed33 FINERACT-933 Fixed ArrayIndexOutOfBoundsException at ClientPersonImportHandler 2020-06-03 10:50:48 +02:00
nnatarajanandMichael Vorburger ⛑️ 8d7fa73b46 FINERACT-933 Suggestion to fix ArrayIndexOutOfBoundsException 2020-06-03 10:50:48 +02:00
nnatarajanandMichael Vorburger ⛑️ 97cbb13c9c FINERACT-1004 Resolved NPE in AddressWritePlatformServiceImpl.updateClientAddress() 2020-06-03 09:55:24 +02:00
percyashu f685eb7a68 FINERACT-822 enable VariableNameSameAsType warning 2020-06-02 21:34:12 +01:00
Michael Vorburger fd3b75711c remove line in AbstractLoanScheduleGenerator [FINERACT-977]
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
2020-06-02 19:52:30 +02:00
Percy Ayuk AshuandGitHub 16a69e7a4c FINERACT-822 enable ArgumentSelectionDefectChecker warning (#961) 2020-06-02 17:32:52 +01:00