Commit Graph
801 Commits
Author SHA1 Message Date
Michael Vorburger ⛑️andGitHub 7a2d459af3 Merge pull request #972 from percyashu/errorprone_variableNameSameAsType
FINERACT-822 enable variableNameSameAsType warning
2020-06-03 22:13:56 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 9cda5f984a FINERACT-821 Made changes to enforce ConstantName Checkstyle (1) 2020-06-03 22:13:19 +02:00
nnatarajanandMichael Vorburger ⛑️ 3521b0ed33 FINERACT-933 Fixed ArrayIndexOutOfBoundsException at ClientPersonImportHandler 2020-06-03 10:50:48 +02:00
nnatarajanandMichael Vorburger ⛑️ 8d7fa73b46 FINERACT-933 Suggestion to fix ArrayIndexOutOfBoundsException 2020-06-03 10:50:48 +02:00
nnatarajanandMichael Vorburger ⛑️ 97cbb13c9c FINERACT-1004 Resolved NPE in AddressWritePlatformServiceImpl.updateClientAddress() 2020-06-03 09:55:24 +02:00
Michael VorburgerandYemdjih Kaze Nasser 0c6903fc36 executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest
re. FINERACT-950 and FINERACT-922
2020-06-03 01:59:14 +01:00
percyashu f685eb7a68 FINERACT-822 enable VariableNameSameAsType warning 2020-06-02 21:34:12 +01:00
Michael Vorburger c95fb17f6e minor: simplify hashCode() in CenterDomain 2020-06-02 21:15:36 +02:00
Michael VorburgerandYemdjih Kaze Nasser 60dd63d55f executeAndAwaitJob() !executeJob() ClientSavingsIntegrationTest
re. FINERACT-852 and FINERACT-922
2020-06-02 19:49:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser a58b14c9d2 executeAndAwaitJob() !executeJob() ClientLoanIntegrationTest un-ignore
re. FINERACT-885 and FINERACT-922
2020-06-02 19:46:04 +01:00
Michael Vorburger fd3b75711c remove line in AbstractLoanScheduleGenerator [FINERACT-977]
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
2020-06-02 19:52:30 +02:00
Percy Ayuk AshuandGitHub 16a69e7a4c FINERACT-822 enable ArgumentSelectionDefectChecker warning (#961) 2020-06-02 17:32:52 +01:00
Michael VorburgerandYemdjih Kaze Nasser 6f128bf508 minor clean-up to eliminate 'dead code' in CodeValue
This fixes one of too many ;) warnings Eclipse shows.

It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
2020-06-02 15:36:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser 956a84114f improve StaffImageApiTest (for FINERACT-965 non-regression) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 83de217b64 minor clean-up in StaffImageApiTest (re. FINERACT-965) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 619fe44d0e bump OpenPDF from 1.1.0 to 1.3.17 + swap Base64 [FINERACT-965]
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
2020-06-02 15:29:45 +01:00
Michael Vorburger d439aa9545 replace api-docs links to mifos.io with fineract.dev [FINERACT-840] 2020-06-02 13:20:17 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 23fa22e096 FINERACT-855: Fixing test failures due to rounding difference 2020-06-02 13:00:00 +02:00
Saransh SharmaandMichael Vorburger ⛑️ b6e6eba56f fix possible NPE in AbstractLoanScheduleGenerator 2020-06-01 21:53:02 +02:00
percyashuandMichael Vorburger ⛑️ aed3e41ca4 FINERACT-822 Enable CompareToZero check 2020-06-01 12:43:49 +02:00
Petri TuomolaandMichael Vorburger ⛑️ e295bef743 FINERACT-918: Changes to running and debugging in Eclipse 2020-06-01 11:45:15 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 1a397c5663 FINERACT-1005: Fixing staff validations and tests 2020-06-01 10:59:22 +02:00
Vishwas Babu A JandGitHub 096d842c38 Merge pull request #924 from percyashu/FINERACT-609
FINERACT-609 TopUp
2020-05-29 22:38:42 -07:00
ManojandMichael Vorburger ⛑️ 561ea0a95e FINERACT-1008-flyway-migration-fix 2020-05-29 08:39:18 +02:00
Michael Vorburger 4b108f02ec fix broken build due to @Deprecated error [FINERACT-1012] 2020-05-28 22:36:03 +02:00
percyashuandMichael Vorburger ⛑️ e10a78b2bd FINERACT-822 Integrating Error Prone 2020-05-28 20:40:35 +02:00
percyashu c1ca960ace FINERACT-609 TopUp 2020-05-28 19:16:47 +01:00
Manthan SurkarandMichael Vorburger ⛑️ ef538e5c75 FINERACT-821 Added and Enforced ArrayTypeStyle checkstyle 2020-05-27 11:27:32 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 3e95c32e18 FINERACT-821 Added and enforced NeedBraces Checkstyle 2020-05-27 00:13:22 +02:00
Avik GangulyandGitHub 50d5d08378 Merge pull request #769 from fynmanoj/findevfdrollover
FINERACT-893-fixed-deposit-rollover
2020-05-26 21:07:42 +05:30
Manthan SurkarandMichael Vorburger ⛑️ 01e8014ea2 FINERACT-821 Added and Enforced upperEll checkstyle 2020-05-26 09:30:59 +02:00
Petri TuomolaandGitHub 562b2a1d97 FINERACT-874: Removing files related to old release process (#890) 2020-05-25 08:50:24 +01:00
Michael Vorburger ⛑️andGitHub b3da50c960 intro. SchedulerJobsHelper.executeAndAwaitJob() [FINERACT-922] (#817) 2020-05-24 20:54:37 +01:00
Michael Vorburger ⛑️andGitHub 4cb9f9d3e0 improve logging in SchedulerTriggerListener (re. FINERACT-922) (#812) 2020-05-24 20:18:36 +01:00
Saransh SharmaandMichael Vorburger ⛑️ ce570b4b33 Fixed Accounting findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId 2020-05-24 10:43:29 +02:00
xurrorandMichael Vorburger ⛑️ 81fc89c58c Create no-args constructors for PU 2020-05-24 10:12:38 +02:00
Manoj bd99138aad FINERACT-893-fixed-deposit-rollover 2020-05-23 22:52:39 +05:30
Michael VorburgerandYemdjih Kaze Nasser 5b1c46c821 remove logback.xml (see FINERACT-888)
Read e.g. https://12factor.net/logs for why we don't want to log
to a fineract-platform.log file anymore by default.  Of course, anyone
could still customize logging as they see fit for their own deployments.
2020-05-23 12:38:20 +01:00
thesmallstarandMichael Vorburger ⛑️ baa1177854 FINERACT-821 Added and Enforced Typename checkstyle 2020-05-22 15:23:23 +02:00
Michael VorburgerandYemdjih Kaze Nasser 3d0d515b4b ignore StorageTest [FINERACT-828] 2020-05-22 03:56:22 +01:00
nnatarajanandMichael Vorburger ⛑️ 96452f3ff4 Fineract-955 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18 2020-05-22 00:07:37 +02:00
thesmallstarandMichael Vorburger ⛑️ 16fb971f45 FINERACT-942 Remove use of printStackTrace and added checkstyle 2020-05-21 21:48:11 +02:00
Petri TuomolaandMichael Vorburger ⛑️ acfec8bb94 FINERACT-723: Fixing date comparisons that resulting in a problem when timezone is different on database and application server 2020-05-21 11:50:30 +02:00
xurrorandMichael Vorburger ⛑️ 3bc7914068 Update spotbugs to v4.2.0(FINERACT-986) 2020-05-21 10:52:42 +02:00
Yemdjih Kaze NasserandGitHub 44376ca1fe Merge pull request #911 from vorburger/FINERACT-953_groovy
improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
2020-05-20 01:21:45 +01:00
xurrorandMichael Vorburger ⛑️ dc3af0c867 FINERACT-964
bump json-path from 0.9.1 to 2.4.0
2020-05-20 00:56:20 +02:00
percyashuandMichael Vorburger ⛑️ 610375753c FINERACT-959 make javac fail for Xlint:cast 2020-05-20 00:42:20 +02:00
Michael Vorburger dd0c838439 improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
to ignore all META-INF/groovy** such as
META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule which is
part of both groovy-xml-3.0.3.jar as well as e.g. ical4j-3.0.18.jar
2020-05-19 23:01:28 +02:00
Michael Vorburger 5557b8be4a fix moar flaky StorageTest.testNotificationStorage() [FINERACT-828]
similar fix to earlier Pull Request for the same

also added some more toString()
2020-05-17 21:29:20 +02:00
Michael Vorburger 7a98ad8d07 add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
This would catch problems such as the integration tests running "too
early" (before Flyway has fully initialized the database), which I have
a suspicion could be one of (many) causes of the unstable scheduler
tests, notably because of the IllegalArgumentException at
SchedulerJobsTest.java:90 in https://github.com/apache/fineract/pull/817
2020-05-17 10:56:59 +02:00