Merge pull request #2831 from JaySoni1/WEB-448-credit-amount-field-allows-invalid-values-zero-and-negative-in-journal-entry-creation

WEB-448 Credit amount field allows invalid values zero and negative in journal entry creation
This commit is contained in:
Jose Alberto Hernandez
2025-12-02 15:14:59 -05:00
committed by GitHub
2 changed files with 24 additions and 3 deletions
@@ -51,7 +51,14 @@
<mat-form-field class="flex-43">
<mat-label>{{ 'labels.inputs.Debit Amount' | translate }}</mat-label>
<input type="number" matInput required formControlName="amount" />
<input
type="number"
matInput
required
formControlName="amount"
min="1"
(input)="onAmountInput($event)"
/>
<mat-error *ngIf="debits.at(i).controls.amount.hasError('required')">
{{ 'labels.inputs.Debit Amount' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
@@ -92,7 +99,14 @@
<mat-form-field class="flex-43">
<mat-label>{{ 'labels.inputs.Credit Amount' | translate }}</mat-label>
<input type="number" matInput required formControlName="amount" />
<input
type="number"
matInput
required
formControlName="amount"
min="1"
(input)="onAmountInput($event)"
/>
<mat-error *ngIf="credits.at(i).controls.amount.hasError('required')">
{{ 'labels.inputs.Credit Amount' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
@@ -34,6 +34,11 @@ import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
]
})
export class CreateJournalEntryComponent implements OnInit, AfterViewInit {
onCreditAmountInput(event: any) {
if (event.target.value < 1) {
event.target.value = 1;
}
}
/** Minimum transaction date allowed. */
minDate = new Date(2000, 0, 1);
/** Maximum transaction date allowed. */
@@ -140,7 +145,9 @@ export class CreateJournalEntryComponent implements OnInit, AfterViewInit {
],
amount: [
'',
Validators.required
[
Validators.required,
Validators.min(1)]
]
});
}