Merge pull request #3111 from JaySoni1/WEB-680-fix-provisioning-criteria-dialog-allows-negative-values-in-age-percentage-fields

WEB-680 Fix provisioning criteria dialog allows negative values in age percentage fields

src/app/organization/loan-provisioning-criteria/create-loan-provisioning-criteria/create-loan-provisioning-criteria.component.ts

@@ -187,6 +187,7 @@ export class CreateLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.minAge : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 1
       })
     );
@@ -197,6 +198,7 @@ export class CreateLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.maxAge : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 2
       })
     );
@@ -207,6 +209,7 @@ export class CreateLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.provisioningPercentage : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 3
       })
     );

src/app/organization/loan-provisioning-criteria/edit-loan-provisioning-criteria/edit-loan-provisioning-criteria.component.ts

@@ -195,6 +195,7 @@ export class EditLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.minAge : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 1
       })
     );
@@ -205,6 +206,7 @@ export class EditLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.maxAge : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 2
       })
     );
@@ -215,6 +217,7 @@ export class EditLoanProvisioningCriteriaComponent implements OnInit {
         value: definition ? definition.provisioningPercentage : '',
         type: 'number',
         required: true,
+        min: 0,
         order: 3
       })
     );

src/app/shared/form-dialog/form-group.service.ts

@@ -34,6 +34,12 @@ export class FormGroupService {
     if (formfield.required) {
       validators.push(Validators.required);
     }
+    if (formfield.min !== null && formfield.min !== undefined) {
+      validators.push(Validators.min(formfield.min));
+    }
+    if (formfield.max !== null && formfield.max !== undefined) {
+      validators.push(Validators.max(formfield.max));
+    }
     if (formfield.validators) {
       formfield.validators.forEach((validator: ValidatorFn) => validators.push(validator));
     }

src/app/shared/form-dialog/formfield/formfield.component.html

@@ -17,6 +17,8 @@
             matInput
             [formControlName]="formfield.controlName"
             [required]="formfield.required"
+            [attr.min]="formfield.min"
+            [attr.max]="formfield.max"
           />
         }
         @if (form.controls[formfield.controlName].hasError('max')) {