CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #2744 from JaySoni1/WEB-373-javascript-error-message-opening-the-first-step-of-create-loans-account

Browse Source 
WEB-373 Javascript error message opening the first step of  Create Loans Account
This commit is contained in:
Gopi Kishan
2025-11-04 14:17:46 +05:30
committed by GitHub
parent 28beb149a2 1d16295e8f
commit 9b7ba2b54e
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.ts
+7 -7
View File
@@ -204,7 +204,7 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
isEqualAmortization: this.loansAccountTermsData.isEqualAmortization,
interestType: this.loansAccountTermsData.interestType.id,
// TODO: 2025-03-17: Is this correct?
isFloatingInterestRate: this.loansAccountTermsData.isLoanProductLinkedToFloatingRate ? false : '',
isFloatingInterestRate: this.loansAccountTermsData.isLoanProductLinkedToFloatingRate ? false : null,
interestCalculationPeriodType: this.loansAccountTermsData.interestCalculationPeriodType.id,
allowPartialPeriodInterestCalculation: this.loansAccountTermsData.allowPartialPeriodInterestCalculation,
inArrearsTolerance: this.loansAccountTermsData.inArrearsTolerance,
@@ -291,12 +291,12 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
if (this.allowAddDisbursementDetails()) {
this.loansAccountTermsForm.addControl(
'maxOutstandingLoanBalance',
new UntypedFormControl(this.loansAccountTermsData.maxOutstandingLoanBalance, Validators.required)
new UntypedFormControl(this.loansAccountTermsData?.maxOutstandingLoanBalance ?? null, Validators.required)
);
} else {
this.loansAccountTermsForm.addControl(
'maxOutstandingLoanBalance',
new UntypedFormControl(this.loansAccountTermsData.maxOutstandingLoanBalance)
new UntypedFormControl(this.loansAccountTermsData?.maxOutstandingLoanBalance ?? null)
);
}
}
@@ -330,7 +330,7 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
amortizationType: this.loansAccountTermsData.amortizationType.id,
isEqualAmortization: this.loansAccountTermsData.isEqualAmortization,
interestType: this.loansAccountTermsData.interestType.id,
isFloatingInterestRate: this.loansAccountTermsData.isLoanProductLinkedToFloatingRate ? false : '',
isFloatingInterestRate: this.loansAccountTermsData.isLoanProductLinkedToFloatingRate ? false : null,
interestCalculationPeriodType: this.loansAccountTermsData.interestCalculationPeriodType.id,
allowPartialPeriodInterestCalculation: this.loansAccountTermsData.allowPartialPeriodInterestCalculation,
inArrearsTolerance: this.loansAccountTermsData.inArrearsTolerance,
@@ -358,12 +358,12 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
this.loansAccountTermsForm.removeControl('maxOutstandingLoanBalance');
this.loansAccountTermsForm.addControl(
'maxOutstandingLoanBalance',
new UntypedFormControl(this.loansAccountTermsData.maxOutstandingLoanBalance, Validators.required)
new UntypedFormControl(this.loansAccountTermsData?.maxOutstandingLoanBalance ?? null, Validators.required)
);
} else {
this.loansAccountTermsForm.addControl(
'maxOutstandingLoanBalance',
new UntypedFormControl(this.loansAccountTermsData.maxOutstandingLoanBalance)
new UntypedFormControl(this.loansAccountTermsData?.maxOutstandingLoanBalance ?? null)
);
}
}
@@ -492,7 +492,7 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
interestChargedFromDate: [''],
interestRatePerPeriod: [''],
interestType: [''],
isFloatingInterestRate: [''],
isFloatingInterestRate: [null],
isEqualAmortization: [''],
amortizationType: [
'',