WEB-639: Refactor redundant boolean comparisons (#3063)

improve

improve

improve

improve
This commit is contained in:
Shubham Kumar
2026-01-31 07:07:59 -06:00
committed by GitHub
parent 41a71cd269
commit fbee49b464
55 changed files with 190 additions and 193 deletions
+5 -5
View File
@@ -84,17 +84,17 @@ export class AccountingComponent implements AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showChartofAccounts === true) {
if (this.configurationWizardService.showChartofAccounts) {
setTimeout(() => {
this.showPopover(this.templateChartofAccounts, this.chartofAccounts.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showAccountsLinked === true) {
if (this.configurationWizardService.showAccountsLinked) {
setTimeout(() => {
this.showPopover(this.templateAccountsLinked, this.accountsLinked.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showMigrateOpeningBalances === true) {
if (this.configurationWizardService.showMigrateOpeningBalances) {
setTimeout(() => {
this.showPopover(
this.templateMigrateOpeningBalances,
@@ -104,12 +104,12 @@ export class AccountingComponent implements AfterViewInit {
);
});
}
if (this.configurationWizardService.showClosingEntries === true) {
if (this.configurationWizardService.showClosingEntries) {
setTimeout(() => {
this.showPopover(this.templateClosingEntries, this.closingEntries.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showCreateJournalEntries === true) {
if (this.configurationWizardService.showCreateJournalEntries) {
setTimeout(() => {
this.showPopover(this.templateCreateJournalEntries, this.createJournalEntries.nativeElement, 'bottom', true);
});
@@ -181,13 +181,13 @@ export class ChartOfAccountsComponent implements AfterViewInit, OnInit {
}
};
this.tableDataSource.sort = this.sort;
if (this.configurationWizardService.showChartofAccountsPage === true) {
if (this.configurationWizardService.showChartofAccountsPage) {
setTimeout(() => {
this.showPopover(this.templateButtonTreeView, this.buttonTreeView.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showChartofAccountsList === true) {
if (this.configurationWizardService.showChartofAccountsList) {
setTimeout(() => {
this.showPopover(this.templateAccountsTable, this.accountsTable.nativeElement, 'top', true);
});
@@ -173,7 +173,7 @@ export class CreateGlAccountComponent implements OnInit, AfterViewInit {
return;
}
this.accountingService.createGlAccount(this.glAccountForm.value).subscribe((response: any) => {
if (this.configurationWizardService.showChartofAccounts === true) {
if (this.configurationWizardService.showChartofAccounts) {
this.configurationWizardService.showChartofAccounts = false;
this.openDialog();
} else {
@@ -208,7 +208,7 @@ export class CreateGlAccountComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showChartofAccountsForm === true) {
if (this.configurationWizardService.showChartofAccountsForm) {
setTimeout(() => {
this.showPopover(this.templateAccountFormRef, this.accountFormRef.nativeElement, 'bottom', true);
});
@@ -184,13 +184,13 @@ export class ClosingEntriesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showClosingEntriesPage === true) {
if (this.configurationWizardService.showClosingEntriesPage) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateClosure, this.buttonCreateClosure.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showClosingEntriesList === true) {
if (this.configurationWizardService.showClosingEntriesList) {
setTimeout(() => {
this.showPopover(this.templateClosuresTable, this.closuresTable.nativeElement, 'top', true);
});
@@ -251,7 +251,7 @@ export class CreateJournalEntryComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showCreateJournalEntries === true) {
if (this.configurationWizardService.showCreateJournalEntries) {
setTimeout(() => {
this.showPopover(this.templateCreateJournalFormRef, this.createJournalFormRef.nativeElement, 'top', true);
});
@@ -149,13 +149,13 @@ export class FinancialActivityMappingsComponent implements OnInit, AfterViewInit
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showAccountsLinkedPage === true) {
if (this.configurationWizardService.showAccountsLinkedPage) {
setTimeout(() => {
this.showPopover(this.templateButtonDefineMapping, this.buttonDefineMapping.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showAccountsLinkedList === true) {
if (this.configurationWizardService.showAccountsLinkedList) {
setTimeout(() => {
this.showPopover(this.templateActivitiesTable, this.activitiesTable.nativeElement, 'top', true);
});
@@ -240,7 +240,7 @@ export class MigrateOpeningBalancesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showMigrateOpeningBalances === true) {
if (this.configurationWizardService.showMigrateOpeningBalances) {
setTimeout(() => {
this.showPopover(this.templateSearchFormRef, this.searchFormRef.nativeElement, 'bottom', true);
});
@@ -146,7 +146,7 @@ export class AddClientChargeComponent implements OnInit {
clientCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
clientCharge.monthDayFormat = monthDayFormat;
if (clientCharge.feeOnMonthDay) {
@@ -21,186 +21,186 @@ export class ConfigurationWizardService {
*/
/*To show toolbar*/
showToolbar = false;
showToolbar: boolean = false;
/*To show popover on admin section in toolbar*/
showToolbarAdmin = false;
showToolbarAdmin: boolean = false;
/*To show side navbar*/
showSideNav = false;
showSideNav: boolean = false;
/*To show popover on chart of accounts section in sidenav bar*/
showSideNavChartofAccounts = false;
showSideNavChartofAccounts: boolean = false;
/*To show breadcrumbs*/
showBreadcrumbs = false;
showBreadcrumbs: boolean = false;
/*To show home*/
showHome = false;
showHome: boolean = false;
/*To show search activity in home*/
showHomeSearchActivity = false;
showHomeSearchActivity: boolean = false;
/**
* Organization Setup
*/
/*To show popover on manage offices on oganization page*/
showCreateOffice = false;
showCreateOffice: boolean = false;
/*To show popover on button in offices page*/
showOfficeList = false;
showOfficeList: boolean = false;
/*To show popover on offices table*/
showOfficeTable = false;
showOfficeTable: boolean = false;
/*To show popover on create office form*/
showOfficeForm = false;
showOfficeForm: boolean = false;
/*To show popover on add edit currency on organization page*/
showAddEditCurrency = false;
showAddEditCurrency: boolean = false;
/*To show popover on button in currency page*/
showCurrencyPage = false;
showCurrencyPage: boolean = false;
/*To show popover on currency table*/
showCurrencyList = false;
showCurrencyList: boolean = false;
/*To show popover on currency form*/
showCurrencyForm = false;
showCurrencyForm: boolean = false;
/*To show popover on manage holiday on organization page*/
showCreateHoliday = false;
showCreateHoliday: boolean = false;
/*To show popover on button in holiday page*/
showHolidayPage = false;
showHolidayPage: boolean = false;
/*To show popover on filter in holiday table*/
showHolidayFilter = false;
showHolidayFilter: boolean = false;
/*To show popover on manage employees on organization page*/
showCreateEmployee = false;
showCreateEmployee: boolean = false;
/*To show popover on button in employee page*/
showEmployeeList = false;
showEmployeeList: boolean = false;
/*To show popover on employees table*/
showEmployeeTable = false;
showEmployeeTable: boolean = false;
/*To show popover on create employee form*/
showEmployeeForm = false;
showEmployeeForm: boolean = false;
/*To show popover on define working days*/
showDefineWorkingDays = false;
showDefineWorkingDays: boolean = false;
/**
* System Setup
*/
/*To show popover on manage datatables on system page*/
showDatatables = false;
showDatatables: boolean = false;
/*To show popover on button in datatables page*/
showDatatablesPage = false;
showDatatablesPage: boolean = false;
/*To show popover on datatables table*/
showDatatablesList = false;
showDatatablesList: boolean = false;
/*To show popover on create datable form*/
showDatatablesForm = false;
showDatatablesForm: boolean = false;
/*To show popover manage codes on system page*/
showSystemCodes = false;
showSystemCodes: boolean = false;
/*To show popover on button in codes page*/
showSystemCodesPage = false;
showSystemCodesPage: boolean = false;
/*To show popover on codes table*/
showSystemCodesList = false;
showSystemCodesList: boolean = false;
/*To show popover on create codes form*/
showSystemCodesForm = false;
showSystemCodesForm: boolean = false;
/*To show popover on manage roles and permision on system page*/
showRolesandPermission = false;
showRolesandPermission: boolean = false;
/*To show popover on button in rolaes and permission page*/
showRolesandPermissionPage = false;
showRolesandPermissionPage: boolean = false;
/*To show popover on roles and permission list*/
showRolesandPermissionList = false;
showRolesandPermissionList: boolean = false;
/*To show popover on button on user page*/
showUsers = false;
showUsers: boolean = false;
/*To show popover on users table*/
showUsersList = false;
showUsersList: boolean = false;
/*To show popover on create user form*/
showUsersForm = false;
showUsersForm: boolean = false;
/*To show popover on maker checker table in system page*/
showMakerCheckerTable = false;
showMakerCheckerTable: boolean = false;
/*To show popover on button in make checker tasks page*/
showMakerCheckerTablePage = false;
showMakerCheckerTablePage: boolean = false;
/*To show popover on maker checker tasks table*/
showMakerCheckerTableList = false;
showMakerCheckerTableList: boolean = false;
/*To show popover on global configuration in system page*/
showConfigurations = false;
showConfigurations: boolean = false;
/*To show popover on button in configuration page*/
showConfigurationsPage = false;
showConfigurationsPage: boolean = false;
/*To show popover on button in configuration list*/
showConfigurationsList = false;
showConfigurationsList: boolean = false;
/*To show popover on manage scheduler jobs on system page*/
showSchedulerJobs = false;
showSchedulerJobs: boolean = false;
/*To show popover on button in scheduler jobs page*/
showSchedulerJobsPage = false;
showSchedulerJobsPage: boolean = false;
/*To show popover on scheduler jobs table*/
showSchedulerJobsList = false;
showSchedulerJobsList: boolean = false;
/**
* Accounting Setup
*/
/*To show popover on chart of accounts on accounting page*/
showChartofAccounts = false;
showChartofAccounts: boolean = false;
/*To show popover on button in chart of accounts page*/
showChartofAccountsPage = false;
showChartofAccountsPage: boolean = false;
/*To show popover on button in chart of accounts page*/
showChartofAccountsList = false;
showChartofAccountsList: boolean = false;
/*To show popover on create chart of accounts form*/
showChartofAccountsForm = false;
showChartofAccountsForm: boolean = false;
/*To show popover on accounts linked on accounting page*/
showAccountsLinked = false;
showAccountsLinked: boolean = false;
/*To show popover on button in accounting page*/
showAccountsLinkedPage = false;
showAccountsLinkedPage: boolean = false;
/*To show popover on accounts linked table*/
showAccountsLinkedList = false;
showAccountsLinkedList: boolean = false;
/*To show popover on migrate openening balances*/
showMigrateOpeningBalances = false;
showMigrateOpeningBalances: boolean = false;
/*To show popover on closing entries on accounting page*/
showClosingEntries = false;
showClosingEntries: boolean = false;
/*To show popover on button in closing entries page*/
showClosingEntriesPage = false;
showClosingEntriesPage: boolean = false;
/*To show popover on closing entries table*/
showClosingEntriesList = false;
showClosingEntriesList: boolean = false;
/*To show popover on create journal entry*/
showCreateJournalEntries = false;
showCreateJournalEntries: boolean = false;
/**
* Products Setup
*/
/*To show popover on charges on products page*/
showCharges = false;
showCharges: boolean = false;
/*To show popover on button in charges page*/
showChargesPage = false;
showChargesPage: boolean = false;
/*To show popover on charges table*/
showChargesList = false;
showChargesList: boolean = false;
/*To show popover on loan products on products page*/
showLoanProducts = false;
showLoanProducts: boolean = false;
/*To show popover on button in load products page*/
showLoanProductsPage = false;
showLoanProductsPage: boolean = false;
/*To show popover on loan products table*/
showLoanProductsList = false;
showLoanProductsList: boolean = false;
/*To show popover on savings products on products page*/
showSavingsProducts = false;
showSavingsProducts: boolean = false;
/*To show popover on button in savings products page*/
showSavingsProductsPage = false;
showSavingsProductsPage: boolean = false;
/*To show popover on savings products table*/
showSavingsProductsList = false;
showSavingsProductsList: boolean = false;
/*To show popover on shares products on products page*/
showShareProducts = false;
showShareProducts: boolean = false;
/*To show popover on button in share products page*/
showShareProductsPage = false;
showShareProductsPage: boolean = false;
/*To show popover on share products table*/
showShareProductsList = false;
showShareProductsList: boolean = false;
/*To show popover on fixed deposit products on products page*/
showFixedDepositProducts = false;
showFixedDepositProducts: boolean = false;
/*To show popover on button in fixed deposit products page*/
showFixedDepositProductsPage = false;
showFixedDepositProductsPage: boolean = false;
/*To show popover on fixed deposit products table*/
showFixedDepositProductsList = false;
showFixedDepositProductsList: boolean = false;
/*To show popover on recrurring deposit products on products page*/
showRecurringDepositProducts = false;
showRecurringDepositProducts: boolean = false;
/*To show popover on button in recurring deposit products page*/
showRecurringDepositProductsPage = false;
showRecurringDepositProductsPage: boolean = false;
/*To show popover on recurring deposit products table*/
showRecurringDepositProductsList = false;
showRecurringDepositProductsList: boolean = false;
/**
* Manage Funds and manage reports Setup
*/
/*To show popover on manage funds*/
showManageFunds = false;
showManageFunds: boolean = false;
/*To show popover on manage reports*/
showManageReports = false;
showManageReports: boolean = false;
constructor() {}
@@ -183,7 +183,7 @@ export class PopoverService {
}
];
}
if (backdrop === true) {
if (backdrop) {
showbackdrop = true;
} else {
showbackdrop = false;
@@ -252,7 +252,7 @@ export class BreadcrumbComponent implements AfterViewInit, OnDestroy {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showBreadcrumbs === true) {
if (this.configurationWizardService.showBreadcrumbs) {
setTimeout(() => {
this.showPopover(this.templateBreadcrumb, this.breadcrumb.nativeElement, 'bottom', true);
});
@@ -226,12 +226,12 @@ export class SidenavComponent implements OnInit, AfterViewInit {
* To show popovers
*/
ngAfterViewInit() {
if (this.configurationWizardService.showSideNav === true) {
if (this.configurationWizardService.showSideNav) {
setTimeout(() => {
this.showPopover(this.templateLogo, this.logo.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSideNavChartofAccounts === true) {
if (this.configurationWizardService.showSideNavChartofAccounts) {
setTimeout(() => {
this.showPopover(this.templateChartOfAccounts, this.chartOfAccounts.nativeElement, 'top', true);
});
@@ -234,20 +234,17 @@ export class ToolbarComponent implements OnInit, AfterViewInit, AfterContentChec
* To show popovers
*/
ngAfterViewInit() {
if (this.configurationWizardService.showToolbar === true) {
if (this.configurationWizardService.showToolbar) {
setTimeout(() => {
this.showPopover(this.templateInstitution, this.institution.nativeElement);
});
}
if (
this.configurationWizardService.showSideNav === true ||
this.configurationWizardService.showSideNavChartofAccounts === true
) {
if (this.configurationWizardService.showSideNav || this.configurationWizardService.showSideNavChartofAccounts) {
this.toggleSidenavCollapse();
}
if (this.configurationWizardService.showToolbarAdmin === true) {
if (this.configurationWizardService.showToolbarAdmin) {
setTimeout(() => {
this.showPopover(this.templateAppMenu, this.appMenu.nativeElement);
});
@@ -147,7 +147,7 @@ export class AddChargeFixedDepositsAccountComponent implements OnInit {
savingsCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
savingsCharge.monthDayFormat = monthDayFormat;
if (savingsCharge.feeOnMonthDay) {
@@ -146,7 +146,7 @@ export class AddChargeRecurringDepositsAccountComponent implements OnInit {
savingsCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
savingsCharge.monthDayFormat = monthDayFormat;
if (savingsCharge.feeOnMonthDay) {
@@ -117,10 +117,10 @@ export class TransactionsTabComponent implements OnInit {
*/
isDebit(transactionType: any) {
return (
transactionType.withdrawal === true ||
transactionType.feeDeduction === true ||
transactionType.overdraftInterest === true ||
transactionType.withholdTax === true
transactionType.withdrawal ||
transactionType.feeDeduction ||
transactionType.overdraftInterest ||
transactionType.withholdTax
);
}
+2 -2
View File
@@ -141,12 +141,12 @@ export class HomeComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showHome === true) {
if (this.configurationWizardService.showHome) {
setTimeout(() => {
this.showPopover(this.templateButtonDashboard, this.buttonDashboard.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showHomeSearchActivity === true) {
if (this.configurationWizardService.showHomeSearchActivity) {
setTimeout(() => {
this.showPopover(this.templateSearchActivity, this.searchActivity.nativeElement, 'bottom', true);
});
@@ -720,6 +720,6 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
* Available when PROGRESSIVE schedule type and multi-disbursement is enabled.
*/
isFullTermTrancheEditable(): boolean {
return this.isProgressive && this.multiDisburseLoan === true;
return this.isProgressive && !!this.multiDisburseLoan;
}
}
@@ -87,7 +87,7 @@ export class PenaltyManagementService {
}
// Check if it's a penalty charge
const isPenalty =
charge.penalty === true ||
charge.penalty ||
charge.penalty === 'true' ||
(charge.chargeTimeType &&
(charge.chargeTimeType.value?.toLowerCase().includes('overdue') ||
@@ -99,7 +99,7 @@ export class PenaltyManagementService {
}
// Check if already waived or paid
if (charge.waived === true || charge.waived === 'true' || charge.paid === true || charge.paid === 'true') {
if (charge.waived || charge.waived === 'true' || charge.paid || charge.paid === 'true') {
return false;
}
@@ -146,13 +146,13 @@ export class CurrenciesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showCurrencyPage === true) {
if (this.configurationWizardService.showCurrencyPage) {
setTimeout(() => {
this.showPopover(this.templateButtonAddEdit, this.buttonAddEdit.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showCurrencyList === true) {
if (this.configurationWizardService.showCurrencyList) {
setTimeout(() => {
this.showPopover(this.templateTableCurrencies, this.tableCurrencies.nativeElement, 'top', true);
});
@@ -166,7 +166,7 @@ export class ManageCurrenciesComponent implements OnInit, AfterViewInit, OnDestr
this.organizationservice.updateCurrencies(selectedCurrencyCodes).subscribe((response: any) => {
this.selectedCurrencies.push(newCurrency);
this.formRef.resetForm();
if (this.configurationWizardService.showCurrencyForm === true) {
if (this.configurationWizardService.showCurrencyForm) {
this.configurationWizardService.showCurrencyForm = false;
this.openDialog();
}
@@ -205,7 +205,7 @@ export class ManageCurrenciesComponent implements OnInit, AfterViewInit, OnDestr
}
ngAfterViewInit() {
if (this.configurationWizardService.showCurrencyForm === true) {
if (this.configurationWizardService.showCurrencyForm) {
setTimeout(() => {
this.showPopover(this.templateCurrencyFormRef, this.currencyFormRef.nativeElement, 'bottom', true);
});
@@ -142,7 +142,7 @@ export class CreateEmployeeComponent implements OnInit, AfterViewInit {
locale
};
this.organizationService.createEmployee(data).subscribe((response: any) => {
if (this.configurationWizardService.showEmployeeForm === true) {
if (this.configurationWizardService.showEmployeeForm) {
this.configurationWizardService.showEmployeeForm = false;
this.openDialog();
} else {
@@ -171,7 +171,7 @@ export class CreateEmployeeComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showEmployeeForm === true) {
if (this.configurationWizardService.showEmployeeForm) {
setTimeout(() => {
this.showPopover(this.templateCreateEmployeeForm, this.createEmployeeFormRef.nativeElement, 'right', true);
});
@@ -151,12 +151,12 @@ export class EmployeesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showEmployeeList === true) {
if (this.configurationWizardService.showEmployeeList) {
setTimeout(() => {
this.showPopover(this.templateButtonImportEmployees, this.buttonImportEmployees.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showEmployeeTable === true) {
if (this.configurationWizardService.showEmployeeTable) {
setTimeout(() => {
this.showPopover(this.templateTableEmployees, this.tableEmployees.nativeElement, 'top', true);
});
@@ -173,13 +173,13 @@ export class HolidaysComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showHolidayPage === true) {
if (this.configurationWizardService.showHolidayPage) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateHoliday, this.buttonCreateHoliday.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showHolidayFilter === true) {
if (this.configurationWizardService.showHolidayFilter) {
setTimeout(() => {
this.showPopover(this.templateFilterRef, this.filterRef.nativeElement, 'bottom', true);
});
@@ -157,7 +157,7 @@ export class ManageFundsComponent implements OnInit, AfterViewInit {
name: newFund.name
});
this.formRef.resetForm();
if (this.configurationWizardService.showManageFunds === true) {
if (this.configurationWizardService.showManageFunds) {
this.configurationWizardService.showManageFunds = false;
this.openDialog();
}
@@ -215,7 +215,7 @@ export class ManageFundsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showManageFunds === true) {
if (this.configurationWizardService.showManageFunds) {
setTimeout(() => {
this.showPopover(this.templateFundFormRef, this.fundFormRef.nativeElement, 'bottom', true);
});
@@ -121,7 +121,7 @@ export class CreateOfficeComponent implements OnInit, AfterViewInit {
locale
};
this.organizationService.createOffice(data).subscribe((response) => {
if (this.configurationWizardService.showOfficeForm === true) {
if (this.configurationWizardService.showOfficeForm) {
this.configurationWizardService.showOfficeForm = false;
this.openDialog();
} else {
@@ -176,7 +176,7 @@ export class CreateOfficeComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showOfficeForm === true) {
if (this.configurationWizardService.showOfficeForm) {
setTimeout(() => {
this.showPopover(this.templateCreateOfficeForm, this.createOfficeFormRef.nativeElement, 'right', true);
});
@@ -240,12 +240,12 @@ export class OfficesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showOfficeList === true) {
if (this.configurationWizardService.showOfficeList) {
setTimeout(() => {
this.showPopover(this.templateButtonTreeView, this.buttonTreeView.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showOfficeTable === true) {
if (this.configurationWizardService.showOfficeTable) {
setTimeout(() => {
this.showPopover(this.templateTableOffices, this.tableOffices.nativeElement, 'top', true);
});
@@ -90,32 +90,32 @@ export class OrganizationComponent implements AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showCreateOffice === true) {
if (this.configurationWizardService.showCreateOffice) {
setTimeout(() => {
this.showPopover(this.templateOffice, this.office.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showAddEditCurrency === true) {
if (this.configurationWizardService.showAddEditCurrency) {
setTimeout(() => {
this.showPopover(this.templateAddEditCurrency, this.addEditCurrency.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showCreateHoliday === true) {
if (this.configurationWizardService.showCreateHoliday) {
setTimeout(() => {
this.showPopover(this.templateHolidays, this.holidays.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showCreateEmployee === true) {
if (this.configurationWizardService.showCreateEmployee) {
setTimeout(() => {
this.showPopover(this.templateEmployee, this.employee.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showDefineWorkingDays === true) {
if (this.configurationWizardService.showDefineWorkingDays) {
setTimeout(() => {
this.showPopover(this.templateWorkingDays, this.workingDays.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showManageFunds === true) {
if (this.configurationWizardService.showManageFunds) {
setTimeout(() => {
this.showPopover(this.templateManageFunds, this.manageFunds.nativeElement, 'bottom', true);
});
@@ -75,7 +75,7 @@ export class PasswordPreferencesComponent implements OnInit {
*/
setPasswordPreferencesForm() {
for (const passwordPreference of this.passwordPreferencesData) {
if (passwordPreference.active === true) {
if (passwordPreference.active) {
this.passwordPreferencesForm.get('validationPolicyId').setValue(passwordPreference.id);
}
}
@@ -153,7 +153,7 @@ export class WorkingDaysComponent implements OnInit, AfterViewInit {
}
workingDays.recurrence = recurrence;
this.organizationService.updateWorkingDays(workingDays).subscribe((response) => {
if (this.configurationWizardService.showDefineWorkingDays === true) {
if (this.configurationWizardService.showDefineWorkingDays) {
this.configurationWizardService.showDefineWorkingDays = false;
this.openNextStepDialog();
} else {
@@ -182,7 +182,7 @@ export class WorkingDaysComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showDefineWorkingDays === true) {
if (this.configurationWizardService.showDefineWorkingDays) {
setTimeout(() => {
this.showPopover(this.templateWorkingDaysFormRef, this.workingDaysFormRef.nativeElement, 'right', true);
});
+1 -1
View File
@@ -89,7 +89,7 @@ export class AccountsFilterPipe implements PipeTransform {
if (type === 'guarantor') {
if (status === false) {
accounts = accounts.filter((account: any) => {
return account.status === true;
return account.status;
});
} else {
return accounts;
@@ -154,13 +154,13 @@ export class ChargesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showChargesPage === true) {
if (this.configurationWizardService.showChargesPage) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateCharge, this.buttonCreateCharge.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showChargesList === true) {
if (this.configurationWizardService.showChargesList) {
setTimeout(() => {
this.showPopover(this.templateChargesTable, this.chargesTable.nativeElement, 'top', true);
});
@@ -130,7 +130,7 @@ export class FixedDepositProductsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showFixedDepositProductsPage === true) {
if (this.configurationWizardService.showFixedDepositProductsPage) {
setTimeout(() => {
this.showPopover(
this.templateButtonCreateFixedProduct,
@@ -141,7 +141,7 @@ export class FixedDepositProductsComponent implements OnInit, AfterViewInit {
});
}
if (this.configurationWizardService.showFixedDepositProductsList === true) {
if (this.configurationWizardService.showFixedDepositProductsList) {
setTimeout(() => {
this.showPopover(this.templateFixedProductsTable, this.fixedProductsTable.nativeElement, 'top', true);
});
@@ -339,7 +339,7 @@ export class EditLoanProductComponent implements OnInit {
submit() {
const loanProduct = this.loanProducts.buildPayload(this.loanProduct, this.itemsByDefault);
if (loanProduct['useDueForRepaymentsConfigurations'] === true) {
if (loanProduct['useDueForRepaymentsConfigurations']) {
loanProduct['dueDaysForRepaymentEvent'] = null;
loanProduct['overDueDaysForRepaymentEvent'] = null;
}
@@ -125,7 +125,7 @@ export class LoanProductsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showLoanProductsPage === true) {
if (this.configurationWizardService.showLoanProductsPage) {
setTimeout(() => {
this.showPopover(
this.templateButtonCreateLoanProduct,
@@ -136,7 +136,7 @@ export class LoanProductsComponent implements OnInit, AfterViewInit {
});
}
if (this.configurationWizardService.showLoanProductsList === true) {
if (this.configurationWizardService.showLoanProductsList) {
setTimeout(() => {
this.showPopover(this.templateLoanProductsTable, this.loanProductsTable.nativeElement, 'top', true);
});
+6 -6
View File
@@ -71,32 +71,32 @@ export class ProductsComponent implements AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showCharges === true) {
if (this.configurationWizardService.showCharges) {
setTimeout(() => {
this.showPopover(this.templateCharges, this.charges.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showLoanProducts === true) {
if (this.configurationWizardService.showLoanProducts) {
setTimeout(() => {
this.showPopover(this.templateLoanProducts, this.loanProducts.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSavingsProducts === true) {
if (this.configurationWizardService.showSavingsProducts) {
setTimeout(() => {
this.showPopover(this.templateSavingsProducts, this.savingsProducts.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showShareProducts === true) {
if (this.configurationWizardService.showShareProducts) {
setTimeout(() => {
this.showPopover(this.templateShareProducts, this.shareProducts.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showFixedDepositProducts === true) {
if (this.configurationWizardService.showFixedDepositProducts) {
setTimeout(() => {
this.showPopover(this.templateFixedDepositProducts, this.fixedDepositProducts.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showRecurringDepositProducts === true) {
if (this.configurationWizardService.showRecurringDepositProducts) {
setTimeout(() => {
this.showPopover(
this.templateRecurringDepositProducts,
@@ -137,7 +137,7 @@ export class RecurringDepositProductsComponent implements OnInit, AfterViewInit
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showRecurringDepositProductsPage === true) {
if (this.configurationWizardService.showRecurringDepositProductsPage) {
setTimeout(() => {
this.showPopover(
this.templateButtonCreateRecurringProduct,
@@ -148,7 +148,7 @@ export class RecurringDepositProductsComponent implements OnInit, AfterViewInit
});
}
if (this.configurationWizardService.showRecurringDepositProductsList === true) {
if (this.configurationWizardService.showRecurringDepositProductsList) {
setTimeout(() => {
this.showPopover(this.templateRecurringProductsTable, this.recurringProductsTable.nativeElement, 'top', true);
});
@@ -104,13 +104,13 @@ export class SavingProductsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showSavingsProductsPage === true) {
if (this.configurationWizardService.showSavingsProductsPage) {
setTimeout(() => {
this.showPopover(this.templateButtonSavingProduct, this.buttonSavingProduct.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSavingsProductsList === true) {
if (this.configurationWizardService.showSavingsProductsList) {
setTimeout(() => {
this.showPopover(this.templateSavingProductTable, this.savingProductTable.nativeElement, 'top', true);
});
@@ -105,7 +105,7 @@ export class ShareProductsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showShareProductsPage === true) {
if (this.configurationWizardService.showShareProductsPage) {
setTimeout(() => {
this.showPopover(
this.templateButtonCreateShareProduct,
@@ -116,7 +116,7 @@ export class ShareProductsComponent implements OnInit, AfterViewInit {
});
}
if (this.configurationWizardService.showShareProductsList === true) {
if (this.configurationWizardService.showShareProductsList) {
setTimeout(() => {
this.showPopover(this.templateShareProductsTable, this.shareProductsTable.nativeElement, 'top', true);
});
@@ -146,7 +146,7 @@ export class AddChargeSavingsAccountComponent implements OnInit {
savingsCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
savingsCharge.monthDayFormat = monthDayFormat;
if (savingsCharge.feeOnMonthDay) {
+2 -2
View File
@@ -142,12 +142,12 @@ export class CodesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showSystemCodesPage === true) {
if (this.configurationWizardService.showSystemCodesPage) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateCode, this.buttonCreateCode.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSystemCodesList === true) {
if (this.configurationWizardService.showSystemCodesList) {
setTimeout(() => {
this.showPopover(this.templateTableCodes, this.tableCodes.nativeElement, 'top', true);
});
@@ -67,7 +67,7 @@ export class CreateCodeComponent implements OnInit, AfterViewInit {
*/
submit() {
this.systemService.createCode(this.codeForm.value).subscribe((response: any) => {
if (this.configurationWizardService.showSystemCodesForm === true) {
if (this.configurationWizardService.showSystemCodesForm) {
this.configurationWizardService.showSystemCodesForm = false;
this.configurationWizardService.showRolesandPermission = true;
this.router.navigate(['/system']);
@@ -103,7 +103,7 @@ export class CreateCodeComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showSystemCodesForm === true) {
if (this.configurationWizardService.showSystemCodesForm) {
setTimeout(() => {
this.showPopover(this.templateCodeFormRef, this.codeFormRef.nativeElement, 'right', true);
});
@@ -176,13 +176,13 @@ export class GlobalConfigurationsTabComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showConfigurationsPage === true) {
if (this.configurationWizardService.showConfigurationsPage) {
setTimeout(() => {
this.showPopover(this.templateFilter, this.filter.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showConfigurationsList === true) {
if (this.configurationWizardService.showConfigurationsList) {
setTimeout(() => {
this.showPopover(this.templateConfigurationsTable, this.configurationsTable.nativeElement, 'top', true);
});
@@ -258,12 +258,12 @@ export class ConfigureMakerCheckerTasksComponent implements OnInit, AfterViewIni
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showMakerCheckerTablePage === true) {
if (this.configurationWizardService.showMakerCheckerTablePage) {
setTimeout(() => {
this.showPopover(this.templateButtonEdit, this.buttonEdit.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showMakerCheckerTableList === true) {
if (this.configurationWizardService.showMakerCheckerTableList) {
setTimeout(() => {
this.showPopover(this.templateMcTable, this.mcTable.nativeElement, 'top', true);
});
@@ -296,7 +296,7 @@ export class CreateDataTableComponent implements OnInit, AfterViewInit {
delete payload.entitySubType;
}
this.systemService.createDataTable(payload).subscribe((response: any) => {
if (this.configurationWizardService.showDatatablesForm === true) {
if (this.configurationWizardService.showDatatablesForm) {
this.configurationWizardService.showDatatablesForm = false;
this.openDialog();
} else {
@@ -331,7 +331,7 @@ export class CreateDataTableComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showDatatablesForm === true) {
if (this.configurationWizardService.showDatatablesForm) {
setTimeout(() => {
this.showPopover(this.templateDataTableFormRef, this.dataTableFormRef.nativeElement, 'bottom', true);
});
@@ -147,12 +147,12 @@ export class ManageDataTablesComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showDatatablesPage === true) {
if (this.configurationWizardService.showDatatablesPage) {
setTimeout(() => {
this.showPopover(this.templateCreateDatatableRef, this.createDatatableRef.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showDatatablesList === true) {
if (this.configurationWizardService.showDatatablesList) {
setTimeout(() => {
this.showPopover(this.templateDatatablesList, this.datatablesList.nativeElement, 'top', true);
});
@@ -265,12 +265,12 @@ export class ManageSchedulerJobsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showSchedulerJobsPage === true) {
if (this.configurationWizardService.showSchedulerJobsPage) {
setTimeout(() => {
this.showPopover(this.templateSchedulerStatus, this.schedulerStatus.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSchedulerJobsList === true) {
if (this.configurationWizardService.showSchedulerJobsList) {
setTimeout(() => {
this.showPopover(this.templateJobsTable, this.jobsTable.nativeElement, 'top', true);
});
@@ -135,7 +135,7 @@ export class ManageReportsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showManageReports === true) {
if (this.configurationWizardService.showManageReports) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateReport, this.buttonCreateReport.nativeElement, 'bottom', true);
});
@@ -159,12 +159,12 @@ export class RolesAndPermissionsComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showRolesandPermissionPage === true) {
if (this.configurationWizardService.showRolesandPermissionPage) {
setTimeout(() => {
this.showPopover(this.templateButtonAddRole, this.buttonAddRole.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showRolesandPermissionList === true) {
if (this.configurationWizardService.showRolesandPermissionList) {
setTimeout(() => {
this.showPopover(
this.templateTableRolesandPermissions,
+7 -7
View File
@@ -92,37 +92,37 @@ export class SystemComponent implements AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showDatatables === true) {
if (this.configurationWizardService.showDatatables) {
setTimeout(() => {
this.showPopover(this.templateDatatables, this.datatables.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSystemCodes === true) {
if (this.configurationWizardService.showSystemCodes) {
setTimeout(() => {
this.showPopover(this.templateCodes, this.codes.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showRolesandPermission === true) {
if (this.configurationWizardService.showRolesandPermission) {
setTimeout(() => {
this.showPopover(this.templateRolesandPermission, this.rolesandpermission.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showMakerCheckerTable === true) {
if (this.configurationWizardService.showMakerCheckerTable) {
setTimeout(() => {
this.showPopover(this.templateMakerCheckerTable, this.makerCheckerTable.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showConfigurations === true) {
if (this.configurationWizardService.showConfigurations) {
setTimeout(() => {
this.showPopover(this.templateConfigurations, this.configurations.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showSchedulerJobs === true) {
if (this.configurationWizardService.showSchedulerJobs) {
setTimeout(() => {
this.showPopover(this.templateSchedulerJobs, this.schedulerJobs.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showManageReports === true) {
if (this.configurationWizardService.showManageReports) {
setTimeout(() => {
this.showPopover(this.templateManageReports, this.manageReports.nativeElement, 'bottom', true);
});
@@ -230,7 +230,7 @@ export class LoanApprovalComponent {
this.tasksService.getAllLoansToBeApproved().subscribe((response: any) => {
this.loans = response.pageItems;
this.loans = this.loans.filter((account: any) => {
return account.status.waitingForDisbursal === true;
return account.status.waitingForDisbursal;
});
this.dataSource = new MatTableDataSource(this.loans);
this.selection = new SelectionModel(true, []);
@@ -177,7 +177,7 @@ export class LoanDisbursalComponent {
this.tasksService.getAllLoansToBeDisbursed().subscribe((response: any) => {
this.loans = response.pageItems;
this.loans = this.loans.filter((account: any) => {
return account.status.waitingForDisbursal === true;
return account.status.waitingForDisbursal;
});
this.dataSource = new MatTableDataSource(this.loans);
this.selection = new SelectionModel(true, []);
@@ -187,7 +187,7 @@ export class CreateUserComponent implements OnInit, AfterViewInit {
delete user.staffId;
}
this.usersService.createUser(user).subscribe((response: any) => {
if (this.configurationWizardService.showUsersForm === true) {
if (this.configurationWizardService.showUsersForm) {
this.configurationWizardService.showUsersForm = false;
this.openDialog();
} else {
@@ -222,7 +222,7 @@ export class CreateUserComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showUsersForm === true) {
if (this.configurationWizardService.showUsersForm) {
setTimeout(() => {
this.showPopover(this.templateUserFormRef, this.userFormRef.nativeElement, 'top', true);
});
+2 -2
View File
@@ -150,13 +150,13 @@ export class UsersComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showUsers === true) {
if (this.configurationWizardService.showUsers) {
setTimeout(() => {
this.showPopover(this.templateButtonCreateUser, this.buttonCreateUser.nativeElement, 'bottom', true);
});
}
if (this.configurationWizardService.showUsersList === true) {
if (this.configurationWizardService.showUsersList) {
setTimeout(() => {
this.showPopover(this.templateUsersTable, this.usersTable.nativeElement, 'top', true);
});
@@ -265,7 +265,7 @@ export class CreateUserComponent implements OnInit, AfterViewInit {
if (selectedRoleIds?.length > 0) {
this.usersService.assignRolesToUser(userId, selectedRoleIds).subscribe(
() => {
if (this.configurationWizardService.showUsersForm === true) {
if (this.configurationWizardService.showUsersForm) {
this.configurationWizardService.showUsersForm = false;
this.openDialog();
} else {
@@ -310,7 +310,7 @@ export class CreateUserComponent implements OnInit, AfterViewInit {
* To show popover.
*/
ngAfterViewInit() {
if (this.configurationWizardService.showUsersForm === true) {
if (this.configurationWizardService.showUsersForm) {
setTimeout(() => {
this.showPopover(this.templateUserFormRef, this.userFormRef.nativeElement, 'top', true);
});