CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

WEB-639: Refactor redundant boolean comparisons (#3063)

Browse Source 
improve

improve

improve

improve
This commit is contained in:
Shubham Kumar
2026-01-31 07:07:59 -06:00
committed by GitHub
parent 41a71cd269
commit fbee49b464
55 changed files with 190 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/deposits/fixed-deposits/fixed-deposits-account-actions/add-charge-fixed-deposits-account/add-charge-fixed-deposits-account.component.ts
+1 -1
View File
@@ -147,7 +147,7 @@ export class AddChargeFixedDepositsAccountComponent implements OnInit {
savingsCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
savingsCharge.monthDayFormat = monthDayFormat;
if (savingsCharge.feeOnMonthDay) {
src/app/deposits/recurring-deposits/recurring-deposits-account-actions/add-charge-recurring-deposits-account/add-charge-recurring-deposits-account.component.ts
+1 -1
View File
@@ -146,7 +146,7 @@ export class AddChargeRecurringDepositsAccountComponent implements OnInit {
savingsCharge.feeInterval = this.chargeDetails.feeInterval;
}
if (this.chargeDetails.dueDateNotRequired !== true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth === true) {
if (this.chargeDetails.chargeTimeTypeAnnualOrMonth) {
const monthDayFormat = 'MMMM-dd'; // TODO: Update once language and date settings are setup
savingsCharge.monthDayFormat = monthDayFormat;
if (savingsCharge.feeOnMonthDay) {
src/app/deposits/recurring-deposits/recurring-deposits-account-view/transactions-tab/transactions-tab.component.ts
+4 -4
View File
@@ -117,10 +117,10 @@ export class TransactionsTabComponent implements OnInit {
*/
isDebit(transactionType: any) {
return (
transactionType.withdrawal === true ||
transactionType.feeDeduction === true ||
transactionType.overdraftInterest === true ||
transactionType.withholdTax === true
transactionType.withdrawal ||
transactionType.feeDeduction ||
transactionType.overdraftInterest ||
transactionType.withholdTax
);
}