Merge pull request #1062 from vishwasbabu/develop

handle eclipse warning in portfolio packages

mifosng-provider/src/main/java/org/mifosplatform/infrastructure/cache/PlatformCacheConfiguration.java

@@ -15,6 +15,7 @@ import org.springframework.cache.interceptor.KeyGenerator;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 
+@SuppressWarnings("deprecation")
 @Configuration
 @EnableCaching
 public class PlatformCacheConfiguration implements CachingConfigurer {

mifosng-provider/src/main/java/org/mifosplatform/infrastructure/core/service/AbandonedConnectionCleanupShutdownListener.java

@@ -23,7 +23,7 @@ public class AbandonedConnectionCleanupShutdownListener implements ApplicationLi
     private final static Logger logger = LoggerFactory.getLogger(AbandonedConnectionCleanupShutdownListener.class);
 
     @Override
-    public void onApplicationEvent(ContextStoppedEvent event) {
+    public void onApplicationEvent(@SuppressWarnings("unused") ContextStoppedEvent event) {
         shutDowncleanUpThreadAndDeregisterJDBCDriver();
     }
 

mifosng-provider/src/main/java/org/mifosplatform/infrastructure/jobs/service/JobRegisterServiceImpl.java

@@ -231,7 +231,7 @@ public class JobRegisterServiceImpl implements JobRegisterService, ApplicationLi
     }
 
     @Override
-    public void onApplicationEvent(ContextStoppedEvent event) {
+    public void onApplicationEvent(@SuppressWarnings("unused") ContextStoppedEvent event) {
         this.stopAllSchedulers();
     }
 

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/LoanInterestRecalculationDetails.java

@@ -35,7 +35,6 @@ import org.springframework.data.jpa.domain.AbstractPersistable;
 @Table(name = "m_loan_recalculation_details")
 public class LoanInterestRecalculationDetails extends AbstractPersistable<Long> {
 
-    @SuppressWarnings("unused")
     @OneToOne
     @JoinColumn(name = "loan_id", nullable = false)
     private Loan loan;
@@ -116,12 +115,11 @@ public class LoanInterestRecalculationDetails extends AbstractPersistable<Long>
         }
         return recurrenceOnLocalDate;
     }
-    
+
     public RecalculationFrequencyType getRestFrequencyType() {
         return RecalculationFrequencyType.fromInt(this.restFrequencyType);
     }
 
-    
     public Integer getRestInterval() {
         return this.restInterval;
     }

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java

@@ -31,7 +31,6 @@ public class LoanSchedulePeriodData {
     private final BigDecimal principalPaid;
     private final BigDecimal principalWrittenOff;
     private final BigDecimal principalOutstanding;
-    @SuppressWarnings("unused")
     private final BigDecimal principalLoanBalanceOutstanding;
     @SuppressWarnings("unused")
     private final BigDecimal interestOriginalDue;

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/data/LoanProductData.java

@@ -127,6 +127,7 @@ public class LoanProductData {
     @SuppressWarnings("unused")
     private final List<EnumOptionData> rescheduleStrategyTypeOptions;
 
+    @SuppressWarnings("unused")
     private final List<EnumOptionData> interestRecalculationFrequencyTypeOptions;
 
     private final Boolean multiDisburseLoan;

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/LoanProductInterestRecalculationDetails.java

@@ -31,7 +31,6 @@ import org.springframework.data.jpa.domain.AbstractPersistable;
 @Table(name = "m_product_loan_recalculation_details")
 public class LoanProductInterestRecalculationDetails extends AbstractPersistable<Long> {
 
-    @SuppressWarnings("unused")
     @OneToOne
     @JoinColumn(name = "product_id", nullable = false)
     private LoanProduct loanProduct;

mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanproduct/domain/RecalculationFrequencyType.java

@@ -8,8 +8,6 @@ package org.mifosplatform.portfolio.loanproduct.domain;
 import java.util.HashMap;
 import java.util.Map;
 
-import org.mifosplatform.portfolio.common.domain.PeriodFrequencyType;
-
 public enum RecalculationFrequencyType {
     INVALID(0, "interestRecalculationFrequencyType.invalid"), //
     SAME_AS_REPAYMENT_PERIOD(1, "interestRecalculationFrequencyType.same.as.repayment.period"), //

mifosng-provider/src/main/java/org/mifosplatform/portfolio/savings/domain/SavingsAccount.java

@@ -5,7 +5,6 @@
  */
 package org.mifosplatform.portfolio.savings.domain;
 
-
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.SAVINGS_ACCOUNT_RESOURCE_NAME;
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.allowOverdraftParamName;
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.dueAsOfDateParamName;
@@ -16,7 +15,6 @@ import static org.mifosplatform.portfolio.savings.SavingsApiConstants.lockinPeri
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.minRequiredBalanceParamName;
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.overdraftLimitParamName;
 import static org.mifosplatform.portfolio.savings.SavingsApiConstants.withdrawalFeeForTransfersParamName;
-import org.mifosplatform.organisation.staff.domain.Staff;
 
 import java.math.BigDecimal;
 import java.math.MathContext;
@@ -1193,7 +1191,7 @@ public class SavingsAccount extends AbstractPersistable<Long> {
     public Staff getFieldOfficer() {
         return this.fieldOfficer;
     }
-    
+
     public void unassignFieldOfficer() {
         this.fieldOfficer = null;
     }
@@ -1201,6 +1199,7 @@ public class SavingsAccount extends AbstractPersistable<Long> {
     public void assignFieldOfficer(final Staff fieldOfficer) {
         this.fieldOfficer = fieldOfficer;
     }
+
     public Long clientId() {
         Long id = null;
         if (this.client != null) {