CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity
8,230 Commits 19 Branches 0 Tags
b7e6f356dab07be80b9e4e409b0149489f343207
Commit Graph
8230 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Oleksii NovikovandAdam Saghy b7e6f356da FINERACT-2148: Resolve rounding issue in interest period calculation 2025-01-07 19:40:32 +01:00
leksinomiandAdam Saghy 2fbdbe9df7 FINERACT-2148: Add 'Accelerate maturity' charge-off behaviour option 2025-01-07 18:21:24 +01:00
mariiaKraievskaandAdam Saghy dfc1d3ebad FINERACT-2148: Fix and add tests when interestRecalculation = false and zero interest charge-off behaviour 2025-01-06 09:42:19 +01:00
mariiaKraievskaandAdam Saghy faaf44d91a FINERACT-2148: Process monetary transaction after zero interest charge-off. 2025-01-01 15:52:57 +01:00
Adam Saghy 23850a1b73 FINERACT-2081: Fix Connection is not available, request timed out after 30000ms issue of "read-only" check 2024-12-22 18:06:28 +01:00
Andrii KulminskyiandAdam Saghy c2ec015e64 FINERACT-2152: API Create and retrieve interest pause 2024-12-19 22:24:02 +01:00
Adam Saghy e94e6c421a FINERACT-1806: Unify Charge-off reason mapping fields 2024-12-19 17:26:24 +01:00
Adam Saghy 8123276981 FINERACT-1806: Rework Product to GL account mapping and fix charge-off reason typos 2024-12-18 15:13:43 +01:00
adam.magyariandAdam Saghy 696be57c7c FINERACT-1806: fix ProductToGLAccountMapping 2024-12-18 15:13:43 +01:00
dependabot[bot]andArnold Gálovics d56e422a33 Bump actions/setup-java from 4.5.0 to 4.6.0 
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/8df1039502a15bceb9433410b1a100fbe190c53b...7a6d8a8234af8eb26422e24e3006232cccaa061b)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-12-18 14:04:51 +01:00
dependabot[bot]andArnold Gálovics 61b65ee1d6 Bump actions/upload-artifact from 4.4.3 to 4.5.0 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882...6f51ac03b9356f520e9adb1b1b7802705f340c2b)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-12-18 14:04:46 +01:00
dependabot[bot]andArnold Gálovics a98fb07659 Bump gradle/actions from 4.2.1 to 4.2.2 
Bumps [gradle/actions](https://github.com/gradle/actions) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/gradle/actions/releases)
- [Commits](https://github.com/gradle/actions/compare/cc4fc85e6b35bafd578d5ffbc76a5518407e1af0...0bdd871935719febd78681f197cd39af5b6e16a6)

---
updated-dependencies:
- dependency-name: gradle/actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-12-18 14:04:38 +01:00
Adam Saghy d03973165d FINERACT-2081: Support read-only transactions via Batch API 2024-12-17 14:49:18 +01:00
Jose Alberto HernandezandAdam Saghy 8716751c88 FINERACT-1971: Fix boolean values used in Loan product charge-off reasons accounting mappings 2024-12-17 10:51:30 +01:00
leksinomiandAdam Saghy 3735aea598 FINERACT-2081: Refactor LoanSummaryWrapper 2024-12-16 18:20:14 +01:00
Adam Saghy 4f470606ff FINERACT-2081: Update Trial Balance Summary Report with Year end retaining 2024-12-16 16:14:10 +01:00
Oleksii NovikovandAdam Saghy 51433ffb66 FINERACT-2148: Update instalments interest with zero after charge off with interest recalculation enabled 2024-12-16 14:31:54 +01:00
Marta JankovicsandArnold Gálovics 136bb0009a FINERACT-2060: Progressive loan - final accrual calculation on closed loan 2024-12-13 16:48:07 +01:00
Michael VorburgerandArnold Gálovics c4cdd6f51a Fix broken "Badges" on README 2024-12-13 14:58:48 +01:00
Michael VorburgerandArnold Gálovics 3800ad5cbf Revert "Update plugin org.sonarqube to v6" 
This reverts commit a9a7e77afc.
 2024-12-13 10:00:53 +01:00
Adam Saghy 5667bc89be FINERACT-2081: Consider read-only all the transactions when the connection is read-only 2024-12-12 17:43:31 +01:00
Adam Saghy d57906d4fa FINERACT-2081: Refactor - Simplify LoanSchedulePeriodData.java class 2024-12-11 19:10:10 +01:00
Arnold GalovicsandArnold Gálovics 263866c03a FINERACT-2081: Avoid creating unnecessary connection pools 2024-12-11 17:26:07 +01:00
Janos MeszarosandAdam Saghy bb8480a03d FINERACT-1981: Embeddable Progressive Loan Schedule generator 2024-12-10 15:04:16 +01:00
adam.magyariandAdam Saghy d0006a2169 FINERACT-1971: update installment accrued portions on charge accrual 2024-12-10 15:04:01 +01:00
adam.magyariandArnold Gálovics bc2ef08e0c FINERACT-2148: Add test for charge-off accruals 2024-12-07 13:25:19 +01:00
adam.magyariandArnold Gálovics 56350673ad FINERACT-1981: fix post maturity charge removed by cob on progressive loan 2024-12-07 13:25:07 +01:00
Jose Alberto HernandezandArnold Gálovics 84f01e0687 FINERACT-2081: Remove skip tag E2E test case C2501 2024-12-07 13:23:49 +01:00
Adam Saghy 3490219577 FINERACT-2148: Backdated Charge-off with interest recalculation 2024-12-06 16:49:55 +01:00
Oleksii NovikovandAdam Saghy a2c01d25e5 FINERACT-2080: Move loan validation from entity to validator classes 2024-12-05 13:58:47 +01:00
Andrii KulminskyiandAdam Saghy 56ee2eaaff FINERACT-1806: Advanced Charge-off Expense Accounting - "Advanced Accounting Rule" takes priority 2024-12-04 17:43:51 +01:00
adam.magyariandArnold Gálovics 5c08afec5f FINERACT-1926: Additional indices to investor tables 2024-12-03 16:02:58 +01:00
Mend RenovateandArnold Gálovics af34f31463 Update postgres Docker tag to v17 2024-12-03 07:26:26 +01:00
Mend RenovateandArnold Gálovics a9a7e77afc Update plugin org.sonarqube to v6 2024-12-03 07:26:20 +01:00
Marta JankovicsandAdam Saghy 7bd1f510a3 FINERACT-1981: COB/Inline COB fails while creating accruals for a overpaid account 2024-12-02 15:34:39 +01:00
Adam Saghy f63df474f6 FINERACT-2154: Store "Pre-close interest calculation strategy" on loan level 2024-11-29 21:39:08 +01:00
Jose Alberto HernandezandAdam Saghy 8d12bc04e9 FINERACT-2081: Retrieving Loan Product details with invalid external-id results in 500 error 2024-11-29 19:36:20 +01:00
Marta JankovicsandAdam Saghy d57e72ec2f FINERACT-2060: Accrual reverse replay logic and Handling 2024-11-29 19:17:23 +01:00
Jose Alberto HernandezandAdam Saghy 8d25b0c765 FINERACT-1981: Reverse Interest Refund transaction not allowed directly with 403 error 2024-11-29 12:28:37 +01:00
adam.magyariandAdam Saghy ff5e993b16 FINERACT-2148: return loan charge off behaviour with loan details 2024-11-29 12:24:23 +01:00
Janos MeszarosandAdam Saghy 4cb849fa17 FINERACT-1981: Introduce Interest should not be calculated on past due principal amount 2024-11-29 11:59:18 +01:00
Kristof JozsaandGitHub 3858611190 Merge pull request #4194 from adamsaghy/update_logback_of_e2e_runner 
FINERACT-2081: Update logger level for E2E tests
 2024-11-28 17:07:40 +01:00
Adam Saghy 0a8ddd24e7 FINERACT-2081: Update logger level for E2E tests 2024-11-28 14:40:49 +01:00
Soma SörösandAdam Saghy f5d9a3a025 FINERACT-1981: Update Payable Interest Calculation For LoanSummaryData 2024-11-28 13:14:45 +01:00
leksinomiandAdam Saghy 32cc83fdbf FINERACT-2153: Enable immediate charge accrual creation post maturity 2024-11-27 17:49:42 +01:00
Jose Alberto HernandezandAdam Saghy 1ef9c0f4bb FINERACT-1981: Reverse Interest Refund transaction not allowed directly 2024-11-27 17:43:08 +01:00
Adam MonsenandAdam Saghy 4956bdd574 FINERACT-2149: disable liquibase phone home 
At some point, Liquibase added an analytics/telemetry "phone home" to gather user data.

I get how companies and FOSS projects greatly benefit from knowing more about their users, but I think this should only be done with proper consent. I would not assume/expect any libraries to send analytics home. The default behavior of trackers like these should always be to *not* phone home without a user first consenting / opting in.

---

I'm not sure this is the right change, but it works (feedback welcome). My naïve test/check to know this works is visually inspecting the output of the log message I added in TenantDatabaseUpgradeService to see if `liquibase.analytics.enabled` is set, and to what. I'm happy to automate this, but it seemed unnecessary (again, feedback welcome).

We could also disable the phone home with an environment variable ( LIQUIBASE_ANALYTICS_ENABLED=false , see https://docs.liquibase.com/analytics/home.html ). I'm not sure where that should be set if we did. Likely several places (for build/dev/test/ci/qa/etc.).

I originally noticed the phone home because I block requests from my computer to 3rd party tracking/analytics services, and I was getting this error in my console:

    java.net.ConnectException: Connection refused at liquibase.analytics.LiquibaseAnalyticsListener

At first I misunderstood this as a database connection error, but it was really just liquibase throwing an error because it couldn't connect to its own analytics server.

If we were to create a configurable property, I think the ideal place to set the value would be in fineract-provider/src/main/resources/application.properties, (default to false, allow override) but our version of spring boot doesn't support it yet ( see https://github.com/spring-projects/spring-boot/issues/43067 ) so we'd have to add the usual scaffolding required for a Fineract setting. I'm not sure we want/need that, because I can't imagine anyone *wanting* to set the flag to `true`, and my naïve hardcoded global change is less code to maintain than providing a configurable setting. If there's demand to make it configurable later, we could of course do that (especially once it becomes easier to do so). I feel like how we let Liquibase behave is up to us, though. An under the hood / upstream decision we get to make.

See also:

* https://lists.apache.org/thread/5s7zjsxdcqk1qvjnc1wbhqqv66shpl54
* Analytics is enabled by default in OSS version · Issue #6503 · liquibase/liquibase · GitHub https://github.com/liquibase/liquibase/issues/6503
* Add a method for Spring Boot to configure the new analytics feature · Issue #6501 · liquibase/liquibase · GitHub https://github.com/liquibase/liquibase/issues/6501
 2024-11-27 17:13:23 +01:00
Andrii KulminskyiandAdam Saghy bfae135b54 FINERACT-1806: fetch loan product details must return the chargeoffreason mapping 2024-11-27 15:37:38 +01:00
adam.magyariandAdam Saghy 479e71cdad FINERACT-2148: loan charge off behaviour configuration 2024-11-27 11:31:05 +01:00
Jose Alberto HernandezandAdam Saghy 240a6dffc8 FINERACT-2081: Enable inline COB execution for locked loans 2024-11-27 10:09:49 +01:00