CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
5,678 Commits 21 Branches 0 Tags
8a3c1903a4c28bbd5fa13d94813a0e1a0ddb419e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Vorburger ⛑️ bc60bc379a Update fineract-provider/config/swagger/fineract-input.yaml 2020-08-02 17:48:43 +02:00
Michael Vorburger ⛑️ 98645840a5 minor Swagger clean-up in README 2020-08-02 16:59:09 +02:00
Michael Vorburger ⛑️andPetri Tuomola c5c62de491 Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838) 2020-08-02 06:23:25 +03:00
Michael Vorburger 9534e7e0a3 fix broken build 2020-07-19 16:43:41 +02:00
Michael Vorburger ⛑️ 55b44dbf12 Update openjpa to v3.1.2 also in dependencyManagement not just buildscript 2020-07-19 15:45:54 +02:00
Michael Vorburger 1623e80a7f make ApiParameterError (almost) immutable 
by making (most of) its fields final, because Immutable is Good

Only "almost" / "most" because of the of the remaining use of setParameterName() in
EntityDatatableChecksWritePlatformServiceImpl.saveDatatables() which unfortunately looks
a lot less trivial to get rid of, so that's for another time/someone else, later (or never).
 2020-07-02 21:47:02 +02:00
Michael Vorburger 10536c0f91 make SimpleDateFormat use in ApiParameterError thread-safe [FINERACT-1063] 2020-07-02 21:46:10 +02:00
Michael Vorburger 2e32166079 Make Google's Guava library an explicit dependency 
Instead of only transitively inheriting it through activemq-broker,
so that the upcoming next major upgrade of activemq-broker doesn't break the build.

Note that Fineract code already extensively uses Guava, this just makes it explicit.
 2020-07-02 21:45:40 +02:00
Michael Vorburger 9ed9153cba use AbstractPlatformException's defaultUserMessage as RuntimeException's message [FINERACT-1062] 2020-06-30 21:28:20 +02:00
Michael Vorburger bcfbe65d56 use new AbstractPlatformException in AbstractPlatformException 
only indirectly related to FINERACT-942, but makes sense to do so now
 2020-06-30 21:28:20 +02:00
Michael Vorburger 56cad56848 use AbstractPlatformException as superclass for various exceptions 
related to FINERACT-942 and as per code review discussion in PR #1079.
 2020-06-30 21:28:20 +02:00
Michael VorburgerandYemdjih Kaze Nasser 24d4c45d9a introduce Throwable cause to AbstractPlatformResourceNotFoundException (re. FINERACT-942) 2020-06-24 16:03:10 +01:00
Michael VorburgerandAwasum Yannick eb2b39f160 add @Disabled to 2 old unit tests (which perhaps should be removed) 
This saves a few seconds ;) in the build, and (more importantly)
makes it easier to find all the project's @Disabled (formerly @Ignore) tests.
 2020-06-24 10:39:20 +01:00
Michael Vorburger c529fdf58c increase auto formatting comment line length from 80 to 120 2020-06-23 10:01:12 +02:00
Michael Vorburger 9da5932307 bulk auto reformat ca. 2900 files using ./gradlew :spotlessApply [FINERACT-1006] 2020-06-14 18:31:47 +02:00
Michael Vorburger 64628345a0 remove (old, bad) SchedulerJobHelper.executeJob() [FINERACT-922] 2020-06-14 17:51:57 +02:00
Michael Vorburger 67e6e27b54 fix broken tests under JUnit 5 [FINERACT-1021] 2020-06-14 17:21:07 +02:00
Michael Vorburger 508e915b4f add missing useJUnitPlatform() to make Gradle run JUnit 5 [FINERACT-1021] 2020-06-14 17:21:07 +02:00
Michael Vorburger 4528231fd1 remove bad 'default:' in SavingsEnumerations switch 
This default: is "wrong", because it's not required - the switch,
in this particular case, *IS* actually already handling all cases.

But if in the future someone were to add an additional new
SavingsAccountTransactionType, then we would want Error Prone to
fail to signal that it needs to be handled here - but the "default:"
would "hide" that.

This is a follow-up to https://github.com/apache/fineract/pull/983/
for FINERACT-822, and also related to the discussion started on
https://github.com/apache/fineract/pull/989.

There originally used to be a "default:" in the middle of the switch,
that obviously WAS completely wrong and an old copy-paste bug.
 2020-06-07 18:40:08 +02:00
Michael Vorburger dcaaf1a4e8 do NOT .gitignore gradle/ as it IS in Git (FINERACT-962) 2020-06-07 14:11:04 +02:00
Michael VorburgerandYemdjih Kaze Nasser 0e6a0e3ee3 remove old constructor from SchedulerJobHelper (related to FINERACT-922) 2020-06-07 13:08:08 +01:00
Michael Vorburger ⛑️andGitHub 7a2d459af3 Merge pull request #972 from percyashu/errorprone_variableNameSameAsType 
FINERACT-822 enable variableNameSameAsType warning
 2020-06-03 22:13:56 +02:00
Michael VorburgerandYemdjih Kaze Nasser 0c6903fc36 executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest 
re. FINERACT-950 and FINERACT-922
 2020-06-03 01:59:14 +01:00
Michael Vorburger c95fb17f6e minor: simplify hashCode() in CenterDomain 2020-06-02 21:15:36 +02:00
Michael VorburgerandYemdjih Kaze Nasser 60dd63d55f executeAndAwaitJob() !executeJob() ClientSavingsIntegrationTest 
re. FINERACT-852 and FINERACT-922
 2020-06-02 19:49:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser a58b14c9d2 executeAndAwaitJob() !executeJob() ClientLoanIntegrationTest un-ignore 
re. FINERACT-885 and FINERACT-922
 2020-06-02 19:46:04 +01:00
Michael Vorburger ⛑️ 734cbb1d1f Renovate ignore docs/ and add label [FINERACT-962] 2020-06-02 19:57:42 +02:00
Michael Vorburger fd3b75711c remove line in AbstractLoanScheduleGenerator [FINERACT-977] 
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
 2020-06-02 19:52:30 +02:00
Michael VorburgerandYemdjih Kaze Nasser 6f128bf508 minor clean-up to eliminate 'dead code' in CodeValue 
This fixes one of too many ;) warnings Eclipse shows.

It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
 2020-06-02 15:36:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser 956a84114f improve StaffImageApiTest (for FINERACT-965 non-regression) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 83de217b64 minor clean-up in StaffImageApiTest (re. FINERACT-965) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 619fe44d0e bump OpenPDF from 1.1.0 to 1.3.17 + swap Base64 [FINERACT-965] 
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
 2020-06-02 15:29:45 +01:00
Michael Vorburger d439aa9545 replace api-docs links to mifos.io with fineract.dev [FINERACT-840] 2020-06-02 13:20:17 +02:00
Michael VorburgerandYemdjih Kaze Nasser 1db6e8d206 fix ClasspathHellDuplicatesCheckRuleTest (FINERACT-966) 
and prevent FINERACT-940 related javax.xml.parsers problems

as per https://github.com/spotbugs/spotbugs/issues/1128
 2020-05-29 06:13:23 +01:00
Michael Vorburger 4b108f02ec fix broken build due to @Deprecated error [FINERACT-1012] 2020-05-28 22:36:03 +02:00
Michael Vorburger ⛑️andGitHub b3da50c960 intro. SchedulerJobsHelper.executeAndAwaitJob() [FINERACT-922] (#817) 2020-05-24 20:54:37 +01:00
Michael Vorburger ⛑️andGitHub 4cb9f9d3e0 improve logging in SchedulerTriggerListener (re. FINERACT-922) (#812) 2020-05-24 20:18:36 +01:00
Michael Vorburger ⛑️ 4194da2b90 add new Logging Guidelines section to README (re. FINERACT-942) 2020-05-23 20:48:44 +02:00
Michael Vorburger ⛑️andGitHub dc7c1f8404 add link to our shiny new JIRA Dashboard to README [FINERACT-1000] (#929) 
also remove link to supposed "Roadmap", because that really was just a confusing link to 1000 JIRA issues.

see FINERACT-1000
 2020-05-23 14:52:28 +01:00
Michael VorburgerandYemdjih Kaze Nasser 5b1c46c821 remove logback.xml (see FINERACT-888) 
Read e.g. https://12factor.net/logs for why we don't want to log
to a fineract-platform.log file anymore by default.  Of course, anyone
could still customize logging as they see fit for their own deployments.
 2020-05-23 12:38:20 +01:00
Michael VorburgerandYemdjih Kaze Nasser 3d0d515b4b ignore StorageTest [FINERACT-828] 2020-05-22 03:56:22 +01:00
Michael VorburgerandYemdjih Kaze Nasser d4e8a7edd0 do not attempt to run Deploy to Fineract.dev GitHub Workflow on Forks [FINERACT-970] 2020-05-22 03:47:17 +01:00
Michael Vorburger ⛑️andGitHub f93cd4dbbd minor README moves (#909) 2020-05-20 11:33:09 +01:00
Michael Vorburger ⛑️andGitHub a36c0f725b add new Dependency Upgrades section to README (#910) 2020-05-20 10:56:33 +01:00
Michael Vorburger ⛑️andGitHub e8276f0aea Remove direct explicit Guava dependency (FINERACT-963) (#913) 
We *ARE* using Guava, but, unless we have a real need for a more recent
specific version, it seems "safer" (and less hassle to maintain bumping)
just using whatever version we transitively inherit from other libraries
we use that themselves depend on Guava (currently Swagger, Mustache and
activemq-broker).

Currently that "whatever version" is a 28.2 (we used 28.1 before).

This removes two fairly different kinds of Guava dependencies we have:
One for run-time (above), and one for build time which seems to have
been added due to some SpotBugs related issue (but it now works without
that, so that must have been some issue in SpotBugs that meanwhile go
fixed in the recent versions).
 2020-05-20 10:00:29 +01:00
Michael Vorburger dd0c838439 improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953) 
to ignore all META-INF/groovy** such as
META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule which is
part of both groovy-xml-3.0.3.jar as well as e.g. ical4j-3.0.18.jar
 2020-05-19 23:01:28 +02:00
Michael Vorburger 5557b8be4a fix moar flaky StorageTest.testNotificationStorage() [FINERACT-828] 
similar fix to earlier Pull Request for the same

also added some more toString()
 2020-05-17 21:29:20 +02:00
Michael Vorburger ⛑️andGitHub e7889f8463 copy .git/** into build container so git.properties can be generated [FINERACT-983] (#904) 2020-05-17 10:33:29 +01:00
Michael Vorburger 7a98ad8d07 add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922) 
This would catch problems such as the integration tests running "too
early" (before Flyway has fully initialized the database), which I have
a suspicion could be one of (many) causes of the unstable scheduler
tests, notably because of the IllegalArgumentException at
SchedulerJobsTest.java:90 in https://github.com/apache/fineract/pull/817
 2020-05-17 10:56:59 +02:00
Michael Vorburger 904da67bbd Remove un-used "Send messages to Email gateway" Job (FINERACT-952) 2020-05-17 10:56:59 +02:00
Michael Vorburger cbc274f603 remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938) 2020-05-17 10:53:42 +02:00
Michael Vorburger ⛑️andGitHub f7f52f04d1 Merge pull request #852 from vorburger/FINERACT-922_SchedulerJobsTest-reset-world-as-found 
make SchedulerJobsTest preserve scheduler and job states (FINERACT-922)
 2020-05-17 02:52:27 +02:00
Michael Vorburger e0d4a1f376 make SchedulerJobsTest preserve scheduler and job states (FINERACT-922) 2020-05-17 02:25:51 +02:00
Michael Vorburger ⛑️andGitHub ddaffd13c0 Merge pull request #857 from xurror/FINERACT-897 
[WIP] MySQL v8(FINERACT-897)
 2020-05-17 02:13:49 +02:00
Michael Vorburger 00aa71b0e1 rm .github/workflows/first-interaction.yml 
because it's broken, see
https://github.com/actions/first-interaction/issues/10
 2020-05-17 00:21:00 +02:00
Michael Vorburger a0e20588aa fix canceling previous ongoing jobs on Fineract.dev [FINERACT-970] 2020-05-17 00:19:11 +02:00
Michael Vorburger edcdcc34a2 cancel previous ongoing jobs on Fineract.dev when updating [FINERACT-970] 2020-05-17 00:08:07 +02:00
Michael Vorburger 1fdc033923 use --no-daemon in Dockerfile (and don't clean; really no need) [FINERACT-970] 2020-05-16 23:46:27 +02:00
Michael Vorburger 711ea1d6cd gcloud components install beta to deploy to https://Fineract.dev [FINERACT-970] 2020-05-16 23:34:46 +02:00
Michael Vorburger 84dfb32c34 use --quiet to deploy to https://Fineract.dev [FINERACT-970] 2020-05-16 23:26:43 +02:00
Michael Vorburger 04d3ce673c automatically deploy to https://Fineract.dev [FINERACT-970] 2020-05-16 23:07:53 +02:00
Michael Vorburger c764d32d5e fix Flyway table name problem (FINERACT-979) 2020-05-16 18:34:19 +02:00
Michael Vorburger 9ce72fe67b fix broken build 
Combination of recently separately merged PRs #865 and #859 broke it.
 2020-05-15 22:56:13 +02:00
Michael Vorburger ⛑️andGitHub 0eee0ff775 make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859) 
This is just a first step - we should aim for -Xlint:all! ;)
 2020-05-15 21:31:16 +01:00
Michael Vorburger ⛑️andGitHub 39675c9a23 rewrite MultiException to actually contain all causes (FINERACT-858) (#855) 2020-05-15 21:30:33 +01:00
Michael Vorburger 2aca64056a fix flaky StorageTest.testNotificationStorage() (FINERACT-828) 2020-05-15 20:12:37 +02:00
Michael Vorburger 297e483742 fix invalid YAML syntax in (broken) GitHub Action 2020-05-12 20:54:27 +02:00
Michael Vorburger ⛑️andGitHub dec9d21f71 add First Interaction Greeting GitHub Action (#880) 2020-05-11 12:09:57 +01:00
Michael Vorburger 3226b63383 remove broken dev-dependencies.gradle (until FINERACT-939) 2020-05-10 21:48:05 +02:00
Michael Vorburger 8743fc9743 fix (?) .github/workflows/rebase.yml (FINERACT-829) 2020-05-10 16:20:45 +02:00
Michael Vorburger 47549ae438 add toString() to Notification (to help debug FINERACT-828 next time) 2020-05-10 16:19:09 +02:00
Michael Vorburger 0cc18d7b8c fix obvious bug in Notification setActor() 
This method doesn't seem to be used anywhere, so it never mattered.

Eclipse pointed out "The assignment to variable actorId has no effect".

We should not ignore javac/Eclipse compiler warnings! => FINERACT-959
 2020-05-10 16:19:09 +02:00
Michael Vorburger d2d013b78f use Java >11.0.2 instead of Java 12 on Travis (FINERACT-937) 
by ditching Travis' own sad state of Java (cough) 'support'

and just re-installing it ourselves instead
 2020-05-10 15:04:26 +02:00
Michael Vorburger b525925b57 bump org.apache.bval.bundle from 2.0.2 to 2.0.3 
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-05-10 14:54:19 +02:00
Michael Vorburger 55af726cf9 improve SchedulerJobsTest.testDateFormat() by introducing Awaitility 
This recently introduced new test (FINERACT-926) would locally pass, but
then fail on the next run, because another test in the same class would
modify job state to be inactive.  It now sets the first jobs state as it
requires it to be, and properly awaits the expected outcome.
 2020-05-09 17:05:32 +02:00
Michael Vorburger e122f1ffd3 fix bug causing NullPointerException in SavingsAccount (FINERACT-957) 2020-05-09 13:31:39 +02:00
Michael Vorburger 27d754529e bulk replace org.apache.commons.lang with lang3 imports (FINERACT-954) 
We apparently currently have both on the classpath, but really nowadays
should have, and can, only use lang3 with this minor clean up.
 2020-05-09 05:48:31 +02:00
Michael Vorburger 6a8f48c06c remove fixed Slfj4j versions to fix broken logging (FINERACT-956) 2020-05-09 05:48:15 +02:00
Michael Vorburger fa74e77e7e clean up dependencies.gradle and clarify scopes (FINERACT-777) 
This also solves this Gradle messages:  Deprecated Gradle features were
used in this build, making it incompatible with Gradle 7.0. Use
'--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.4/userguide/command_line_interface.html#sec:command_line_warnings
 2020-05-09 05:47:13 +02:00
Michael Vorburger 6c3598535b upgrade Gradle (wrapper) from 6.1 to 6.4 (FINERACT-945) 2020-05-09 00:05:10 +02:00
Michael Vorburger ff1c15d263 rm application.properties from Git, and .gitignore it (because we copy it during build) 2020-05-09 00:03:57 +02:00
Michael Vorburger f6c7bf970b ignore yet another :( RecurringDepositTest (FINERACT-855) 
testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX
 2020-05-09 00:03:50 +02:00
Michael Vorburger 4ade89d57d add integration test for (new) ISO-8601 Date Format (FINERACT-926) 
using SchedulerJobsTest, just because that's convenient
 2020-05-08 23:29:38 +02:00
Michael Vorburger 3ac7c29e51 clean up CommandHandlerProviderTest 2020-05-08 23:04:08 +02:00
Michael Vorburger 29d64d3cb0 remove org.gradle.daemon (FINERACT-948) 2020-05-08 22:41:14 +02:00
Michael Vorburger ⛑️ c6b5b2776b add "Instructions to build the JAR file" to README 2020-05-08 22:02:16 +02:00
Michael Vorburger ⛑️andGitHub bee3fb7ce5 add java.util.Date ISO-8601 GSON type adapter (FINERACT-926) (#816) 
* minor clean-up in existing JsonSerializer implementations (FINERACT-926)

* centralize registration of GSON type adapters (FINERACT-926)

* add java.util.Date ISO-8601 GSON type adapter (FINERACT-926)
 2020-05-08 19:56:19 +01:00
Michael Vorburger ⛑️ f049892600 clarify Docker Compose UI self-signed SSL certificate 
as suggested by Scott Dunbar on dev list
 2020-05-08 20:31:12 +02:00
Michael Vorburger 6b1878a1d8 ignore one flaky FixedDepositTest (FINERACT-950) 
testFixedDepositAccountClosureTypeWithdrawal_WITH_HOLD_TAX()
 2020-05-08 20:30:25 +02:00
Michael Vorburger 077065c1b5 fix generic warnings in StaffTest (re. FINERACT-949) 2020-05-08 20:24:31 +02:00
Michael Vorburger ⛑️andGitHub 22224709b6 upgrade Spotbugs plugin from 2.0.1 to latest 4.0.8 (FINERACT-947) (#841) 2020-05-08 19:15:19 +01:00
Michael Vorburger ⛑️andGitHub d2a0493be4 add server.forward-headers-strategy=framework (FINERACT-914) (#798) 2020-05-08 18:47:53 +01:00
Michael Vorburger ⛑️andGitHub e2d076f15e ignore another flaky test in SchedulerJobsTestResults (FINERACT-857) (#839) 
testUpdateLoanArrearsAgingJobOutcome()
 2020-05-08 18:18:26 +01:00
Michael Vorburger ⛑️andGitHub 1263a00691 change Oracle to OpenJDK in README (#836) 2020-05-08 18:17:21 +01:00
Michael Vorburger bbadeb9591 add Gradle Wrapper Validation GitHub Action (FINERACT-946) 
see https://github.com/marketplace/actions/gradle-wrapper-validation
 2020-05-08 18:07:22 +02:00
Michael Vorburger ea85f9c739 clean up XBRLBuilderTest (re. FINERACT-940) 2020-05-08 17:04:43 +02:00
Michael Vorburger 69a7b1e8da add junit-platform-runner dependency (FINERACT-943) 2020-05-08 16:59:52 +02:00
Michael Vorburger 9254a74bb5 upgrade Spring Boot from 2.2.4 to 2.2.7 (FINERACT-941) 2020-05-08 16:16:56 +02:00
Michael Vorburger bb4f1ac29a add keystore.jks to .gitignore 
This file is created by the Tomcat embedded by Spring Boot
when running "java -jar build/libs/fineract-provider.jar",
having it on .gitignore avoids anyone commiting it by mistake.
 2020-05-05 22:50:23 +02:00
Michael Vorburger cb690f6d5b ignore three more flaky tests in SchedulerJobsTestResults (FINERACT-857) 
testInterestTransferForSavings()
testExecuteStandingInstructionsJobOutcome()
testAvoidUnncessaryPenaltyWhenAmountZeroForOverdueLoansJobOutcome()
 2020-05-05 20:13:11 +02:00