Petri Tuomola and Michael Vorburger ⛑️
a54c124449
FINERACT-899: Fixing AccountingScenarioIntegrationTests
2020-06-08 07:04:28 +02:00
Petri Tuomola and Michael Vorburger ⛑️
b31e6c2881
FINERACT-1019: Fix failing import integration tests
2020-06-08 07:00:15 +02:00
Petri Tuomola and Michael Vorburger ⛑️
6eb3873a5b
Fixed OfficeImportTest
2020-06-08 07:00:15 +02:00
percyashu and Yemdjih Kaze Nasser
cfe5848a02
FINERACT-822 enable OperatorPrecedence error
2020-06-08 02:32:30 +01:00
percyashu and Yemdjih Kaze Nasser
d5af661231
FINERACT-822 enable OperatorPrecedence error
2020-06-08 02:32:30 +01:00
Renovate Bot and Michael Vorburger ⛑️
62d8d49312
Update dependency org.apache.tomcat:tomcat to v9.0.36
2020-06-07 23:04:18 +02:00
Michael Vorburger
4528231fd1
remove bad 'default:' in SavingsEnumerations switch
...
This default: is "wrong", because it's not required - the switch,
in this particular case, *IS* actually already handling all cases.
But if in the future someone were to add an additional new
SavingsAccountTransactionType, then we would want Error Prone to
fail to signal that it needs to be handled here - but the "default:"
would "hide" that.
This is a follow-up to https://github.com/apache/fineract/pull/983/
for FINERACT-822, and also related to the discussion started on
https://github.com/apache/fineract/pull/989 .
There originally used to be a "default:" in the middle of the switch,
that obviously WAS completely wrong and an old copy-paste bug.
2020-06-07 18:40:08 +02:00
Renovate Bot and Michael Vorburger ⛑️
2db2e38796
Update dependency org.apache.tomcat:tomcat to v9.0.35
2020-06-07 15:30:09 +02:00
Renovate Bot and Michael Vorburger ⛑️
37a958e614
Update dependency org.nosphere.apache:creadur-rat-gradle to v0.7.0
2020-06-07 15:29:40 +02:00
Renovate Bot and Michael Vorburger ⛑️
9e67c27749
Update dependency net.ltgt.gradle:gradle-errorprone-plugin to v1.2.1
2020-06-07 14:12:23 +02:00
Renovate Bot and Michael Vorburger ⛑️
916e33daa8
Update dependency gradle.plugin.com.github.spotbugs.snom:spotbugs-gradle-plugin to v4.3.0
2020-06-07 14:11:38 +02:00
Michael Vorburger
dcaaf1a4e8
do NOT .gitignore gradle/ as it IS in Git (FINERACT-962)
2020-06-07 14:11:04 +02:00
Michael Vorburger and Yemdjih Kaze Nasser
0e6a0e3ee3
remove old constructor from SchedulerJobHelper (related to FINERACT-922)
2020-06-07 13:08:08 +01:00
xurror and Michael Vorburger ⛑️
4aa3404e88
FINERACT-1002(distch plus and use fixed versions instead)
2020-06-07 12:49:25 +02:00
Manthan Surkar and Michael Vorburger ⛑️
b0ff8dbb60
FINERACT-821 Added and Enforced MethodName Checkstyle
2020-06-07 02:05:40 +02:00
Manthan Surkar and Michael Vorburger ⛑️
73e1fe77e9
FINERACT-821 Made changes to enforce ConstantName Checkstyle (2)
2020-06-07 02:03:16 +02:00
Percy Ayuk Ashu and GitHub
910eb1f7a8
FINERACT-822 enable MissingCasesInEnumSwitch error ( #989 )
2020-06-06 22:05:43 +01:00
Percy Ayuk Ashu and GitHub
cd3621cb60
FINERACT-822 Enabling ErrorProne error checks ( #983 )
2020-06-05 16:42:01 +01:00
Percy Ayuk Ashu and GitHub
78857bcf81
FINERACT-822 Enabling MultiVariableDeclaration check ( #981 )
2020-06-05 10:28:00 +01:00
Percy Ayuk Ashu and GitHub
99b0136f40
FINERACT-822 Enabling AssertEqualsArgumentOrderChecker check ( #982 )
2020-06-05 09:10:18 +01:00
percyashu and Yemdjih Kaze Nasser
960e81af1c
FINERACT-822 Enabling UnnecessaryParentheses check
2020-06-04 02:14:25 +01:00
thesmallstar and Yemdjih Kaze Nasser
cc6bf4b4b0
FINERACT-821 Added MethodTypeParameterName checkstyle
2020-06-04 02:08:09 +01:00
Petri Tuomola and Michael Vorburger ⛑️
14b14aecac
FINERACT-1017: Fixing LoanImport integration tests
2020-06-03 22:25:36 +02:00
Michael Vorburger ⛑️ and GitHub
7a2d459af3
Merge pull request #972 from percyashu/errorprone_variableNameSameAsType
...
FINERACT-822 enable variableNameSameAsType warning
2020-06-03 22:13:56 +02:00
Manthan Surkar and Michael Vorburger ⛑️
9cda5f984a
FINERACT-821 Made changes to enforce ConstantName Checkstyle (1)
2020-06-03 22:13:19 +02:00
nnatarajan and Michael Vorburger ⛑️
3521b0ed33
FINERACT-933 Fixed ArrayIndexOutOfBoundsException at ClientPersonImportHandler
2020-06-03 10:50:48 +02:00
nnatarajan and Michael Vorburger ⛑️
8d7fa73b46
FINERACT-933 Suggestion to fix ArrayIndexOutOfBoundsException
2020-06-03 10:50:48 +02:00
nnatarajan and Michael Vorburger ⛑️
97cbb13c9c
FINERACT-1004 Resolved NPE in AddressWritePlatformServiceImpl.updateClientAddress()
2020-06-03 09:55:24 +02:00
Michael Vorburger and Yemdjih Kaze Nasser
0c6903fc36
executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest
...
re. FINERACT-950 and FINERACT-922
2020-06-03 01:59:14 +01:00
thesmallstar and Michael Vorburger ⛑️
140435bca4
FINERACT-821 Added OneTopLevelClass checkstyle
2020-06-02 22:49:02 +02:00
Renovate Bot and Michael Vorburger ⛑️
44eff92e6f
chore(deps): update dependency com.puppycrawl.tools:checkstyle to v8.33
2020-06-02 22:43:04 +02:00
percyashu
f685eb7a68
FINERACT-822 enable VariableNameSameAsType warning
2020-06-02 21:34:12 +01:00
Renovate Bot and Michael Vorburger ⛑️
bdb979e8ce
Update dependency com.github.sevntu-checkstyle:sevntu-checks to v1.37.1
2020-06-02 21:26:17 +02:00
Michael Vorburger
c95fb17f6e
minor: simplify hashCode() in CenterDomain
2020-06-02 21:15:36 +02:00
Michael Vorburger and Yemdjih Kaze Nasser
60dd63d55f
executeAndAwaitJob() !executeJob() ClientSavingsIntegrationTest
...
re. FINERACT-852 and FINERACT-922
2020-06-02 19:49:09 +01:00
Michael Vorburger and Yemdjih Kaze Nasser
a58b14c9d2
executeAndAwaitJob() !executeJob() ClientLoanIntegrationTest un-ignore
...
re. FINERACT-885 and FINERACT-922
2020-06-02 19:46:04 +01:00
Michael Vorburger ⛑️
734cbb1d1f
Renovate ignore docs/ and add label [FINERACT-962]
2020-06-02 19:57:42 +02:00
Renovate Bot and Michael Vorburger ⛑️
9558f53765
Add renovate.json
2020-06-02 19:57:42 +02:00
Michael Vorburger
fd3b75711c
remove line in AbstractLoanScheduleGenerator [FINERACT-977]
...
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
2020-06-02 19:52:30 +02:00
Percy Ayuk Ashu and GitHub
16a69e7a4c
FINERACT-822 enable ArgumentSelectionDefectChecker warning ( #961 )
2020-06-02 17:32:52 +01:00
Michael Vorburger and Yemdjih Kaze Nasser
6f128bf508
minor clean-up to eliminate 'dead code' in CodeValue
...
This fixes one of too many ;) warnings Eclipse shows.
It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
2020-06-02 15:36:09 +01:00
Michael Vorburger and Yemdjih Kaze Nasser
956a84114f
improve StaffImageApiTest (for FINERACT-965 non-regression)
2020-06-02 15:29:45 +01:00
Michael Vorburger and Yemdjih Kaze Nasser
83de217b64
minor clean-up in StaffImageApiTest (re. FINERACT-965)
2020-06-02 15:29:45 +01:00
Michael Vorburger and Yemdjih Kaze Nasser
619fe44d0e
bump OpenPDF from 1.1.0 to 1.3.17 + swap Base64 [FINERACT-965]
...
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
2020-06-02 15:29:45 +01:00
nnatarajan and Yemdjih Kaze Nasser
df0bcb1b97
FINERACT-965 Upgrade, Replace itext 2.1.7 with Openpdf 1.1.0
2020-06-02 15:29:45 +01:00
Michael Vorburger
d439aa9545
replace api-docs links to mifos.io with fineract.dev [FINERACT-840]
2020-06-02 13:20:17 +02:00
Petri Tuomola and Michael Vorburger ⛑️
23fa22e096
FINERACT-855: Fixing test failures due to rounding difference
2020-06-02 13:00:00 +02:00
Saransh Sharma and Michael Vorburger ⛑️
b6e6eba56f
fix possible NPE in AbstractLoanScheduleGenerator
2020-06-01 21:53:02 +02:00
percyashu and Michael Vorburger ⛑️
aed3e41ca4
FINERACT-822 Enable CompareToZero check
2020-06-01 12:43:49 +02:00
Petri Tuomola and Michael Vorburger ⛑️
e295bef743
FINERACT-918: Changes to running and debugging in Eclipse
2020-06-01 11:45:15 +02:00