Commit Graph
100 Commits
Author SHA1 Message Date
Michael VorburgerandAleksandar Vidakovic db53a422b2 Remove un-used code & testImplementation dependencies from provider (FINERACT-1209) 2020-11-02 12:23:31 +01:00
Michael VorburgerandAleksandar Vidakovic a1687d974b Remove redundant testLogging etc. (FINERACT-1209)
because https://github.com/apache/fineract/pull/1477/files
moved this from fineract-provider/build.gradle to the root ./build.gradle
so it's inherited.
2020-11-02 12:09:49 +01:00
Michael VorburgerandAleksandar Vidakovic 2a2b4b59a1 Simplify Gradle invocation in Travis YAML (FINERACT-1250) 2020-11-02 12:02:32 +01:00
Michael VorburgerandPetri Tuomola 1e7f1f5847 Disable frequently failing SchedulerJobsTest.testFlippingSchedulerStatus (FINERACT-1167) 2020-11-01 19:13:30 +02:00
Michael Vorburger ⛑️andPetri Tuomola 892a6ee551 Add Swagger "badge" to README, currently showing INVALID (FINERACT-1249) 2020-11-01 06:26:23 +02:00
Michael VorburgerandAleksandar Vidakovic 349415917f Move Gradle test exceptionFormat up (FINERACT-1247) 2020-10-31 21:19:21 +01:00
Michael Vorburger 3583975bc6 Disable failing testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX (FINERACT-1248) 2020-10-31 16:26:44 +01:00
Michael Vorburger f08df636d3 Disable failing ImageTest (FINERACT-1247) 2020-10-31 16:26:44 +01:00
Michael Vorburger f4ada274ba Revert "FINERACT-1241-elastic-web-hook (#1466)"
This reverts commit 0a41cdc9d9.
2020-10-31 16:26:44 +01:00
Michael VorburgerandPetri Tuomola 91e77f5fe0 Add new ImageTest (FINERACT-1218) 2020-10-27 05:13:16 +02:00
Michael VorburgerandAleksandar Vidakovic 8a26685d79 client: Fix bad dateFormat in FineractClient (FINERACT-1242) 2020-10-26 11:27:31 +01:00
Michael VorburgerandAleksandar Vidakovic 420d26a679 Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException 2020-10-24 23:36:03 +02:00
Michael VorburgerandPetri Tuomola 5f42112278 client: Fix mediaType MIME code (FINERACT-1218) 2020-10-24 21:01:32 +03:00
Michael VorburgerandPetri Tuomola 20daf59a3e Add new DocumentTest (FINERACT-1218) 2020-10-23 20:50:00 +03:00
Michael VorburgerandPetri Tuomola ff0db483cd client: serialize LocalDate as 2009-01-01 (FINERACT-1234) 2020-10-23 06:47:04 +03:00
Michael VorburgerandAleksandar Vidakovic af1509abee client: Skip generating generated utilities which are broken (FINERACT-1231) 2020-10-22 12:25:00 +02:00
Michael VorburgerandPetri Tuomola 6d22549373 Fix possible NPE when uploading Documents & Images (FINERACT-1036) 2020-10-22 06:06:37 +03:00
Michael VorburgerandPetri Tuomola cb3260b61f Minor: Return bad Image MIME type to API client 2020-10-22 06:04:02 +03:00
Michael VorburgerandAleksandar Vidakovic 64d0b1fe58 client: Improve quick build doc 2020-10-21 18:41:17 +02:00
Michael VorburgerandAleksandar Vidakovic b75ced50df client: GSON TypeAdapter<LocalDate> Fineract API Format [2009,1,1] (FINERACT-1220) 2020-10-21 14:42:08 +02:00
Michael VorburgerandPetri Tuomola e2eec3924f Build all modules on Travis (FINERACT-1226) 2020-10-21 06:08:27 +03:00
Michael Vorburger 1af69db132 Introduce CallFailedRuntimeException in client 2020-10-20 23:58:16 +02:00
Michael Vorburger 27bebff4ac Do not expose getApiClient() in FineractClient (FINERACT-1220)
Because FineractClient is about to not use Swagger's ApiClient anymore.
2020-10-20 23:18:07 +02:00
Michael Vorburger.chandAleksandar Vidakovic c98cef85f6 Minor: Improve ApplicationExitUtil
It's currently actually un-used, but it could be used again
in the future, when we re-integrate MariaDB4j. (I had this
patch on a branch for months and wanted to get it upstream.)
2020-10-20 03:37:11 +02:00
Michael VorburgerandAleksandar Vidakovic bb64d3f1a5 Add insecure() support to FineractClient SDK API (FINERACT-1219) 2020-10-20 03:35:10 +02:00
Michael VorburgerandAleksandar Vidakovic 0897f172ee Limit fineract-client to Java 8 not 11 (FINERACT-1214) 2020-10-20 00:57:53 +02:00
Michael Vorburger ⛑️andAleksandar Vidakovic a1e9bc0899 Add initial Fineract SDK Java API Client documentation (FINERACT-1216) 2020-10-20 00:56:39 +02:00
Michael VorburgerandAleksandar Vidakovic 81552b41a0 Reduce fineract-client dependencies (FINERACT-1216) 2020-10-19 23:05:37 +02:00
Michael VorburgerandPetri Tuomola 9b2d95f9bb add logging support to SDK API client (FINERACT-1216) 2020-10-19 21:19:55 +03:00
Michael Vorburger db4d2ae006 Add FineractClientTest.testInvalidOperations (FINERACT-1221) 2020-10-19 17:58:43 +02:00
Michael Vorburger ⛑️andPetri Tuomola c8324a90b9 Create CONTRIBUTING.md 2020-10-19 16:19:35 +03:00
Michael Vorburger ⛑️andPetri Tuomola bd38655f88 Create CODE_OF_CONDUCT.md 2020-10-19 16:18:13 +03:00
Michael VorburgerandAleksandar Vidakovic 55b1d4f531 Simplify FineractClient SDK API (FINERACT-1216) 2020-10-19 14:40:43 +02:00
Michael VorburgerandAleksandar Vidakovic 19f2a38095 Add FineractClientTest for Fineract SDK REST Client (FINERACT-1216)
and introduce handy Calls utilitiy
2020-10-18 22:04:08 +02:00
Michael VorburgerandPetri Tuomola 00166d4543 remove weird ImageData.available (FINERACT-1201)
I don't understand what this really does, or how to test it.
It seems to have been original introduced for FINERACT-288
in PR #259, but the description there doesn't clearly enough
explain the problem.

Much related code is about to be substantially refactored, and
whatever problem this originally worked around may no longer be
present when the ongoing refactoring is fully completed.  If it
still is, then there will likely be a better way to address it.
2020-10-18 21:30:19 +03:00
Michael VorburgerandPetri Tuomola e054a6f0a2 Improve ProcessorHelper (FINERACT-1211) 2020-10-18 20:55:04 +03:00
Michael VorburgerandPetri Tuomola d83bdc4166 Add missing test coverage for Image 404 (FINERACT-1201) 2020-10-18 20:50:53 +03:00
Michael Vorburger 6c9f4efa9a rm org.threeten:threetenbp dependency 2020-10-18 18:05:51 +02:00
Michael VorburgerandPetri Tuomola 4bbc0ee3a7 add .mailmap 2020-10-17 19:50:51 +03:00
Michael VorburgerandPetri Tuomola 2af09708f1 Prepare FileSystemContentRepository for code re-use with S3ContentRepository (FINERACT-1201) 2020-10-14 10:34:02 +03:00
Michael VorburgerandPetri Tuomola 0146f518bc Improve exception handling and error logging in S3ContentRepository (FINERACT-1202) 2020-10-14 10:32:31 +03:00
Michael VorburgerandPetri Tuomola 75da7d9e29 Minor/Clean-up: remove un-used ContentRepository.type 2020-10-14 10:29:38 +03:00
Michael VorburgerandPetri Tuomola 8c342a7d88 Minor: Re-use Random in ContentRepositoryUtils instead of creating new one 2020-10-14 10:28:36 +03:00
Michael VorburgerandPetri Tuomola 6125cccef0 Minor improvements to ContentManagementException (FINERACT-1202) 2020-10-14 10:26:01 +03:00
Michael VorburgerandPetri Tuomola 02408f9165 Make ./gradlew bootRun have colors, like java -jar *.jar (FINERACT-1078) 2020-10-12 07:00:50 +03:00
Michael Vorburger ad87660f73 Remove jul-to-slf4j exclusion (FINERACT-1199) 2020-10-11 23:16:10 +02:00
Michael VorburgerandPetri Tuomola 6a6c0301b6 Simplify appContext.xml, mv all *Repository into .domain. packages, rm spmContext.xml (FINERACT-1175) 2020-10-11 22:07:00 +03:00
Michael VorburgerandPetri Tuomola e978971c67 Remove license header from .dockerignore (FINERACT-1195) 2020-10-11 18:42:44 +03:00
Michael Vorburger 09e08fdc71 Merge git tag '1.4.0' into branch 'develop' (FINERACT-1154)
git checkout develop
    git checkout -b FINERACT-1154_merge-1.4.0
    git merge -s recursive -Xignore-all-space 1.4.0

see discussion in https://issues.apache.org/jira/browse/FINERACT-1154
for the full background about why we are doing this; the TL;DR is that
this makes `git describe` work correctly, which is important for automation.
2020-10-11 14:50:44 +02:00
Michael Vorburger 768ffecd90 Remove mavenCentral(), because jcenter() includes it 2020-10-10 15:56:28 +02:00
Michael Vorburger 504eeed431 Clean up whitespace issues, only (FINERACT-1188) 2020-10-10 11:33:09 +02:00
Michael VorburgerandPetri Tuomola 66e26beae1 exclude awssdk:s3 from flyway-core dependency [FINERACT-1172]
see https://github.com/apache/fineract/pull/1355
2020-10-04 18:33:41 +03:00
Michael Vorburger ⛑️andPetri Tuomola e8344e23fa clarify DB config in README 2020-09-29 06:35:55 +03:00
Michael Vorburger f73f5ef50f Change OAuth doc in apiLive.htm (FINERACT-629) 2020-09-22 19:52:18 +02:00
Michael VorburgerandAwasum Yannick ece9c0338b add OAuth documentation (FINERACT-1145) 2020-09-19 09:54:32 +01:00
Michael Vorburger ⛑️andPetri Tuomola 6ac3eea0bc Fix SQLBuilder IAE from StaffReadPlatformServiceImpl (FINERACT-1149) 2020-09-12 06:36:16 +03:00
Michael Vorburger ⛑️andGitHub 4b435c712b add Merge Strategy section to README (#1284)
includes improved PR Template (and move commit message blurb in README)
2020-09-06 19:10:07 +02:00
Michael Vorburger ⛑️ bc60bc379a Update fineract-provider/config/swagger/fineract-input.yaml 2020-08-02 17:48:43 +02:00
Michael Vorburger ⛑️ 98645840a5 minor Swagger clean-up in README 2020-08-02 16:59:09 +02:00
Michael Vorburger ⛑️andPetri Tuomola c5c62de491 Use java8 instead of joda as dateLibrary in Swagger Client (FINERACT-838) 2020-08-02 06:23:25 +03:00
Michael Vorburger 9534e7e0a3 fix broken build 2020-07-19 16:43:41 +02:00
Michael Vorburger ⛑️ 55b44dbf12 Update openjpa to v3.1.2 also in dependencyManagement not just buildscript 2020-07-19 15:45:54 +02:00
Michael Vorburger 1623e80a7f make ApiParameterError (almost) immutable
by making (most of) its fields final, because Immutable is Good

Only "almost" / "most" because of the of the remaining use of setParameterName() in
EntityDatatableChecksWritePlatformServiceImpl.saveDatatables() which unfortunately looks
a lot less trivial to get rid of, so that's for another time/someone else, later (or never).
2020-07-02 21:47:02 +02:00
Michael Vorburger 10536c0f91 make SimpleDateFormat use in ApiParameterError thread-safe [FINERACT-1063] 2020-07-02 21:46:10 +02:00
Michael Vorburger 2e32166079 Make Google's Guava library an explicit dependency
Instead of only transitively inheriting it through activemq-broker,
so that the upcoming next major upgrade of activemq-broker doesn't break the build.

Note that Fineract code already extensively uses Guava, this just makes it explicit.
2020-07-02 21:45:40 +02:00
Michael Vorburger 9ed9153cba use AbstractPlatformException's defaultUserMessage as RuntimeException's message [FINERACT-1062] 2020-06-30 21:28:20 +02:00
Michael Vorburger bcfbe65d56 use new AbstractPlatformException in AbstractPlatformException
only indirectly related to FINERACT-942, but makes sense to do so now
2020-06-30 21:28:20 +02:00
Michael Vorburger 56cad56848 use AbstractPlatformException as superclass for various exceptions
related to FINERACT-942 and as per code review discussion in PR #1079.
2020-06-30 21:28:20 +02:00
Michael VorburgerandYemdjih Kaze Nasser 24d4c45d9a introduce Throwable cause to AbstractPlatformResourceNotFoundException (re. FINERACT-942) 2020-06-24 16:03:10 +01:00
Michael VorburgerandAwasum Yannick eb2b39f160 add @Disabled to 2 old unit tests (which perhaps should be removed)
This saves a few seconds ;) in the build, and (more importantly)
makes it easier to find all the project's @Disabled (formerly @Ignore) tests.
2020-06-24 10:39:20 +01:00
Michael Vorburger c529fdf58c increase auto formatting comment line length from 80 to 120 2020-06-23 10:01:12 +02:00
Michael Vorburger 9da5932307 bulk auto reformat ca. 2900 files using ./gradlew :spotlessApply [FINERACT-1006] 2020-06-14 18:31:47 +02:00
Michael Vorburger 64628345a0 remove (old, bad) SchedulerJobHelper.executeJob() [FINERACT-922] 2020-06-14 17:51:57 +02:00
Michael Vorburger 67e6e27b54 fix broken tests under JUnit 5 [FINERACT-1021] 2020-06-14 17:21:07 +02:00
Michael Vorburger 508e915b4f add missing useJUnitPlatform() to make Gradle run JUnit 5 [FINERACT-1021] 2020-06-14 17:21:07 +02:00
Michael Vorburger 4528231fd1 remove bad 'default:' in SavingsEnumerations switch
This default: is "wrong", because it's not required - the switch,
in this particular case, *IS* actually already handling all cases.

But if in the future someone were to add an additional new
SavingsAccountTransactionType, then we would want Error Prone to
fail to signal that it needs to be handled here - but the "default:"
would "hide" that.

This is a follow-up to https://github.com/apache/fineract/pull/983/
for FINERACT-822, and also related to the discussion started on
https://github.com/apache/fineract/pull/989.

There originally used to be a "default:" in the middle of the switch,
that obviously WAS completely wrong and an old copy-paste bug.
2020-06-07 18:40:08 +02:00
Michael Vorburger dcaaf1a4e8 do NOT .gitignore gradle/ as it IS in Git (FINERACT-962) 2020-06-07 14:11:04 +02:00
Michael VorburgerandYemdjih Kaze Nasser 0e6a0e3ee3 remove old constructor from SchedulerJobHelper (related to FINERACT-922) 2020-06-07 13:08:08 +01:00
Michael Vorburger ⛑️andGitHub 7a2d459af3 Merge pull request #972 from percyashu/errorprone_variableNameSameAsType
FINERACT-822 enable variableNameSameAsType warning
2020-06-03 22:13:56 +02:00
Michael VorburgerandYemdjih Kaze Nasser 0c6903fc36 executeAndAwaitJob() instead executeJob() in un-ignored FixedDepositTest
re. FINERACT-950 and FINERACT-922
2020-06-03 01:59:14 +01:00
Michael Vorburger c95fb17f6e minor: simplify hashCode() in CenterDomain 2020-06-02 21:15:36 +02:00
Michael VorburgerandYemdjih Kaze Nasser 60dd63d55f executeAndAwaitJob() !executeJob() ClientSavingsIntegrationTest
re. FINERACT-852 and FINERACT-922
2020-06-02 19:49:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser a58b14c9d2 executeAndAwaitJob() !executeJob() ClientLoanIntegrationTest un-ignore
re. FINERACT-885 and FINERACT-922
2020-06-02 19:46:04 +01:00
Michael Vorburger ⛑️ 734cbb1d1f Renovate ignore docs/ and add label [FINERACT-962] 2020-06-02 19:57:42 +02:00
Michael Vorburger fd3b75711c remove line in AbstractLoanScheduleGenerator [FINERACT-977]
It was wrongly added in commit re. fix possible NPE in AbstractLoanScheduleGenerator.
2020-06-02 19:52:30 +02:00
Michael VorburgerandYemdjih Kaze Nasser 6f128bf508 minor clean-up to eliminate 'dead code' in CodeValue
This fixes one of too many ;) warnings Eclipse shows.

It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's actually pretty impressive that JDT, the Eclipse
Java compiler, can figure this out; it's "smarter" than javac).
2020-06-02 15:36:09 +01:00
Michael VorburgerandYemdjih Kaze Nasser 956a84114f improve StaffImageApiTest (for FINERACT-965 non-regression) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 83de217b64 minor clean-up in StaffImageApiTest (re. FINERACT-965) 2020-06-02 15:29:45 +01:00
Michael VorburgerandYemdjih Kaze Nasser 619fe44d0e bump OpenPDF from 1.1.0 to 1.3.17 + swap Base64 [FINERACT-965]
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
2020-06-02 15:29:45 +01:00
Michael Vorburger d439aa9545 replace api-docs links to mifos.io with fineract.dev [FINERACT-840] 2020-06-02 13:20:17 +02:00
Michael VorburgerandYemdjih Kaze Nasser 1db6e8d206 fix ClasspathHellDuplicatesCheckRuleTest (FINERACT-966)
and prevent FINERACT-940 related javax.xml.parsers problems

as per https://github.com/spotbugs/spotbugs/issues/1128
2020-05-29 06:13:23 +01:00
Michael Vorburger 4b108f02ec fix broken build due to @Deprecated error [FINERACT-1012] 2020-05-28 22:36:03 +02:00
Michael Vorburger ⛑️andGitHub b3da50c960 intro. SchedulerJobsHelper.executeAndAwaitJob() [FINERACT-922] (#817) 2020-05-24 20:54:37 +01:00
Michael Vorburger ⛑️andGitHub 4cb9f9d3e0 improve logging in SchedulerTriggerListener (re. FINERACT-922) (#812) 2020-05-24 20:18:36 +01:00
Michael Vorburger ⛑️ 4194da2b90 add new Logging Guidelines section to README (re. FINERACT-942) 2020-05-23 20:48:44 +02:00
Michael Vorburger ⛑️andGitHub dc7c1f8404 add link to our shiny new JIRA Dashboard to README [FINERACT-1000] (#929)
also remove link to supposed "Roadmap", because that really was just a confusing link to 1000 JIRA issues.

see FINERACT-1000
2020-05-23 14:52:28 +01:00
Michael VorburgerandYemdjih Kaze Nasser 5b1c46c821 remove logback.xml (see FINERACT-888)
Read e.g. https://12factor.net/logs for why we don't want to log
to a fineract-platform.log file anymore by default.  Of course, anyone
could still customize logging as they see fit for their own deployments.
2020-05-23 12:38:20 +01:00
Michael VorburgerandYemdjih Kaze Nasser 3d0d515b4b ignore StorageTest [FINERACT-828] 2020-05-22 03:56:22 +01:00
Michael VorburgerandYemdjih Kaze Nasser d4e8a7edd0 do not attempt to run Deploy to Fineract.dev GitHub Workflow on Forks [FINERACT-970] 2020-05-22 03:47:17 +01:00
Michael Vorburger ⛑️andGitHub f93cd4dbbd minor README moves (#909) 2020-05-20 11:33:09 +01:00